You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2019/12/02 09:23:49 UTC

[Bug 63981] New: False-positive warning logged when Registry.disableRegistry is called and the registry has already been disabled

https://bz.apache.org/bugzilla/show_bug.cgi?id=63981

            Bug ID: 63981
           Summary: False-positive warning logged when
                    Registry.disableRegistry is called and the registry
                    has already been disabled
           Product: Tomcat 9
           Version: 9.0.x
          Hardware: PC
                OS: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Util
          Assignee: dev@tomcat.apache.org
          Reporter: awilkinson@pivotal.io
  Target Milestone: -----

Calling org.apache.tomcat.util.modeler.Registry.disableRegistry() assigns an
instance of NoDescriptorRegistry to the static registry field. Subsequent
invocations then log a warning that states that the registry cannot be disabled
as it has already been initialised. These feels like a false-positive to me
when registry is an instance of NoDescriptorRegistry. To avoid the unwanted
warning, could the check be changed to something like the following:

if (registry == null) {
    registry = new NoDescriptorRegistry();
} else if (!registry instanceof NoDescriptorRegistry) {
    log.warn(sm.getString("registry.noDisable"));
}

This would improve log output in integration tests using embedded Tomcat where
Tomcat may be initialised multiple times.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 63981] False-positive warning logged when Registry.disableRegistry is called and the registry has already been disabled

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63981

--- Comment #2 from Andy Wilkinson <aw...@pivotal.io> ---
Thanks, Mark. Much appreciated.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 63981] False-positive warning logged when Registry.disableRegistry is called and the registry has already been disabled

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63981

Phillip Webb <pw...@pivotal.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pwebb@pivotal.io

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 63981] False-positive warning logged when Registry.disableRegistry is called and the registry has already been disabled

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63981

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #1 from Mark Thomas <ma...@apache.org> ---
Thanks for the report and the suggested fix. Works for me.

Fixed in:
- master for 9.0.30 onwards

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org