[jira] [Comment Edited] (GROOVY-9236) Avoid unnecessary resolving

["Daniel Sun (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GROOVY-9236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16919761#comment-16919761 ] 

Daniel Sun edited comment on GROOVY-9236 at 8/30/19 5:36 PM:
-------------------------------------------------------------

As you can find, {{resolveFromStaticInnerClasses}} will only resolve classes whose name contains dots.

https://github.com/apache/groovy/blob/f22ad15939695a47522fdef4dd0aacef6ba667d2/src/main/java/org/codehaus/groovy/control/ResolveVisitor.java#L563-L581

However {{resolveToOuter}} resolves types via {{classNodeResolver.resolveName}}, which treats dots as sub-packages, i.e. it will NOT resolve inner classes whose name contains dots.

https://github.com/apache/groovy/blob/f22ad15939695a47522fdef4dd0aacef6ba667d2/src/main/java/org/codehaus/groovy/control/ResolveVisitor.java#L845

So no overlap in their target classes to resolve, thus no resolving precedence will be changed.



was (Author: daniel_sun):
As you can find, {{resolveFromStaticInnerClasses}} will only resolve classes whose name contains dots.

https://github.com/apache/groovy/blob/f22ad15939695a47522fdef4dd0aacef6ba667d2/src/main/java/org/codehaus/groovy/control/ResolveVisitor.java#L563-L581

However {{resolveToOuter}} resolves types via {{classNodeResolver.resolveName}}, which treats dots as sub-packages, i.e. it will resolve inner classes whose name contains dots.

https://github.com/apache/groovy/blob/f22ad15939695a47522fdef4dd0aacef6ba667d2/src/main/java/org/codehaus/groovy/control/ResolveVisitor.java#L845

So no overlap in their target classes to resolve, thus no resolving precedence will be changed.


> Avoid unnecessary resolving
> ---------------------------
>
>                 Key: GROOVY-9236
>                 URL: https://issues.apache.org/jira/browse/GROOVY-9236
>             Project: Groovy
>          Issue Type: Improvement
>            Reporter: Daniel Sun
>            Assignee: Daniel Sun
>            Priority: Major
>             Fix For: 3.0.0-beta-4
>
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> {{ResolveVisitor}}'s {{resolveFromStaticInnerClasses}}, {{resolveFromDefaultImports}} and {{resolveNestedClass}} will try to guess class qualified name and load. In the process of resolving, lots of time wasted on finding non-existing classes. So we should try to resolve classes in a determined manner.
> For example,
> For {{java.util.stream.Collectors}},  ① {{resolveFromStaticInnerClasses}} will try to guess {{java.util.stream$Collectors}}, {{java.util$stream$Collectors}}, {{java$util$stream$Collectors}}.
> And ② {{resolveFromDefaultImports}} will guess {{java.lang.java$util$stream$Collectors}},  {{java.util.java$util$stream$Collectors}}, ...,  {{groovy.lang.java$util$stream$Collectors}}.
> After the precedence of resolving adjusted, the above unnecessary resolving can be avoided.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)