[GitHub] [activemq-nms-amqp] michaelpearce-gain commented on a change in pull request #53: AMQNET-634: Use 4 as default msg priority

[GitBox <gi...@apache.org>]

michaelpearce-gain commented on a change in pull request #53: AMQNET-634: Use 4 as default msg priority
URL: https://github.com/apache/activemq-nms-amqp/pull/53#discussion_r374540801
 
 

 ##########
 File path: test/Apache-NMS-AMQP-Test/NmsMessageProducerTest.cs
 ##########
 @@ -77,7 +77,7 @@ public void TestGetDisableTimeStamp()
         public void TestPriorityConfiguration()
         {
             IMessageProducer producer = session.CreateProducer(null);
-            Assert.AreEqual(NMSConstants.defaultPriority, producer.Priority);
+            Assert.AreEqual(MsgPriority.BelowNormal, producer.Priority);
 
 Review comment:
   I would be explicit here with using int 4 (so we explicitly test the spec), rather than relying on a constant from outside the test pack, which it could change....

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services