You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "jwilliams-ocient (via GitHub)" <gi...@apache.org> on 2023/04/25 15:24:07 UTC
[GitHub] [superset] jwilliams-ocient opened a new pull request, #23814: fix[ocient]: convert pyocient GIS data types to geoJSON or Polyline
jwilliams-ocient opened a new pull request, #23814:
URL: https://github.com/apache/superset/pull/23814
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
This PR addresses a bug that sometimes causes the Ocient engine to emit invalid polygon and linestring objects. See commit messages for more info.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jwilliams-ocient commented on pull request #23814: fix(ocient): convert pyocient GIS data types to geoJSON
Posted by "jwilliams-ocient (via GitHub)" <gi...@apache.org>.
jwilliams-ocient commented on PR #23814:
URL: https://github.com/apache/superset/pull/23814#issuecomment-1526285921
There's a CSV test broken on the master branch. Once the fix has been merged I will close/reopen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jwilliams-ocient commented on pull request #23814: fix(ocient): convert pyocient GIS data types to geoJSON
Posted by "jwilliams-ocient (via GitHub)" <gi...@apache.org>.
jwilliams-ocient commented on PR #23814:
URL: https://github.com/apache/superset/pull/23814#issuecomment-1551904190
Alright, I think this one is ready to merge. Thanks @villebro , @rusackas !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jwilliams-ocient closed pull request #23814: fix(ocient): convert pyocient GIS data types to geoJSON
Posted by "jwilliams-ocient (via GitHub)" <gi...@apache.org>.
jwilliams-ocient closed pull request #23814: fix(ocient): convert pyocient GIS data types to geoJSON
URL: https://github.com/apache/superset/pull/23814
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #23814: fix[ocient]: convert pyocient GIS data types to geoJSON or Polyline
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23814:
URL: https://github.com/apache/superset/pull/23814#issuecomment-1522032076
## [Codecov](https://codecov.io/gh/apache/superset/pull/23814?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23814](https://codecov.io/gh/apache/superset/pull/23814?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c1dde9b) into [master](https://codecov.io/gh/apache/superset/commit/6ae5388dcf0205e89d4abcc5cefcb644e8c7cdbd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6ae5388) will **decrease** coverage by `1.62%`.
> The diff coverage is `83.81%`.
> :exclamation: Current head c1dde9b differs from pull request most recent head 736b627. Consider uploading reports for the commit 736b627 to get more accurate results
```diff
@@ Coverage Diff @@
## master #23814 +/- ##
==========================================
- Coverage 67.86% 66.24% -1.62%
==========================================
Files 1926 1936 +10
Lines 74498 74943 +445
Branches 8108 8141 +33
==========================================
- Hits 50555 49645 -910
- Misses 21866 23210 +1344
- Partials 2077 2088 +11
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `78.77% <89.78%> (+0.10%)` | :arrow_up: |
| postgres | `78.85% <89.78%> (+0.10%)` | :arrow_up: |
| presto | `?` | |
| python | `78.98% <89.78%> (-3.59%)` | :arrow_down: |
| sqlite | `77.37% <89.78%> (+0.11%)` | :arrow_up: |
| unit | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/23814?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...chart-echarts/src/Timeseries/EchartsTimeseries.tsx](https://codecov.io/gh/apache/superset/pull/23814?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9FY2hhcnRzVGltZXNlcmllcy50c3g=) | `0.00% <0.00%> (ø)` | |
| [...lLab/components/ExploreCtasResultsButton/index.tsx](https://codecov.io/gh/apache/superset/pull/23814?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVDdGFzUmVzdWx0c0J1dHRvbi9pbmRleC50c3g=) | `91.66% <ø> (+83.33%)` | :arrow_up: |
| [...c/SqlLab/components/ExploreResultsButton/index.tsx](https://codecov.io/gh/apache/superset/pull/23814?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...tend/src/components/Datasource/DatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/23814?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YXNvdXJjZS9EYXRhc291cmNlTW9kYWwudHN4) | `73.46% <0.00%> (-1.54%)` | :arrow_down: |
| [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/superset/pull/23814?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | `49.61% <ø> (ø)` | |
| [...c/visualizations/FilterBox/FilterBoxChartPlugin.js](https://codecov.io/gh/apache/superset/pull/23814?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3hDaGFydFBsdWdpbi5qcw==) | `66.66% <ø> (ø)` | |
| [superset/db\_engine\_specs/ocient.py](https://codecov.io/gh/apache/superset/pull/23814?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL29jaWVudC5weQ==) | `52.99% <24.00%> (-4.30%)` | :arrow_down: |
| [superset-frontend/src/views/routes.tsx](https://codecov.io/gh/apache/superset/pull/23814?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL3JvdXRlcy50c3g=) | `51.06% <50.00%> (-0.05%)` | :arrow_down: |
| [superset/dao/base.py](https://codecov.io/gh/apache/superset/pull/23814?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFvL2Jhc2UucHk=) | `92.85% <70.00%> (-2.60%)` | :arrow_down: |
| [...-frontend/src/pages/RowLevelSecurityList/index.tsx](https://codecov.io/gh/apache/superset/pull/23814?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3BhZ2VzL1Jvd0xldmVsU2VjdXJpdHlMaXN0L2luZGV4LnRzeA==) | `72.54% <72.54%> (ø)` | |
| ... and [17 more](https://codecov.io/gh/apache/superset/pull/23814?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
... and [93 files with indirect coverage changes](https://codecov.io/gh/apache/superset/pull/23814/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jwilliams-ocient commented on a diff in pull request #23814: fix(ocient): convert pyocient GIS data types to geoJSON
Posted by "jwilliams-ocient (via GitHub)" <gi...@apache.org>.
jwilliams-ocient commented on code in PR #23814:
URL: https://github.com/apache/superset/pull/23814#discussion_r1179297745
##########
superset/db_engine_specs/ocient.py:
##########
@@ -84,39 +84,87 @@ def _to_hex(data: bytes) -> str:
return data.hex()
-def _polygon_to_json(polygon: Any) -> str:
+def _wkt_to_geoJSON(geo_as_wkt: Any) -> Any:
+ """
+ Converts pyocient geometry objects to their geoJSON representation.
+
+ :param geo_as_wkt: the GIS object in WKT format
+ :returns: the geoJSON encoding of `geo`
+ """
+ import geojson
+ from shapely import wkt
+
+ geo = wkt.loads(geo_as_wkt)
+ return geojson.Feature(geometry=geo, properties={})
+
+
+def _point_list_to_wkt(points: Any) -> str:
"""
- Converts the _STPolygon object into its JSON representation.
+ Converts the list of pyocient._STPoint elements to a WKT LineString.
- :param data: the polygon object
- :returns: JSON representation of the polygon
+ :param points: the list of pyocient._STPoint objects
+ :returns: WKT LineString
"""
- json_value = f"{str([[p.long, p.lat] for p in polygon.exterior])}"
- if polygon.holes:
- for hole in polygon.holes:
- json_value += f", {str([[p.long, p.lat] for p in hole])}"
- json_value = f"[{json_value}]"
- return json_value
+ coords = [f"{p.long} {p.lat}" for p in points]
+ return f"LINESTRING({', '.join(coords)})"
-def _linestring_to_json(linestring: Any) -> str:
+def _point_to_geoJSON(point: Any) -> Any:
"""
- Converts the _STLinestring object into its JSON representation.
+ Converts the pyocient._STPolygon object to the geoJSON format
- :param data: the linestring object
- :returns: JSON representation of the linestring
+ :param point: the pyocient._STPoint instance
+ :returns: the geoJSON encoding of this point
"""
- return f"{str([[p.long, p.lat] for p in linestring.points])}"
+ wkt_point = str(point)
+ return _wkt_to_geoJSON(wkt_point)
+
+
+def _linestring_to_geoJSON(linestring: Any) -> Any:
Review Comment:
It does but mypy blows up when annotating types imported from any of the optional Ocient dependencies. There might be a way to get mypy to ignore these errors though
##########
superset/db_engine_specs/ocient.py:
##########
@@ -84,39 +84,87 @@ def _to_hex(data: bytes) -> str:
return data.hex()
-def _polygon_to_json(polygon: Any) -> str:
+def _wkt_to_geoJSON(geo_as_wkt: Any) -> Any:
+ """
+ Converts pyocient geometry objects to their geoJSON representation.
+
+ :param geo_as_wkt: the GIS object in WKT format
+ :returns: the geoJSON encoding of `geo`
+ """
+ import geojson
+ from shapely import wkt
+
+ geo = wkt.loads(geo_as_wkt)
+ return geojson.Feature(geometry=geo, properties={})
+
+
+def _point_list_to_wkt(points: Any) -> str:
"""
- Converts the _STPolygon object into its JSON representation.
+ Converts the list of pyocient._STPoint elements to a WKT LineString.
- :param data: the polygon object
- :returns: JSON representation of the polygon
+ :param points: the list of pyocient._STPoint objects
+ :returns: WKT LineString
"""
- json_value = f"{str([[p.long, p.lat] for p in polygon.exterior])}"
- if polygon.holes:
- for hole in polygon.holes:
- json_value += f", {str([[p.long, p.lat] for p in hole])}"
- json_value = f"[{json_value}]"
- return json_value
+ coords = [f"{p.long} {p.lat}" for p in points]
+ return f"LINESTRING({', '.join(coords)})"
-def _linestring_to_json(linestring: Any) -> str:
+def _point_to_geoJSON(point: Any) -> Any:
"""
- Converts the _STLinestring object into its JSON representation.
+ Converts the pyocient._STPolygon object to the geoJSON format
- :param data: the linestring object
- :returns: JSON representation of the linestring
+ :param point: the pyocient._STPoint instance
+ :returns: the geoJSON encoding of this point
"""
- return f"{str([[p.long, p.lat] for p in linestring.points])}"
+ wkt_point = str(point)
+ return _wkt_to_geoJSON(wkt_point)
+
+
+def _linestring_to_geoJSON(linestring: Any) -> Any:
Review Comment:
Looking at https://mypy.readthedocs.io/en/stable/runtime_troubles.html#
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] daveboutcher commented on a diff in pull request #23814: fix(ocient): convert pyocient GIS data types to geoJSON
Posted by "daveboutcher (via GitHub)" <gi...@apache.org>.
daveboutcher commented on code in PR #23814:
URL: https://github.com/apache/superset/pull/23814#discussion_r1179095664
##########
superset/db_engine_specs/ocient.py:
##########
@@ -84,39 +84,87 @@ def _to_hex(data: bytes) -> str:
return data.hex()
-def _polygon_to_json(polygon: Any) -> str:
+def _wkt_to_geoJSON(geo_as_wkt: Any) -> Any:
+ """
+ Converts pyocient geometry objects to their geoJSON representation.
+
+ :param geo_as_wkt: the GIS object in WKT format
+ :returns: the geoJSON encoding of `geo`
+ """
+ import geojson
+ from shapely import wkt
+
+ geo = wkt.loads(geo_as_wkt)
+ return geojson.Feature(geometry=geo, properties={})
+
+
+def _point_list_to_wkt(points: Any) -> str:
"""
- Converts the _STPolygon object into its JSON representation.
+ Converts the list of pyocient._STPoint elements to a WKT LineString.
- :param data: the polygon object
- :returns: JSON representation of the polygon
+ :param points: the list of pyocient._STPoint objects
+ :returns: WKT LineString
"""
- json_value = f"{str([[p.long, p.lat] for p in polygon.exterior])}"
- if polygon.holes:
- for hole in polygon.holes:
- json_value += f", {str([[p.long, p.lat] for p in hole])}"
- json_value = f"[{json_value}]"
- return json_value
+ coords = [f"{p.long} {p.lat}" for p in points]
+ return f"LINESTRING({', '.join(coords)})"
-def _linestring_to_json(linestring: Any) -> str:
+def _point_to_geoJSON(point: Any) -> Any:
"""
- Converts the _STLinestring object into its JSON representation.
+ Converts the pyocient._STPolygon object to the geoJSON format
- :param data: the linestring object
- :returns: JSON representation of the linestring
+ :param point: the pyocient._STPoint instance
+ :returns: the geoJSON encoding of this point
"""
- return f"{str([[p.long, p.lat] for p in linestring.points])}"
+ wkt_point = str(point)
+ return _wkt_to_geoJSON(wkt_point)
+
+
+def _linestring_to_geoJSON(linestring: Any) -> Any:
Review Comment:
Why `Any`? doesn't this take an STLinesTring and produce a known type?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jwilliams-ocient commented on a diff in pull request #23814: fix(ocient): convert pyocient GIS data types to geoJSON
Posted by "jwilliams-ocient (via GitHub)" <gi...@apache.org>.
jwilliams-ocient commented on code in PR #23814:
URL: https://github.com/apache/superset/pull/23814#discussion_r1179410135
##########
superset/db_engine_specs/ocient.py:
##########
@@ -84,39 +84,87 @@ def _to_hex(data: bytes) -> str:
return data.hex()
-def _polygon_to_json(polygon: Any) -> str:
+def _wkt_to_geoJSON(geo_as_wkt: Any) -> Any:
+ """
+ Converts pyocient geometry objects to their geoJSON representation.
+
+ :param geo_as_wkt: the GIS object in WKT format
+ :returns: the geoJSON encoding of `geo`
+ """
+ import geojson
+ from shapely import wkt
+
+ geo = wkt.loads(geo_as_wkt)
+ return geojson.Feature(geometry=geo, properties={})
+
+
+def _point_list_to_wkt(points: Any) -> str:
"""
- Converts the _STPolygon object into its JSON representation.
+ Converts the list of pyocient._STPoint elements to a WKT LineString.
- :param data: the polygon object
- :returns: JSON representation of the polygon
+ :param points: the list of pyocient._STPoint objects
+ :returns: WKT LineString
"""
- json_value = f"{str([[p.long, p.lat] for p in polygon.exterior])}"
- if polygon.holes:
- for hole in polygon.holes:
- json_value += f", {str([[p.long, p.lat] for p in hole])}"
- json_value = f"[{json_value}]"
- return json_value
+ coords = [f"{p.long} {p.lat}" for p in points]
+ return f"LINESTRING({', '.join(coords)})"
-def _linestring_to_json(linestring: Any) -> str:
+def _point_to_geoJSON(point: Any) -> Any:
"""
- Converts the _STLinestring object into its JSON representation.
+ Converts the pyocient._STPolygon object to the geoJSON format
- :param data: the linestring object
- :returns: JSON representation of the linestring
+ :param point: the pyocient._STPoint instance
+ :returns: the geoJSON encoding of this point
"""
- return f"{str([[p.long, p.lat] for p in linestring.points])}"
+ wkt_point = str(point)
+ return _wkt_to_geoJSON(wkt_point)
+
+
+def _linestring_to_geoJSON(linestring: Any) -> Any:
Review Comment:
resolved by using [type comments](https://mypy.readthedocs.io/en/stable/runtime_troubles.html#string-literal-types-and-type-comments)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jwilliams-ocient commented on pull request #23814: fix(ocient): convert pyocient GIS data types to geoJSON
Posted by "jwilliams-ocient (via GitHub)" <gi...@apache.org>.
jwilliams-ocient commented on PR #23814:
URL: https://github.com/apache/superset/pull/23814#issuecomment-1526233973
Closing and reopening to kick off new CI run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jwilliams-ocient commented on a diff in pull request #23814: fix(ocient): convert pyocient GIS data types to geoJSON
Posted by "jwilliams-ocient (via GitHub)" <gi...@apache.org>.
jwilliams-ocient commented on code in PR #23814:
URL: https://github.com/apache/superset/pull/23814#discussion_r1178222872
##########
superset/db_engine_specs/ocient.py:
##########
@@ -15,6 +15,7 @@
# specific language governing permissions and limitations
# under the License.
+import json
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #23814: fix(ocient): convert pyocient GIS data types to geoJSON
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #23814:
URL: https://github.com/apache/superset/pull/23814#issuecomment-1551947365
Thank YOU!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #23814: fix(ocient): convert pyocient GIS data types to geoJSON
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #23814:
URL: https://github.com/apache/superset/pull/23814
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org