[jira] [Commented] (HDFS-4520) Support listing snapshots under a snapshottable directory using "ls"

["Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-4520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13585232#comment-13585232 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-4520:
----------------------------------------------

- Use substring instead of split.  Otherwise "/my.photo.snapshots/foo/.snapshot" will be spit unexpectedly.  You may want to add a test case for such paths.

- Use the three-parameter createFileStatus.

- Search snapshots directly by "ReadOnlyList.Util.binarySearch(snapshots, startAfter)" and keep INodeDirectorySnapshottable.searchSnapshot private.

- TestSnapshotListing needs license header.
                
> Support listing snapshots under a snapshottable directory using "ls"
> --------------------------------------------------------------------
>
>                 Key: HDFS-4520
>                 URL: https://issues.apache.org/jira/browse/HDFS-4520
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>         Attachments: HDFS-4520.000.patch, HDFS-4520.001.patch
>
>
> Before developing a specific command/tool for listing snapshots with different criteria, we can first support snapshot listing using normal ls command. Users can list all the snapshots under a snapshottable directory using "ls /snapshottable_dir_path/.snapshot".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira