You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/12/27 12:22:10 UTC

[GitHub] [ignite] alex-plekhanov opened a new pull request #9696: IGNITE-14195 Query engines configuration

alex-plekhanov opened a new pull request #9696:
URL: https://github.com/apache/ignite/pull/9696


   Thank you for submitting the pull request to the Apache Ignite.
   
   In order to streamline the review of the contribution 
   we ask you to ensure the following steps have been taken:
   
   ### The Contribution Checklist
   - [ ] There is a single JIRA ticket related to the pull request. 
   - [ ] The web-link to the pull request is attached to the JIRA ticket.
   - [ ] The JIRA ticket has the _Patch Available_ state.
   - [ ] The pull request body describes changes that have been made. 
   The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
   - [ ] The pull request title is treated as the final commit message. 
   The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
   - [ ] A reviewer has been mentioned through the JIRA comments 
   (see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers)) 
   - [ ] The pull request has been checked by the Teamcity Bot and 
   the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
   
   ### Notes
   - [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
   - [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
   - [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
   - [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
   
   If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] AMashenkov commented on a change in pull request #9696: IGNITE-14195 Query engines configuration

Posted by GitBox <gi...@apache.org>.
AMashenkov commented on a change in pull request #9696:
URL: https://github.com/apache/ignite/pull/9696#discussion_r784695297



##########
File path: modules/calcite/src/main/java/org/apache/ignite/calcite/CalciteQueryEngineConfiguration.java
##########
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.calcite;
+
+import org.apache.ignite.internal.processors.query.QueryEngine;
+import org.apache.ignite.internal.processors.query.QueryEngineConfigurationEx;
+import org.apache.ignite.internal.processors.query.calcite.CalciteQueryProcessor;
+import org.apache.ignite.lang.IgniteExperimental;
+
+/**
+ * Query engine configuration for Calcite-based query engine.
+ */
+@IgniteExperimental
+public class CalciteQueryEngineConfiguration implements QueryEngineConfigurationEx {
+    /** Query engine name. */
+    public static final String ENGINE_NAME = "calcite";
+
+    /** */
+    private volatile boolean isDflt;

Review comment:
       Why does the configuration contains a `volatile` field?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] alex-plekhanov commented on pull request #9696: IGNITE-14195 Query engines configuration

Posted by GitBox <gi...@apache.org>.
alex-plekhanov commented on pull request #9696:
URL: https://github.com/apache/ignite/pull/9696#issuecomment-1047506741


   Merged to sql-calcite


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] alex-plekhanov commented on a change in pull request #9696: IGNITE-14195 Query engines configuration

Posted by GitBox <gi...@apache.org>.
alex-plekhanov commented on a change in pull request #9696:
URL: https://github.com/apache/ignite/pull/9696#discussion_r785689295



##########
File path: modules/calcite/src/main/java/org/apache/ignite/calcite/CalciteQueryEngineConfiguration.java
##########
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.calcite;
+
+import org.apache.ignite.internal.processors.query.QueryEngine;
+import org.apache.ignite.internal.processors.query.QueryEngineConfigurationEx;
+import org.apache.ignite.internal.processors.query.calcite.CalciteQueryProcessor;
+import org.apache.ignite.lang.IgniteExperimental;
+
+/**
+ * Query engine configuration for Calcite-based query engine.
+ */
+@IgniteExperimental
+public class CalciteQueryEngineConfiguration implements QueryEngineConfigurationEx {
+    /** Query engine name. */
+    public static final String ENGINE_NAME = "calcite";
+
+    /** */
+    private volatile boolean isDflt;

Review comment:
       Fixed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] alex-plekhanov commented on a change in pull request #9696: IGNITE-14195 Query engines configuration

Posted by GitBox <gi...@apache.org>.
alex-plekhanov commented on a change in pull request #9696:
URL: https://github.com/apache/ignite/pull/9696#discussion_r785689078



##########
File path: modules/core/src/main/java/org/apache/ignite/configuration/SqlConfiguration.java
##########
@@ -176,6 +179,37 @@ public SqlConfiguration setValidationEnabled(boolean validationEnabled) {
         return this;
     }
 
+    /**
+     * Sets query engines configuration.
+     * <p>
+     * There are several engines to execute SQL queries can be configured. If configured more than one engine, exact
+     * engine to execute the query can be chosen in run-time by {@code queryEngine} JDBC connection property or by
+     * {@code QUERY_ENGINE('engineName')} SQL query hint. If no query engine is explicitly chosen, default query engine
+     * will be used (see {@link QueryEngineConfiguration#setDefault(boolean)}).
+     * </p>
+     * </p>

Review comment:
       Ok, I've removed the closing tag, we don't use it usually




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] alex-plekhanov closed pull request #9696: IGNITE-14195 Query engines configuration

Posted by GitBox <gi...@apache.org>.
alex-plekhanov closed pull request #9696:
URL: https://github.com/apache/ignite/pull/9696


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] AMashenkov commented on a change in pull request #9696: IGNITE-14195 Query engines configuration

Posted by GitBox <gi...@apache.org>.
AMashenkov commented on a change in pull request #9696:
URL: https://github.com/apache/ignite/pull/9696#discussion_r784691062



##########
File path: modules/core/src/main/java/org/apache/ignite/configuration/SqlConfiguration.java
##########
@@ -176,6 +179,37 @@ public SqlConfiguration setValidationEnabled(boolean validationEnabled) {
         return this;
     }
 
+    /**
+     * Sets query engines configuration.
+     * <p>
+     * There are several engines to execute SQL queries can be configured. If configured more than one engine, exact
+     * engine to execute the query can be chosen in run-time by {@code queryEngine} JDBC connection property or by
+     * {@code QUERY_ENGINE('engineName')} SQL query hint. If no query engine is explicitly chosen, default query engine
+     * will be used (see {@link QueryEngineConfiguration#setDefault(boolean)}).
+     * </p>
+     * </p>

Review comment:
       ```suggestion
        * </p>
        * <p>
   ```
   I'm not sure if closing tags are ever needed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org