[jira] [Commented] (DRILL-5956) Add Storage Plugin for Apache Druid

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127706#comment-17127706 ] 

ASF GitHub Bot commented on DRILL-5956:
---------------------------------------

tenghuanhe commented on a change in pull request #1888:
URL: https://github.com/apache/drill/pull/1888#discussion_r436379342



##########
File path: contrib/storage-druid/src/main/java/org/apache/drill/exec/store/druid/rest/DruidAdminClient.java
##########
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.store.druid.rest;
+
+import com.fasterxml.jackson.core.type.TypeReference;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import org.apache.drill.common.exceptions.UserException;
+import org.apache.http.HttpResponse;
+import org.apache.http.HttpStatus;
+import org.apache.http.util.EntityUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.HashSet;
+import java.util.Set;
+
+public class DruidAdminClient {
+  private static final Logger logger = LoggerFactory.getLogger(DruidAdminClient.class);
+
+  private static final String DATASOURCES_BASE_URI = "/druid/coordinator/v1/datasources";
+  private static final String DEFAULT_ENCODING = "UTF-8";
+
+  private final String coordinatorAddress;
+  private final RestClient restClient;
+
+  public DruidAdminClient(String coordinatorAddress, RestClient restClient) {
+    this.coordinatorAddress = coordinatorAddress;
+    this.restClient = restClient;
+  }
+
+  public Set<String> GetDataSources() throws IOException {

Review comment:
       camelCase convention `getDataSources()`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add Storage Plugin for Apache Druid
> -----------------------------------
>
>                 Key: DRILL-5956
>                 URL: https://issues.apache.org/jira/browse/DRILL-5956
>             Project: Apache Drill
>          Issue Type: Wish
>          Components: Storage - Other
>            Reporter: Jiaqi Liu
>            Priority: Major
>              Labels: Enhancement, Storage-Plugin
>             Fix For: 1.18.0
>
>
> As more and more companies are using Druid for mission-critical industrial products, Drill could gain much more popularity with Druid as one of its supported storage plugin so that uses could easily bind Druid cluster to running Drill instance



--
This message was sent by Atlassian Jira
(v8.3.4#803005)