[superset] branch sh68647 created (now 5e7612fd1f)

[be...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

beto pushed a change to branch sh68647
in repository https://gitbox.apache.org/repos/asf/superset.git


      at 5e7612fd1f fix: show_native_filters leftover

This branch includes the following new commits:

     new 5e7612fd1f fix: show_native_filters leftover

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.

[superset] 01/01: fix: show_native_filters leftover

[be...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

beto pushed a commit to branch sh68647
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 5e7612fd1f1a653125850fa6d840e5c6b5f617e8
Author: Beto Dealmeida <ro...@dealmeida.net>
AuthorDate: Wed Mar 15 17:49:47 2023 -0700

    fix: show_native_filters leftover
---
 superset/dashboards/commands/importers/v1/utils.py | 5 +++++
 superset/dashboards/schemas.py                     | 2 ++
 2 files changed, 7 insertions(+)

diff --git a/superset/dashboards/commands/importers/v1/utils.py b/superset/dashboards/commands/importers/v1/utils.py
index 090c64e21c..4d5e2ece81 100644
--- a/superset/dashboards/commands/importers/v1/utils.py
+++ b/superset/dashboards/commands/importers/v1/utils.py
@@ -162,6 +162,11 @@ def import_dashboard(
 
     # TODO (betodealmeida): move this logic to import_from_dict
     config = config.copy()
+
+    # removed in https://github.com/apache/superset/pull/23228
+    if "metadata" in config and "show_native_filters" in config["metadata"]:
+        del config["metadata"]["show_native_filters"]
+
     for key, new_name in JSON_KEYS.items():
         if config.get(key) is not None:
             value = config.pop(key)
diff --git a/superset/dashboards/schemas.py b/superset/dashboards/schemas.py
index c74c7ba52a..5b2987daef 100644
--- a/superset/dashboards/schemas.py
+++ b/superset/dashboards/schemas.py
@@ -130,6 +130,8 @@ class DashboardJSONMetadataSchema(Schema):
     shared_label_colors = fields.Dict()
     color_scheme_domain = fields.List(fields.Str())
     cross_filters_enabled = fields.Boolean(default=True)
+    # removed, but might still exist in exported dashboards
+    show_native_filters = fields.Boolean(required=False)
     # used for v0 import/export
     import_time = fields.Integer()
     remote_id = fields.Integer()