You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Wickersheimer Jeremy (JIRA)" <ji...@apache.org> on 2007/08/13 10:11:43 UTC
[jira] Created: (OFBIZ-1201) rev 560970 broke javascript
rev 560970 broke javascript
---------------------------
Key: OFBIZ-1201
URL: https://issues.apache.org/jira/browse/OFBIZ-1201
Project: OFBiz
Issue Type: Bug
Components: ecommerce
Affects Versions: SVN trunk
Reporter: Wickersheimer Jeremy
Priority: Minor
Another small issue i found out:
setPaymentInformation (ecommerce/webapp/ecommerce/order/paymentinformation.ftl) uses javascript for "Billing address is the same as the shipping address"
rev 560970 escaped the & => &s; , but in the Javascript there is no need to escape HTML characters ... the url used in the window.location.replace still contain the escaped &s;
I will attach the patch for this file, maybe rayb should check if that broke other java scripts.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1201) rev 560970 broke javascript
Posted by "Ray Barlow (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ray Barlow closed OFBIZ-1201.
-----------------------------
Resolution: Fixed
Fix Version/s: SVN trunk
Thanks for the patch it's committed. I checked the previous commit and this is the only area that changed ampersands in urls.
SVN r565839
> rev 560970 broke javascript
> ---------------------------
>
> Key: OFBIZ-1201
> URL: https://issues.apache.org/jira/browse/OFBIZ-1201
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Wickersheimer Jeremy
> Assignee: Ray Barlow
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ofbiz-1201.patch
>
>
> Another small issue i found out:
> setPaymentInformation (ecommerce/webapp/ecommerce/order/paymentinformation.ftl) uses javascript for "Billing address is the same as the shipping address"
> rev 560970 escaped the & => &s; , but in the Javascript there is no need to escape HTML characters ... the url used in the window.location.replace still contain the escaped &s;
> I will attach the patch for this file, maybe rayb should check if that broke other java scripts.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-1201) rev 560970 broke javascript
Posted by "Ray Barlow (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ray Barlow reassigned OFBIZ-1201:
---------------------------------
Assignee: Ray Barlow
> rev 560970 broke javascript
> ---------------------------
>
> Key: OFBIZ-1201
> URL: https://issues.apache.org/jira/browse/OFBIZ-1201
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Wickersheimer Jeremy
> Assignee: Ray Barlow
> Priority: Minor
> Attachments: ofbiz-1201.patch
>
>
> Another small issue i found out:
> setPaymentInformation (ecommerce/webapp/ecommerce/order/paymentinformation.ftl) uses javascript for "Billing address is the same as the shipping address"
> rev 560970 escaped the & => &s; , but in the Javascript there is no need to escape HTML characters ... the url used in the window.location.replace still contain the escaped &s;
> I will attach the patch for this file, maybe rayb should check if that broke other java scripts.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1201) rev 560970 broke javascript
Posted by "Wickersheimer Jeremy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Wickersheimer Jeremy updated OFBIZ-1201:
----------------------------------------
Attachment: ofbiz-1201.patch
Here is the patch to revert the ampersands. I also changed the if blocks for the payment method to if / elseif / .. / else error as it is easier to read this way.
> rev 560970 broke javascript
> ---------------------------
>
> Key: OFBIZ-1201
> URL: https://issues.apache.org/jira/browse/OFBIZ-1201
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Wickersheimer Jeremy
> Priority: Minor
> Attachments: ofbiz-1201.patch
>
>
> Another small issue i found out:
> setPaymentInformation (ecommerce/webapp/ecommerce/order/paymentinformation.ftl) uses javascript for "Billing address is the same as the shipping address"
> rev 560970 escaped the & => &s; , but in the Javascript there is no need to escape HTML characters ... the url used in the window.location.replace still contain the escaped &s;
> I will attach the patch for this file, maybe rayb should check if that broke other java scripts.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.