You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "ad1happy2go (via GitHub)" <gi...@apache.org> on 2023/10/20 14:08:18 UTC

[PR] [Docs] Flink Quickstart Restructuring [hudi]

ad1happy2go opened a new pull request, #9897:
URL: https://github.com/apache/hudi/pull/9897

   ### Change Logs
   
   _Describe context and summary for this change. Highlight if any code was copied._
   
   ### Impact
   
   _Describe any public API or user-facing feature change or any performance impact._
   
   ### Risk level (write none, low medium or high below)
   
   _If medium or high, explain what verification was done to mitigate the risks._
   
   ### Documentation Update
   
   _Describe any necessary documentation update if there is any new feature, config, or user-facing change_
   
   - _The config description must be updated if new configs are added or the default value of the configs are changed_
   - _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
     ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
     changes to the website._
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Docs] Flink Quickstart Restructuring [hudi]

Posted by "bhasudha (via GitHub)" <gi...@apache.org>.
bhasudha commented on code in PR #9897:
URL: https://github.com/apache/hudi/pull/9897#discussion_r1369992413


##########
website/docs/flink-quick-start-guide.md:
##########
@@ -63,21 +38,34 @@ export HADOOP_CLASSPATH=`$HADOOP_HOME/bin/hadoop classpath`
 # Start the Flink standalone cluster
 ./bin/start-cluster.sh
 ```
-#### Step.3 start Flink SQL client
+### Start Flink SQL client
 
 Hudi supports packaged bundle jar for Flink, which should be loaded in the Flink SQL Client when it starts up.
 You can build the jar manually under path `hudi-source-dir/packaging/hudi-flink-bundle`(see [Build Flink Bundle Jar](/docs/syncing_metastore#install)), or download it from the
 [Apache Official Repository](https://repo.maven.apache.org/maven2/org/apache/hudi/).
 
-Now starts the SQL CLI:
+Now start the SQL CLI:
 
 ```bash
-# HADOOP_HOME is your hadoop root directory after unpack the binary package.
-export HADOOP_CLASSPATH=`$HADOOP_HOME/bin/hadoop classpath`
-
-./bin/sql-client.sh embedded -j .../hudi-flink1.1*-bundle-*.*.*.jar shell
+# For Flink versions: 1.13 - 1.17
+export FLINK_VERSION=1.17 
+export HUDI_VERSION=0.14.0
+wget https://repo1.maven.org/maven2/org/apache/hudi/hudi-flink${FLINK_VERSION}-bundle/${HUDI_VERSION}/hudi-flink${FLINK_VERSION}-bundle-${HUDI_VERSION}.jar -P $FLINK_HOME/lib/
+./bin/sql-client.sh embedded -j lib/hudi-flink${FLINK_VERSION}-bundle-${HUDI_VERSION}.jar shell
 ```
 
+
+### Flink Support Matrix

Review Comment:
   @ad1happy2go  We can move this part to the top of the Setup (as the first subsection under Setup) and see if we can make it common instead of under Flink SQL tab. ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Docs] Flink Quickstart Restructuring [hudi]

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #9897:
URL: https://github.com/apache/hudi/pull/9897


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Docs] Flink Quickstart Restructuring [hudi]

Posted by "bhasudha (via GitHub)" <gi...@apache.org>.
bhasudha commented on PR #9897:
URL: https://github.com/apache/hudi/pull/9897#issuecomment-1777052773

   @ad1happy2go  I left a few comments. Since this PR is already merged, can we address them in another PR. Feel free to @ me in that Pr for review. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org