You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "theirix (via GitHub)" <gi...@apache.org> on 2026/05/27 20:56:24 UTC

[PR] fix: wrong precision in a decimal256 log test [datafusion]

theirix opened a new pull request, #22578:
URL: https://github.com/apache/datafusion/pull/22578

   ## Which issue does this PR close?
   
   ## Rationale for this change
   
   Spotted wrong usage of decimal precision in `test_log_decimal256_large` - passed Decimal128 max precision instead of Decimal256. The test worked fine.
   
   ## What changes are included in this PR?
   
   - Test fixup
   - Unhardcode the usage decimal precision in non-test code
   
   ## Are these changes tested?
   
   - Tests passed
   
   ## Are there any user-facing changes?
   
   no


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] fix: wrong precision in a decimal256 log test [datafusion]

Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on PR #22578:
URL: https://github.com/apache/datafusion/pull/22578#issuecomment-4593117128

   Thanks @theirix 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] fix: wrong precision in a decimal256 log test [datafusion]

Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey merged PR #22578:
URL: https://github.com/apache/datafusion/pull/22578


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org