You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@jclouds.apache.org by Josef Cacek <no...@github.com> on 2016/08/22 11:48:22 UTC

[jclouds/jclouds-labs] Docker live test fix - SshToCustomPortLiveTest (#313)

The SshToCustomPortLiveTest didn't work for remote docker endpoints due to wrong port number used. 

This fix allows to decide which `loginPort` to use based on system property configured from the tests.
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds-labs/pull/313

-- Commit Summary --

  * Docker live test fix - SshToCustomPortLiveTest didn't work for remote docker endpoints due to wrong port number used

-- File Changes --

    M docker/src/test/java/org/jclouds/docker/compute/SshToCustomPortLiveTest.java (6)

-- Patch Links --

https://github.com/jclouds/jclouds-labs/pull/313.patch
https://github.com/jclouds/jclouds-labs/pull/313.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/313

Re: [jclouds/jclouds-labs] Docker live test fix - SshToCustomPortLiveTest (#313)

Posted by Josef Cacek <no...@github.com>.

@nacx Thx for review.

I've changed the predicate to work with container name instead of the system property.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/313#issuecomment-243147553

Re: [jclouds/jclouds-labs] Docker live test fix - SshToCustomPortLiveTest (#313)

Posted by Ignasi Barrera <no...@github.com>.

Thanks for the quick fixes! Pushed to master as [66c7617d](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/66c7617d).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/313#issuecomment-243248802

Re: [jclouds/jclouds-labs] Docker live test fix - SshToCustomPortLiveTest (#313)

Posted by Ignasi Barrera <no...@github.com>.

Closed #313.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/313#event-771255874

Re: [jclouds/jclouds-labs] Docker live test fix - SshToCustomPortLiveTest (#313)

Posted by Ignasi Barrera <no...@github.com>.

Using a system property gives the impression that there is something that can actually be configured to influence the default behaviour of jclouds. WDYT about changing the approach and let the predicate just pick one port or another based on the container name? We could easily hardcode meaningful names for the containers so the predicate and the tests make sense.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/313#issuecomment-242942000