[jira] Commented: (TUSCANY-3022) uniqueness constraint for name of service within component type not enforced

["Mike Edwards (JIRA)" <de...@tuscany.apache.org>]

    [ https://issues.apache.org/jira/browse/TUSCANY-3022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709049#action_12709049 ] 

Mike Edwards commented on TUSCANY-3022:
---------------------------------------

I'd like to expand the scope of this issue to cover failures in relation to OASIS conformance testcases:

ASM_4003_TestCase
ASM_4004_TestCase

...which similarly check for duplicates in <reference/> elements and in <property/> elements of componentType

and which Tuscany fails in a very similar way to that for ASM_4002_TestCase - and for the same reason.

Basically, Tuscany detects the condition, but assigns only "warning" status to the problem, whereas the OASIS spec says that any document containing these problems must be *REJECTED* - i.e. it must not run.

A simple change to "error" status for these conditions achieves the required result of throwing an exception before the composite/implementation is run...

> uniqueness constraint for name of service within component type not enforced
> ----------------------------------------------------------------------------
>
>                 Key: TUSCANY-3022
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-3022
>             Project: Tuscany
>          Issue Type: Bug
>          Components: Java SCA spec compliance
>    Affects Versions: Java-SCA-2.0
>            Reporter: Kelvin Goodson
>
> OASIS SCA spec 1.1 conformance statement ASM40003 is shown to be violated in ASM_4002_TestCase.
> File src/main/resources/General/Test_ASM_4002.composite violates the constraint that the @name attribute value of a <service/> element of a <componentType/> 
>  is not the same as the @name attribute value of any other <service/> of the <componentType/>
> but we report ...
> org.junit.ComparisonFailure: expected:<[exception]> but was:<[ASM_4002 request service1 operation1 invoked]>
> 	at org.junit.Assert.assertEquals(Assert.java:123)
> 	at org.junit.Assert.assertEquals(Assert.java:145)
> 	at client.BaseJAXWSTestCase.testDummy(BaseJAXWSTestCase.java:148)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.