You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@flex.apache.org by "Cyrill Zadra (JIRA)" <ji...@apache.org> on 2012/11/02 00:00:12 UTC

[jira] [Created] (FLEX-33238) Falcon Compile Error when using id attribute with ConstraintRow or ConstraintColumn

Cyrill Zadra created FLEX-33238:
-----------------------------------

             Summary: Falcon Compile Error when using id attribute with ConstraintRow or  ConstraintColumn
                 Key: FLEX-33238
                 URL: https://issues.apache.org/jira/browse/FLEX-33238
             Project: Apache Flex
          Issue Type: Bug
          Components: MXML Compiler
    Affects Versions: Apache Flex Next
            Reporter: Cyrill Zadra
             Fix For: Apache Flex 4.9.0
         Attachments: ConstraintRowIdTest.mxml

Using the id attribute in <mx:ConstraintRow /> or <mx:ConstraintColumn> throws the error:

C:\dev\ie8-git\flexclient\FalconTest\src\FalconTest.mxml:11
Error: This id is not unique. It will be ignored.
                        <mx:ConstraintColumn id="col2" />
                                             ^

C:\dev\ie8-git\flexclient\FalconTest\src\FalconTest.mxml:14
Error: This id is not unique. It will be ignored.
                        <mx:ConstraintRow id="row2"  />



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

RE: [jira] [Commented] (FLEX-33238) Falcon Compile Error when using id attribute with ConstraintRow, ConstraintColumn, AddChild, GradientGlowFilter or GlowFilter

Posted by Michael Schmalle <ap...@teotigraphix.com>.

Quoting Gordon Smith <go...@adobe.com>:


> OK. I don't want to scare you off though!




No, actually I have gone through quite a bit of soul searching with  
the whole project and my future. As of now I make no money from Flex  
but, the hopes we can turn this compiler into a multi-target renderer  
is why I am still here.

I'm working on Android stuff and music for my other quest. Basically,  
I will have to get struck by lightning(knock on wood) to not put my  
heart and soul into this compiler project for cross compilation.

I would really love to be able to compile some of the Flex framework  
to Android someday. :) IE MXML -> native Android UI (View, ViewGroup)  
just to say we did it. Developing a UI in Java/XML Android is crazy  
painful compared to MXML. ;-)

Mike






> -----Original Message-----
> From: Michael Schmalle [mailto:apache@teotigraphix.com]
> Sent: Wednesday, November 14, 2012 1:07 PM
> To: flex-dev@incubator.apache.org
> Subject: RE: [jira] [Commented] (FLEX-33238) Falcon Compile Error  
> when using id attribute with ConstraintRow, ConstraintColumn,  
> AddChild, GradientGlowFilter or GlowFilter
>
> Trust me, I have no intention of fixing things I have no idea why  
> they are like they are.
>
> With the NPE and properties bug, I stepped through the code until I  
> figured out it had to do with recursion and transcode() not being  
> called on a sub instance. I didn't "just" apply the patch move to  
> the constructor, just because it worked.
>
> This means I won't commit something until I am sure I know what it  
> is or have a test to prove it, otherwise I will talk to you.
>
> Mike
>
> Quoting Gordon Smith <go...@adobe.com>:
>
>> I don't recommend attempting a fix until we have a good set of parser
>> unit tests for properties of various types. Otherwise, you might
>> introduce a regression in another area related to properties and their
>> values.
>>
>> - Gordon
>>
>> -----Original Message-----
>> From: Gordon Smith
>> Sent: Wednesday, November 14, 2012 11:44 AM
>> To: flex-dev@incubator.apache.org
>> Subject: RE: [jira] [Commented] (FLEX-33238) Falcon Compile Error when
>> using id attribute with ConstraintRow, ConstraintColumn, AddChild,
>> GradientGlowFilter or GlowFilter
>>
>> I looked into the "This id is not unique" error on <ConstraintRow> and
>> <ConstraintColumn> last Friday but didn't come up with a fix.
>> The bug is in how "implicit arrays" are handled. Background:
>>
>> <Instance>
>>     <arrayProperty>
>>         <Instance/>
>>         <Instance/>
>>     </arrayProeprty>
>> </Instance>
>>
>> it's really shorthand for
>>
>> <Instance>
>>     <arrayProperty>
>>         <Array>
>>             <Instance/>
>>             <Instance/>
>>         <Array>
>>     </arrayProperty>
>> </Instance>
>>
>> and this even applies when arrayProperty is the default property, so
>> that
>>
>> <Instance>
>>         <Instance/>
>>         <Instance/>
>> </Instance>
>>
>> is shorthand for
>>
>> <Instance>
>>     <arrayProperty>
>>         <Array>
>>             <Instance/>
>>             <Instance/>
>>         <Array>
>>     </arrayProperty>
>> </Instance>
>>
>> When I create more parser unit test to deal with the various
>> permutations of MXMLPropertyNode for various property types, including
>> properties of type array, I will work on fixing this.
>>
>> Basically, the problem is that the <Instance/> tags representing the
>> array elements are getting processed twice and the second time the id
>> is already in the map.
>>
>> - Gordon
>>
>> -----Original Message-----
>> From: Michael Schmalle (JIRA) [mailto:jira@apache.org]
>> Sent: Wednesday, November 14, 2012 11:18 AM
>> To: flex-dev@incubator.apache.org
>> Subject: [jira] [Commented] (FLEX-33238) Falcon Compile Error when
>> using id attribute with ConstraintRow, ConstraintColumn, AddChild,
>> GradientGlowFilter or GlowFilter
>>
>>
>>     [
>> https://issues.apache.org/jira/browse/FLEX-33238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497361#comment-13497361
>> ]
>>
>> Michael Schmalle commented on FLEX-33238:
>> -----------------------------------------
>>
>> Ok I figured out what is causing this, the AddChild node gets has
>> two MXMLInstanceNode with different memory locations. So the next
>> step is to figure out why there are two instance nodes.
>>
>> BTW the check addNodeWithID() comes back with the previously created
>> MXMLInstanceNode.
>>
>>
>>> Falcon Compile Error when using id attribute with ConstraintRow,
>>> ConstraintColumn, AddChild, GradientGlowFilter or GlowFilter
>>> ----------------------------------------------------------------------
>>> -------------------------------------------------------
>>>
>>>                 Key: FLEX-33238
>>>                 URL: https://issues.apache.org/jira/browse/FLEX-33238
>>>             Project: Apache Flex
>>>          Issue Type: Bug
>>>          Components: MXML Compiler
>>>    Affects Versions: Apache Flex Next
>>>            Reporter: Cyrill Zadra
>>>              Labels: Falcon
>>>             Fix For: Apache Flex 4.9.0
>>>
>>>         Attachments: AddChildRowIdTest.mxml, ConstraintRowIdTest.mxml
>>>
>>>
>>> Using the id attribute in <mx:ConstraintRow /> or
>>> <mx:ConstraintColumn> throws the error:
>>> C:\dev\ie8-git\flexclient\FalconTest\src\FalconTest.mxml:11
>>> Error: This id is not unique. It will be ignored.
>>>                         <mx:ConstraintColumn id="col2" />
>>>                                              ^
>>> C:\dev\ie8-git\flexclient\FalconTest\src\FalconTest.mxml:14
>>> Error: This id is not unique. It will be ignored.
>>>                         <mx:ConstraintRow id="row2"  /> Using the id
>>> attribute in <mx:AddChild /> throws the error:
>>> Error: This id is not unique. It will be ignored.
>>> 			    <mx:AddChild id="addChild0">
>>> Using the id attribute in <s:GradientGlowFilter/> throws the error:
>>>      [java] Error: This id is not unique. It will be ignored.
>>>      [java]             <s:GradientGlowFilter id="glow1" >
>>> Using the id attribute in <s:GlowFilter/> throws the error:
>>>      [java] Error: This id is not unique. It will be ignored.
>>>      [java]             <s:GradientGlowFilter id="glow1" >
>>
>> --
>> This message is automatically generated by JIRA.
>> If you think it was sent incorrectly, please contact your JIRA
>> administrators For more information on JIRA, see:
>> http://www.atlassian.com/software/jira
>>
>
> --
> Michael Schmalle - Teoti Graphix, LLC
> http://www.teotigraphix.com
> http://blog.teotigraphix.com
>
>

-- 
Michael Schmalle - Teoti Graphix, LLC
http://www.teotigraphix.com
http://blog.teotigraphix.com

RE: [jira] [Commented] (FLEX-33238) Falcon Compile Error when using id attribute with ConstraintRow, ConstraintColumn, AddChild, GradientGlowFilter or GlowFilter

Posted by Gordon Smith <go...@adobe.com>.

OK. I don't want to scare you off though!

-----Original Message-----
From: Michael Schmalle [mailto:apache@teotigraphix.com] 
Sent: Wednesday, November 14, 2012 1:07 PM
To: flex-dev@incubator.apache.org
Subject: RE: [jira] [Commented] (FLEX-33238) Falcon Compile Error when using id attribute with ConstraintRow, ConstraintColumn, AddChild, GradientGlowFilter or GlowFilter

Trust me, I have no intention of fixing things I have no idea why they are like they are.

With the NPE and properties bug, I stepped through the code until I figured out it had to do with recursion and transcode() not being called on a sub instance. I didn't "just" apply the patch move to the constructor, just because it worked.

This means I won't commit something until I am sure I know what it is or have a test to prove it, otherwise I will talk to you.

Mike

Quoting Gordon Smith <go...@adobe.com>:

> I don't recommend attempting a fix until we have a good set of parser 
> unit tests for properties of various types. Otherwise, you might 
> introduce a regression in another area related to properties and their 
> values.
>
> - Gordon
>
> -----Original Message-----
> From: Gordon Smith
> Sent: Wednesday, November 14, 2012 11:44 AM
> To: flex-dev@incubator.apache.org
> Subject: RE: [jira] [Commented] (FLEX-33238) Falcon Compile Error when 
> using id attribute with ConstraintRow, ConstraintColumn, AddChild, 
> GradientGlowFilter or GlowFilter
>
> I looked into the "This id is not unique" error on <ConstraintRow> and 
> <ConstraintColumn> last Friday but didn't come up with a fix.
> The bug is in how "implicit arrays" are handled. Background:
>
> <Instance>
>     <arrayProperty>
>         <Instance/>
>         <Instance/>
>     </arrayProeprty>
> </Instance>
>
> it's really shorthand for
>
> <Instance>
>     <arrayProperty>
>         <Array>
>             <Instance/>
>             <Instance/>
>         <Array>
>     </arrayProperty>
> </Instance>
>
> and this even applies when arrayProperty is the default property, so 
> that
>
> <Instance>
>         <Instance/>
>         <Instance/>
> </Instance>
>
> is shorthand for
>
> <Instance>
>     <arrayProperty>
>         <Array>
>             <Instance/>
>             <Instance/>
>         <Array>
>     </arrayProperty>
> </Instance>
>
> When I create more parser unit test to deal with the various 
> permutations of MXMLPropertyNode for various property types, including 
> properties of type array, I will work on fixing this.
>
> Basically, the problem is that the <Instance/> tags representing the 
> array elements are getting processed twice and the second time the id 
> is already in the map.
>
> - Gordon
>
> -----Original Message-----
> From: Michael Schmalle (JIRA) [mailto:jira@apache.org]
> Sent: Wednesday, November 14, 2012 11:18 AM
> To: flex-dev@incubator.apache.org
> Subject: [jira] [Commented] (FLEX-33238) Falcon Compile Error when 
> using id attribute with ConstraintRow, ConstraintColumn, AddChild, 
> GradientGlowFilter or GlowFilter
>
>
>     [  
> https://issues.apache.org/jira/browse/FLEX-33238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497361#comment-13497361  
> ]
>
> Michael Schmalle commented on FLEX-33238:
> -----------------------------------------
>
> Ok I figured out what is causing this, the AddChild node gets has  
> two MXMLInstanceNode with different memory locations. So the next  
> step is to figure out why there are two instance nodes.
>
> BTW the check addNodeWithID() comes back with the previously created  
> MXMLInstanceNode.
>
>
>> Falcon Compile Error when using id attribute with ConstraintRow,
>> ConstraintColumn, AddChild, GradientGlowFilter or GlowFilter
>> ----------------------------------------------------------------------
>> -------------------------------------------------------
>>
>>                 Key: FLEX-33238
>>                 URL: https://issues.apache.org/jira/browse/FLEX-33238
>>             Project: Apache Flex
>>          Issue Type: Bug
>>          Components: MXML Compiler
>>    Affects Versions: Apache Flex Next
>>            Reporter: Cyrill Zadra
>>              Labels: Falcon
>>             Fix For: Apache Flex 4.9.0
>>
>>         Attachments: AddChildRowIdTest.mxml, ConstraintRowIdTest.mxml
>>
>>
>> Using the id attribute in <mx:ConstraintRow /> or  
>> <mx:ConstraintColumn> throws the error:
>> C:\dev\ie8-git\flexclient\FalconTest\src\FalconTest.mxml:11
>> Error: This id is not unique. It will be ignored.
>>                         <mx:ConstraintColumn id="col2" />
>>                                              ^
>> C:\dev\ie8-git\flexclient\FalconTest\src\FalconTest.mxml:14
>> Error: This id is not unique. It will be ignored.
>>                         <mx:ConstraintRow id="row2"  /> Using the id
>> attribute in <mx:AddChild /> throws the error:
>> Error: This id is not unique. It will be ignored.
>> 			    <mx:AddChild id="addChild0">
>> Using the id attribute in <s:GradientGlowFilter/> throws the error:
>>      [java] Error: This id is not unique. It will be ignored.
>>      [java]             <s:GradientGlowFilter id="glow1" >
>> Using the id attribute in <s:GlowFilter/> throws the error:
>>      [java] Error: This id is not unique. It will be ignored.
>>      [java]             <s:GradientGlowFilter id="glow1" >
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA  
> administrators For more information on JIRA, see:  
> http://www.atlassian.com/software/jira
>

-- 
Michael Schmalle - Teoti Graphix, LLC
http://www.teotigraphix.com
http://blog.teotigraphix.com

RE: [jira] [Commented] (FLEX-33238) Falcon Compile Error when using id attribute with ConstraintRow, ConstraintColumn, AddChild, GradientGlowFilter or GlowFilter

Posted by Michael Schmalle <ap...@teotigraphix.com>.

Trust me, I have no intention of fixing things I have no idea why they  
are like they are.

With the NPE and properties bug, I stepped through the code until I  
figured out it had to do with recursion and transcode() not being  
called on a sub instance. I didn't "just" apply the patch move to the  
constructor, just because it worked.

This means I won't commit something until I am sure I know what it is  
or have a test to prove it, otherwise I will talk to you.

Mike

Quoting Gordon Smith <go...@adobe.com>:

> I don't recommend attempting a fix until we have a good set of  
> parser unit tests for properties of various types. Otherwise, you  
> might introduce a regression in another area related to properties  
> and their values.
>
> - Gordon
>
> -----Original Message-----
> From: Gordon Smith
> Sent: Wednesday, November 14, 2012 11:44 AM
> To: flex-dev@incubator.apache.org
> Subject: RE: [jira] [Commented] (FLEX-33238) Falcon Compile Error  
> when using id attribute with ConstraintRow, ConstraintColumn,  
> AddChild, GradientGlowFilter or GlowFilter
>
> I looked into the "This id is not unique" error on <ConstraintRow>  
> and <ConstraintColumn> last Friday but didn't come up with a fix.  
> The bug is in how "implicit arrays" are handled. Background:
>
> <Instance>
>     <arrayProperty>
>         <Instance/>
>         <Instance/>
>     </arrayProeprty>
> </Instance>
>
> it's really shorthand for
>
> <Instance>
>     <arrayProperty>
>         <Array>
>             <Instance/>
>             <Instance/>
>         <Array>
>     </arrayProperty>
> </Instance>
>
> and this even applies when arrayProperty is the default property, so that
>
> <Instance>
>         <Instance/>
>         <Instance/>
> </Instance>
>
> is shorthand for
>
> <Instance>
>     <arrayProperty>
>         <Array>
>             <Instance/>
>             <Instance/>
>         <Array>
>     </arrayProperty>
> </Instance>
>
> When I create more parser unit test to deal with the various  
> permutations of MXMLPropertyNode for various property types,  
> including properties of type array, I will work on fixing this.
>
> Basically, the problem is that the <Instance/> tags representing the  
> array elements are getting processed twice and the second time the  
> id is already in the map.
>
> - Gordon
>
> -----Original Message-----
> From: Michael Schmalle (JIRA) [mailto:jira@apache.org]
> Sent: Wednesday, November 14, 2012 11:18 AM
> To: flex-dev@incubator.apache.org
> Subject: [jira] [Commented] (FLEX-33238) Falcon Compile Error when  
> using id attribute with ConstraintRow, ConstraintColumn, AddChild,  
> GradientGlowFilter or GlowFilter
>
>
>     [  
> https://issues.apache.org/jira/browse/FLEX-33238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497361#comment-13497361  
> ]
>
> Michael Schmalle commented on FLEX-33238:
> -----------------------------------------
>
> Ok I figured out what is causing this, the AddChild node gets has  
> two MXMLInstanceNode with different memory locations. So the next  
> step is to figure out why there are two instance nodes.
>
> BTW the check addNodeWithID() comes back with the previously created  
> MXMLInstanceNode.
>
>
>> Falcon Compile Error when using id attribute with ConstraintRow,
>> ConstraintColumn, AddChild, GradientGlowFilter or GlowFilter
>> ----------------------------------------------------------------------
>> -------------------------------------------------------
>>
>>                 Key: FLEX-33238
>>                 URL: https://issues.apache.org/jira/browse/FLEX-33238
>>             Project: Apache Flex
>>          Issue Type: Bug
>>          Components: MXML Compiler
>>    Affects Versions: Apache Flex Next
>>            Reporter: Cyrill Zadra
>>              Labels: Falcon
>>             Fix For: Apache Flex 4.9.0
>>
>>         Attachments: AddChildRowIdTest.mxml, ConstraintRowIdTest.mxml
>>
>>
>> Using the id attribute in <mx:ConstraintRow /> or  
>> <mx:ConstraintColumn> throws the error:
>> C:\dev\ie8-git\flexclient\FalconTest\src\FalconTest.mxml:11
>> Error: This id is not unique. It will be ignored.
>>                         <mx:ConstraintColumn id="col2" />
>>                                              ^
>> C:\dev\ie8-git\flexclient\FalconTest\src\FalconTest.mxml:14
>> Error: This id is not unique. It will be ignored.
>>                         <mx:ConstraintRow id="row2"  /> Using the id
>> attribute in <mx:AddChild /> throws the error:
>> Error: This id is not unique. It will be ignored.
>> 			    <mx:AddChild id="addChild0">
>> Using the id attribute in <s:GradientGlowFilter/> throws the error:
>>      [java] Error: This id is not unique. It will be ignored.
>>      [java]             <s:GradientGlowFilter id="glow1" >
>> Using the id attribute in <s:GlowFilter/> throws the error:
>>      [java] Error: This id is not unique. It will be ignored.
>>      [java]             <s:GradientGlowFilter id="glow1" >
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA  
> administrators For more information on JIRA, see:  
> http://www.atlassian.com/software/jira
>

-- 
Michael Schmalle - Teoti Graphix, LLC
http://www.teotigraphix.com
http://blog.teotigraphix.com

RE: [jira] [Commented] (FLEX-33238) Falcon Compile Error when using id attribute with ConstraintRow, ConstraintColumn, AddChild, GradientGlowFilter or GlowFilter

Posted by Gordon Smith <go...@adobe.com>.

I don't recommend attempting a fix until we have a good set of parser unit tests for properties of various types. Otherwise, you might introduce a regression in another area related to properties and their values.

- Gordon

-----Original Message-----
From: Gordon Smith 
Sent: Wednesday, November 14, 2012 11:44 AM
To: flex-dev@incubator.apache.org
Subject: RE: [jira] [Commented] (FLEX-33238) Falcon Compile Error when using id attribute with ConstraintRow, ConstraintColumn, AddChild, GradientGlowFilter or GlowFilter

I looked into the "This id is not unique" error on <ConstraintRow> and <ConstraintColumn> last Friday but didn't come up with a fix. The bug is in how "implicit arrays" are handled. Background:

<Instance>
    <arrayProperty>
        <Instance/>
        <Instance/>
    </arrayProeprty>
</Instance>

it's really shorthand for

<Instance>
    <arrayProperty>
        <Array>
            <Instance/>
            <Instance/>
        <Array>
    </arrayProperty>
</Instance>

and this even applies when arrayProperty is the default property, so that

<Instance>
        <Instance/>
        <Instance/>
</Instance>

is shorthand for

<Instance>
    <arrayProperty>
        <Array>
            <Instance/>
            <Instance/>
        <Array>
    </arrayProperty>
</Instance>

When I create more parser unit test to deal with the various permutations of MXMLPropertyNode for various property types, including properties of type array, I will work on fixing this.

Basically, the problem is that the <Instance/> tags representing the array elements are getting processed twice and the second time the id is already in the map.

- Gordon

-----Original Message-----
From: Michael Schmalle (JIRA) [mailto:jira@apache.org] 
Sent: Wednesday, November 14, 2012 11:18 AM
To: flex-dev@incubator.apache.org
Subject: [jira] [Commented] (FLEX-33238) Falcon Compile Error when using id attribute with ConstraintRow, ConstraintColumn, AddChild, GradientGlowFilter or GlowFilter


    [ https://issues.apache.org/jira/browse/FLEX-33238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497361#comment-13497361 ] 

Michael Schmalle commented on FLEX-33238:
-----------------------------------------

Ok I figured out what is causing this, the AddChild node gets has two MXMLInstanceNode with different memory locations. So the next step is to figure out why there are two instance nodes.

BTW the check addNodeWithID() comes back with the previously created MXMLInstanceNode.

                
> Falcon Compile Error when using id attribute with ConstraintRow, 
> ConstraintColumn, AddChild, GradientGlowFilter or GlowFilter
> ----------------------------------------------------------------------
> -------------------------------------------------------
>
>                 Key: FLEX-33238
>                 URL: https://issues.apache.org/jira/browse/FLEX-33238
>             Project: Apache Flex
>          Issue Type: Bug
>          Components: MXML Compiler
>    Affects Versions: Apache Flex Next
>            Reporter: Cyrill Zadra
>              Labels: Falcon
>             Fix For: Apache Flex 4.9.0
>
>         Attachments: AddChildRowIdTest.mxml, ConstraintRowIdTest.mxml
>
>
> Using the id attribute in <mx:ConstraintRow /> or <mx:ConstraintColumn> throws the error:
> C:\dev\ie8-git\flexclient\FalconTest\src\FalconTest.mxml:11
> Error: This id is not unique. It will be ignored.
>                         <mx:ConstraintColumn id="col2" />
>                                              ^
> C:\dev\ie8-git\flexclient\FalconTest\src\FalconTest.mxml:14
> Error: This id is not unique. It will be ignored.
>                         <mx:ConstraintRow id="row2"  /> Using the id 
> attribute in <mx:AddChild /> throws the error:
> Error: This id is not unique. It will be ignored.
> 			    <mx:AddChild id="addChild0">
> Using the id attribute in <s:GradientGlowFilter/> throws the error:
>      [java] Error: This id is not unique. It will be ignored.
>      [java]             <s:GradientGlowFilter id="glow1" >
> Using the id attribute in <s:GlowFilter/> throws the error:
>      [java] Error: This id is not unique. It will be ignored.
>      [java]             <s:GradientGlowFilter id="glow1" >

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira