You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/09 07:41:29 UTC

[GitHub] [spark] gaoyajun02 opened a new pull request #34231: [SPARK-36964][CORE][YARN] Reuse CachedDNSToSwitchMapping for yarn container requests

gaoyajun02 opened a new pull request #34231:
URL: https://github.com/apache/spark/pull/34231


   ### What changes were proposed in this pull request?
   
   If submits a stage with abundant tasks, rack resolving takes a long time when YarnAllocator add or remove requests with locality preference caused by a mass of loops to execute rack resolving script.
   
   since SPARK-13704, spark re-implemented RackResolver and created a separate dnsToSwitchMapping. Here we can change to RackResolver's internal dnsToSwitchMapping to allow YarnAllocator to reuse CachedDNSToSwitchMapping as much as possible.
   
   
   ### How was this patch tested?
   Tested with unit tests + some internal tests on real cluster.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] gaoyajun02 commented on pull request #34231: [SPARK-36964][CORE][YARN] Share cached dnsToSwitchMapping for yarn locality container requests

Posted by GitBox <gi...@apache.org>.
gaoyajun02 commented on pull request #34231:
URL: https://github.com/apache/spark/pull/34231#issuecomment-942395851


   ping @cloud-fan
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] github-actions[bot] commented on pull request #34231: [SPARK-36964][CORE][YARN] Share cached dnsToSwitchMapping for yarn locality container requests

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #34231:
URL: https://github.com/apache/spark/pull/34231#issuecomment-1066216602


   We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
   If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] gaoyajun02 commented on pull request #34231: [SPARK-36964][CORE][YARN] Reuse CachedDNSToSwitchMapping for yarn container requests

Posted by GitBox <gi...@apache.org>.
gaoyajun02 commented on pull request #34231:
URL: https://github.com/apache/spark/pull/34231#issuecomment-939251568


   cc @squito 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] gaoyajun02 edited a comment on pull request #34231: [SPARK-36964][CORE][YARN] Reuse CachedDNSToSwitchMapping for yarn container requests

Posted by GitBox <gi...@apache.org>.
gaoyajun02 edited a comment on pull request #34231:
URL: https://github.com/apache/spark/pull/34231#issuecomment-939251568


   cc @squito @LantaoJin 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] gaoyajun02 commented on pull request #34231: [SPARK-36964][CORE][YARN] Share cached dnsToSwitchMapping for yarn locality container requests

Posted by GitBox <gi...@apache.org>.
gaoyajun02 commented on pull request #34231:
URL: https://github.com/apache/spark/pull/34231#issuecomment-962773495


   also cc @dongjoon-hyun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] gaoyajun02 edited a comment on pull request #34231: [SPARK-36964][CORE][YARN] Share cached dnsToSwitchMapping for yarn locality container requests

Posted by GitBox <gi...@apache.org>.
gaoyajun02 edited a comment on pull request #34231:
URL: https://github.com/apache/spark/pull/34231#issuecomment-942387570


   I tested in our cluster, When using spark RackResolver dnsToSwitchMapping:
   ```
   21/10/13 22:17:37 INFO Reporter YarnAllocator: Submitted 10 localized container requests took 183469 ms.
   21/10/13 22:17:37 INFO Reporter YarnAllocator: Submitted 32 localized container requests took 32 ms.
   21/10/13 22:17:39 INFO Reporter YarnAllocator: Submitted 64 localized container requests took 1306 ms.
   21/10/13 22:17:40 INFO Reporter YarnAllocator: Submitted 128 localized container requests took 65 ms.
   21/10/13 22:17:41 INFO Reporter YarnAllocator: Submitted 256 localized container requests took 115 ms.
   21/10/13 22:17:43 INFO Reporter YarnAllocator: Submitted 512 localized container requests took 209 ms.
   21/10/13 22:17:48 INFO Reporter YarnAllocator: Submitted 1024 localized container requests took 485 ms.
   21/10/13 22:17:51 INFO Reporter YarnAllocator: Submitted 780 localized container requests took 417 ms.
   ```
   
   and change to using yarn RackResolver dnsToSwitchMapping:
   ```
   21/10/13 22:07:23 INFO Reporter YarnAllocator: Submitted 18 localized container requests took 58 ms.
   21/10/13 22:07:24 INFO Reporter YarnAllocator: Submitted 64 localized container requests took 72 ms.
   21/10/13 22:07:25 INFO Reporter YarnAllocator: Submitted 128 localized container requests took 106 ms.
   21/10/13 22:07:26 INFO Reporter YarnAllocator: Submitted 256 localized container requests took 116 ms.
   21/10/13 22:07:30 INFO Reporter YarnAllocator: Submitted 512 localized container requests took 241 ms.
   21/10/13 22:07:37 INFO Reporter YarnAllocator: Submitted 1024 localized container requests took 570 ms.
   21/10/13 22:07:41 INFO Reporter YarnAllocator: Submitted 770 localized container requests took 535 ms.
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] gaoyajun02 edited a comment on pull request #34231: [SPARK-36964][CORE][YARN] Share cached dnsToSwitchMapping for yarn locality container requests

Posted by GitBox <gi...@apache.org>.
gaoyajun02 edited a comment on pull request #34231:
URL: https://github.com/apache/spark/pull/34231#issuecomment-942387570


   I tested in our cluster, When using spark RackResolver dnsToSwitchMapping:
   ```
   21/10/13 22:17:37 INFO Reporter YarnAllocator: Submitted 10 localized container requests took 183469 ms.
   21/10/13 22:17:37 INFO Reporter YarnAllocator: Submitted 32 localized container requests took 32 ms.
   21/10/13 22:17:39 INFO Reporter YarnAllocator: Submitted 64 localized container requests took 1306 ms.
   21/10/13 22:17:40 INFO Reporter YarnAllocator: Submitted 128 localized container requests took 65 ms.
   21/10/13 22:17:41 INFO Reporter YarnAllocator: Submitted 256 localized container requests took 115 ms.
   21/10/13 22:17:43 INFO Reporter YarnAllocator: Submitted 512 localized container requests took 209 ms.
   21/10/13 22:17:48 INFO Reporter YarnAllocator: Submitted 1024 localized container requests took 485 ms.
   21/10/13 22:17:51 INFO Reporter YarnAllocator: Submitted 780 localized container requests took 417 ms.
   ```
   
   And after changing to using yarn RackResolver dnsToSwitchMapping:
   ```
   21/10/13 22:07:23 INFO Reporter YarnAllocator: Submitted 18 localized container requests took 58 ms.
   21/10/13 22:07:24 INFO Reporter YarnAllocator: Submitted 64 localized container requests took 72 ms.
   21/10/13 22:07:25 INFO Reporter YarnAllocator: Submitted 128 localized container requests took 106 ms.
   21/10/13 22:07:26 INFO Reporter YarnAllocator: Submitted 256 localized container requests took 116 ms.
   21/10/13 22:07:30 INFO Reporter YarnAllocator: Submitted 512 localized container requests took 241 ms.
   21/10/13 22:07:37 INFO Reporter YarnAllocator: Submitted 1024 localized container requests took 570 ms.
   21/10/13 22:07:41 INFO Reporter YarnAllocator: Submitted 770 localized container requests took 535 ms.
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] gaoyajun02 commented on pull request #34231: [SPARK-36964][CORE][YARN] Share cached dnsToSwitchMapping for yarn locality container requests

Posted by GitBox <gi...@apache.org>.
gaoyajun02 commented on pull request #34231:
URL: https://github.com/apache/spark/pull/34231#issuecomment-942387570






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] gaoyajun02 edited a comment on pull request #34231: [SPARK-36964][CORE][YARN] Share cached dnsToSwitchMapping for yarn locality container requests

Posted by GitBox <gi...@apache.org>.
gaoyajun02 edited a comment on pull request #34231:
URL: https://github.com/apache/spark/pull/34231#issuecomment-942387570






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] github-actions[bot] closed pull request #34231: [SPARK-36964][CORE][YARN] Share cached dnsToSwitchMapping for yarn locality container requests

Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #34231:
URL: https://github.com/apache/spark/pull/34231


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34231: [SPARK-36964][CORE][YARN] Reuse CachedDNSToSwitchMapping for yarn container requests

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34231:
URL: https://github.com/apache/spark/pull/34231#issuecomment-939251256


   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on pull request #34231: [SPARK-36964][CORE][YARN] Share cached dnsToSwitchMapping for yarn locality container requests

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #34231:
URL: https://github.com/apache/spark/pull/34231#issuecomment-985531971


   @yaooqinn 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] gaoyajun02 commented on pull request #34231: [SPARK-36964][CORE][YARN] Share cached dnsToSwitchMapping for yarn locality container requests

Posted by GitBox <gi...@apache.org>.
gaoyajun02 commented on pull request #34231:
URL: https://github.com/apache/spark/pull/34231#issuecomment-942387570


   ```
   21/10/13 22:17:37 INFO Reporter YarnAllocator: Submitted 10 localized container requests took 183469 ms.
   21/10/13 22:17:37 INFO Reporter YarnAllocator: Submitted 32 localized container requests took 32 ms.
   21/10/13 22:17:39 INFO Reporter YarnAllocator: Submitted 64 localized container requests took 1306 ms.
   21/10/13 22:17:40 INFO Reporter YarnAllocator: Submitted 128 localized container requests took 65 ms.
   21/10/13 22:17:41 INFO Reporter YarnAllocator: Submitted 256 localized container requests took 115 ms.
   21/10/13 22:17:43 INFO Reporter YarnAllocator: Submitted 512 localized container requests took 209 ms.
   21/10/13 22:17:48 INFO Reporter YarnAllocator: Submitted 1024 localized container requests took 485 ms.
   21/10/13 22:17:51 INFO Reporter YarnAllocator: Submitted 780 localized container requests took 417 ms.
   ```
   
   ```
   21/10/13 22:07:23 INFO Reporter YarnAllocator: Submitted 18 localized container requests took 58 ms.
   21/10/13 22:07:24 INFO Reporter YarnAllocator: Submitted 64 localized container requests took 72 ms.
   21/10/13 22:07:25 INFO Reporter YarnAllocator: Submitted 128 localized container requests took 106 ms.
   21/10/13 22:07:26 INFO Reporter YarnAllocator: Submitted 256 localized container requests took 116 ms.
   21/10/13 22:07:30 INFO Reporter YarnAllocator: Submitted 512 localized container requests took 241 ms.
   21/10/13 22:07:37 INFO Reporter YarnAllocator: Submitted 1024 localized container requests took 570 ms.
   21/10/13 22:07:41 INFO Reporter YarnAllocator: Submitted 770 localized container requests took 535 ms.
   
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org