You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "Abhinandankaushik (via GitHub)" <gi...@apache.org> on 2026/02/04 16:41:14 UTC
[PR] Ci/add typos spellcheck [datafusion-site]
Abhinandankaushik opened a new pull request, #145:
URL: https://github.com/apache/datafusion-site/pull/145
Implemented the typo check workflow similar to the main repo :
https://github.com/apache/datafusion/blob/b81073ad4ca99b8c1139760843639c11cb1dea4a/.github/workflows/rust.yml#L780-L787
scoped only to `content/blog/`. The action now runs Typos against this directory to avoid unnecessary failures outside documentation content.
fixed issue : #118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Ci/add typos spellcheck [datafusion-site]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on PR #145:
URL: https://github.com/apache/datafusion-site/pull/145#issuecomment-3857391665
Thanks @Abhinandankaushik, good improvement as it caught some real typos in our blogs 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Ci/add typos spellcheck [datafusion-site]
Posted by "Abhinandankaushik (via GitHub)" <gi...@apache.org>.
Abhinandankaushik commented on PR #145:
URL: https://github.com/apache/datafusion-site/pull/145#issuecomment-3853140083
> Thanks for this @Abhinandankaushik
>
> Looks like the check has caught some typos but also a lot of false positives; we should add the false positives to the exclusion and fix any real typos as part of this PR
yeah definitely i will fix all this very soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Ci/add typos spellcheck [datafusion-site]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #145:
URL: https://github.com/apache/datafusion-site/pull/145#discussion_r2764934645
##########
.github/workflows/typo-check.yml:
##########
@@ -0,0 +1,36 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Typo Check
+
+on:
+ push:
+ branches:
+ - main
+ pull_request:
+
+jobs:
+ typos:
+ name: Spell Check with Typos
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
+ with:
+ persist-credentials: false
+ - uses: crate-ci/typos@40156d6074bf731adb169cfb8234954971dbc487 # v1.37.1
Review Comment:
The workflow uses commit SHAs with version comments (e.g., `actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0`), which is more secure than version tags. However, the existing workflows in this repository (publish-site.yml and stage-site.yml) use version tags (e.g., `actions/checkout@v4`).
For consistency with the existing codebase conventions, consider using the same approach as the other workflows. While commit SHAs are more secure, consistency within the repository is also valuable. If the team prefers the SHA approach, the other workflows should be updated as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Ci/add typos spellcheck [datafusion-site]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey merged PR #145:
URL: https://github.com/apache/datafusion-site/pull/145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Ci/add typos spellcheck [datafusion-site]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on PR #145:
URL: https://github.com/apache/datafusion-site/pull/145#issuecomment-3850467027
Thanks for this @Abhinandankaushik
Looks like the check has caught some typos but also a lot of false positives; we should add the false positives to the exclusion and fix any real typos as part of this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org