You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by "John Sherman (Jira)" <ji...@apache.org> on 2020/05/02 02:23:00 UTC

[jira] [Created] (HIVE-23354) Remove file size sanity checking from compareTempOrDuplicateFiles

John Sherman created HIVE-23354:
-----------------------------------

             Summary: Remove file size sanity checking from compareTempOrDuplicateFiles
                 Key: HIVE-23354
                 URL: https://issues.apache.org/jira/browse/HIVE-23354
             Project: Hive
          Issue Type: Bug
          Components: HiveServer2
            Reporter: John Sherman
            Assignee: John Sherman


https://github.com/apache/hive/blob/cdd55aa319a3440963a886ebfff11cd2a240781d/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java#L1952-L2010
compareTempOrDuplicateFiles uses a combination of attemptId and fileSize to determine which file(s) to keep.
I've seen instances where this function throws an exception due to the fact that the newer attemptId file size is less than the older attemptId (thus failing the query).
I think this assumption is faulty, due to various factors such as file compression and the order in which values are written. It may be prudent to trust that the newest attemptId is in
fact the best choice.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)