You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "snuyanzin (via GitHub)" <gi...@apache.org> on 2026/04/11 23:36:01 UTC
[PR] [CALCITE-7020] Upgrade gradle from 8.9 to 8.14.4 [calcite]
snuyanzin opened a new pull request, #4880:
URL: https://github.com/apache/calcite/pull/4880
## Jira Link
[CALCITE-7020](https://issues.apache.org/jira/browse/CALCITE-7020)
The PR bumps gradle to 8.14.4 and fixes gradle warnings
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7020] Upgrade gradle from 8.7 to 8.14.4 [calcite]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu commented on PR #4880:
URL: https://github.com/apache/calcite/pull/4880#issuecomment-4231628366
> > I seem to recall that upgrading Gradle would impact Java 8 support, but the CI tests indicate that everything is fine.
>
> there was an issue with jacoco (because of stricter rules in newer gradle), finally I was able to resolve it (these lines https://github.com/apache/calcite/pull/4880/changes#diff-c0dfa6bc7a8685217f70a860145fbdf416d449eaff052fa28352c5cec1a98c06R291-R293)
Thanks for the explanation. I don't fully understand this part, but judging by the test results, it looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7020] Upgrade gradle from 8.9 to 8.14.4 [calcite]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #4880:
URL: https://github.com/apache/calcite/pull/4880#discussion_r3068738279
##########
gradle.properties:
##########
@@ -46,14 +46,14 @@ org.checkerframework.version=0.5.16
com.github.autostyle.version=3.0
com.github.johnrengelman.shadow.version=5.1.0
com.github.spotbugs.version=2.0.0
-com.github.vlsi.vlsi-release-plugins.version=1.90
+com.github.vlsi.vlsi-release-plugins.version=3.0.1
Review Comment:
a number of warnings came from old plugins
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7020] Upgrade gradle from 8.7 to 8.14.4 [calcite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #4880:
URL: https://github.com/apache/calcite/pull/4880#issuecomment-4230423726
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4880) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4880&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4880&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4880&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4880&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4880&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4880)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7020] Upgrade gradle from 8.7 to 8.14.4 [calcite]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #4880:
URL: https://github.com/apache/calcite/pull/4880#issuecomment-4231564733
thank you for the review
I rebased and squashed commits
will merge soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7020] Upgrade gradle from 8.9 to 8.14.4 [calcite]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #4880:
URL: https://github.com/apache/calcite/pull/4880#discussion_r3068737909
##########
build.gradle.kts:
##########
@@ -418,6 +419,7 @@ allprojects {
val testRuntimeOnly by configurations
testImplementation(platform("org.junit:junit-bom"))
testImplementation("org.junit.jupiter:junit-jupiter")
+ testRuntimeOnly("org.junit.platform:junit-platform-launcher")
Review Comment:
kotlin 2.x requires this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7020] Upgrade gradle from 8.7 to 8.14.4 [calcite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #4880:
URL: https://github.com/apache/calcite/pull/4880#issuecomment-4231667894
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4880) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4880&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4880&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4880&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4880&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4880&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4880)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7020] Upgrade gradle from 8.7 to 8.14.4 [calcite]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin merged PR #4880:
URL: https://github.com/apache/calcite/pull/4880
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7020] Upgrade gradle from 8.7 to 8.14.4 [calcite]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #4880:
URL: https://github.com/apache/calcite/pull/4880#issuecomment-4231584504
>I seem to recall that upgrading Gradle would impact Java 8 support, but the CI tests indicate that everything is fine.
there was an issue with jacoco (because of stricter rules in newer gradle), finally I was able to resolve it (these lines https://github.com/apache/calcite/pull/4880/changes#diff-c0dfa6bc7a8685217f70a860145fbdf416d449eaff052fa28352c5cec1a98c06R291-R293)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7020] Upgrade gradle from 8.9 to 8.14.4 [calcite]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #4880:
URL: https://github.com/apache/calcite/pull/4880#discussion_r3068737333
##########
buildSrc/build.gradle.kts:
##########
@@ -42,8 +42,12 @@ allprojects {
// Ensure builds are reproducible
isPreserveFileTimestamps = false
isReproducibleFileOrder = true
- dirMode = "775".toInt(8)
- fileMode = "664".toInt(8)
+ dirPermissions {
+ unix("775")
+ }
+ filePermissions {
+ unix("664")
+ }
Review Comment:
`dirMode` and `fileMode` are deprecated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7020] Upgrade gradle from 8.9 to 8.14.4 [calcite]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #4880:
URL: https://github.com/apache/calcite/pull/4880#discussion_r3068737909
##########
build.gradle.kts:
##########
@@ -418,6 +419,7 @@ allprojects {
val testRuntimeOnly by configurations
testImplementation(platform("org.junit:junit-bom"))
testImplementation("org.junit.jupiter:junit-jupiter")
+ testRuntimeOnly("org.junit.platform:junit-platform-launcher")
Review Comment:
kotlin 2.2 requires this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7020] Upgrade gradle from 8.9 to 8.14.4 [calcite]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #4880:
URL: https://github.com/apache/calcite/pull/4880#discussion_r3068737631
##########
cassandra/src/test/java/org/apache/calcite/test/CassandraExtension.java:
##########
@@ -157,7 +157,7 @@ private static CassandraResource getOrCreate(ExtensionContext context) {
/** Cassandra resource. */
private static class CassandraResource
- implements ExtensionContext.Store.CloseableResource {
+ implements AutoCloseable {
Review Comment:
replace deprecated interface
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7020] Upgrade gradle from 8.9 to 8.14.4 [calcite]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #4880:
URL: https://github.com/apache/calcite/pull/4880#discussion_r3068738740
##########
gradle.properties:
##########
@@ -137,7 +137,7 @@ json-smart.version=2.6.0
jsr305.version=3.0.2
jsoup.version=1.11.3
junit4.version=4.13.2
-junit5.version=5.9.1
+junit5.version=5.10.5
Review Comment:
kotlin 2.x requires at least 5.10.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7020] Upgrade gradle from 8.7 to 8.14.4 [calcite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #4880:
URL: https://github.com/apache/calcite/pull/4880#issuecomment-4237908431
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4880) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4880&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4880&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4880&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4880&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4880&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4880)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7020] Upgrade gradle from 8.9 to 8.14.4 [calcite]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #4880:
URL: https://github.com/apache/calcite/pull/4880#discussion_r3068738461
##########
gradle.properties:
##########
@@ -75,16 +75,16 @@ checkstyle.version=8.28
spotbugs.version=3.1.11
errorprone.version=2.5.1
# The property is used in https://github.com/wildfly/jandex regression testing, so avoid renaming
-jandex.version=2.2.3.Final
+jandex.version=3.5.3
# We support Guava versions as old as 21.0 but prefer more recent versions.
# elasticsearch does not like asm:6.2.1+
aggdesigner-algorithm.version=6.1
apiguardian-api.version=1.1.2
arrow-gandiva.version=15.0.0
arrow.version=15.0.0
-asm.version=9.6
-byte-buddy.version=1.14.15
+asm.version=9.9.1
+byte-buddy.version=1.18.8
Review Comment:
prepare for newer java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7020] Upgrade gradle from 8.7 to 8.14.4 [calcite]
Posted by "mihaibudiu (via GitHub)" <gi...@apache.org>.
mihaibudiu commented on code in PR #4880:
URL: https://github.com/apache/calcite/pull/4880#discussion_r3068746834
##########
gradle/wrapper/gradle-wrapper.jar:
##########
Review Comment:
I don't know how to review this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7020] Upgrade gradle from 8.7 to 8.14.4 [calcite]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu commented on PR #4880:
URL: https://github.com/apache/calcite/pull/4880#issuecomment-4230429148
I seem to recall that upgrading Gradle would impact Java 8 support, but the CI tests indicate that everything is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org