You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by GitBox <gi...@apache.org> on 2020/05/31 13:04:16 UTC
[GitHub] [maven-shared-jar] elharo opened a new pull request #4: [MSHARED-905] set Maven 3.1.0 as minimum and cleanup dependencies
elharo opened a new pull request #4:
URL: https://github.com/apache/maven-shared-jar/pull/4
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-shared-jar] elharo closed pull request #4: [MSHARED-887] set Maven 3.1.0 as minimum and cleanup dependencies
Posted by GitBox <gi...@apache.org>.
elharo closed pull request #4:
URL: https://github.com/apache/maven-shared-jar/pull/4
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-shared-jar] slachiewicz edited a comment on pull request #4: [MSHARED-905] set Maven 3.1.0 as minimum and cleanup dependencies
Posted by GitBox <gi...@apache.org>.
slachiewicz edited a comment on pull request #4:
URL: https://github.com/apache/maven-shared-jar/pull/4#issuecomment-636472449
See other jira and commit https://github.com/apache/maven-shared-jar/commit/580f53c1b63a7630cb3a70822035f4531bfadf2b
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-shared-jar] elharo commented on pull request #4: [MSHARED-887] set Maven 3.1.0 as minimum and cleanup dependencies
Posted by GitBox <gi...@apache.org>.
elharo commented on pull request #4:
URL: https://github.com/apache/maven-shared-jar/pull/4#issuecomment-636486988
@slachiewicz After looking at that commit, the difference seems to be that this PR imports plexus-containers-default and that one imports org.eclipse.sisu.plexus.
I'm not sure why one should be chosen over the other or why two different artifacts provide the same classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-shared-jar] elharo commented on pull request #4: [MSHARED-905] set Maven 3.1.0 as minimum and cleanup dependencies
Posted by GitBox <gi...@apache.org>.
elharo commented on pull request #4:
URL: https://github.com/apache/maven-shared-jar/pull/4#issuecomment-636474949
That code doesn't seem to be in HEAD?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-shared-jar] slachiewicz commented on pull request #4: [MSHARED-905] set Maven 3.1.0 as minimum and cleanup dependencies
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on pull request #4:
URL: https://github.com/apache/maven-shared-jar/pull/4#issuecomment-636472449
https://github.com/apache/maven-shared-jar/commit/580f53c1b63a7630cb3a70822035f4531bfadf2b
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-shared-jar] slachiewicz commented on pull request #4: [MSHARED-887] set Maven 3.1.0 as minimum and cleanup dependencies
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on pull request #4:
URL: https://github.com/apache/maven-shared-jar/pull/4#issuecomment-636504356
I use the plexus version that was imported by the Maven 3.1 dependencies (3.1.1 already has a different version). It seems to me that if we use a newer version of Plexus and someone uses the classes/methods that were available before then this plugin may not work properly. I think Maven 3.1 will use artifacts that are provided by Core (https://github.com/apache/maven/blob/master/maven-core/src/main/resources/META-INF/maven/extension.xml)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org