You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Attila Doroszlai <ad...@hortonworks.com> on 2017/07/13 19:48:01 UTC

Review Request 60849: AMBARI-21469. Stop Spark fails due to missing stack selector

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60849/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-21469
    https://issues.apache.org/jira/browse/AMBARI-21469


Repository: ambari


Description
-------

Get current stack version from `hostLevelParams` instead of using stack selector.


Diffs
-----

  ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HBASE/package/scripts/params.py 9b61674f87552602c3ab989bdb1aed441f61fdcd 
  ambari-server/src/main/resources/stacks/BigInsights/4.2/services/SPARK/package/scripts/params.py 6d51b577f8dfe56920fc03c2db79a3898b809733 


Diff: https://reviews.apache.org/r/60849/diff/1/


Testing
-------

Tested on BigInsights 4.2 cluster that Spark server components are successfully stopped during the upgrade.


Thanks,

Attila Doroszlai


Re: Review Request 60849: AMBARI-21469. Stop Spark fails due to missing stack selector

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60849/#review180457
-----------------------------------------------------------


Ship it!




Any unit test changes missed?

- Sid Wagle


On July 13, 2017, 7:48 p.m., Attila Doroszlai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60849/
> -----------------------------------------------------------
> 
> (Updated July 13, 2017, 7:48 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21469
>     https://issues.apache.org/jira/browse/AMBARI-21469
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Get current stack version from `hostLevelParams` instead of using stack selector.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HBASE/package/scripts/params.py 9b61674f87552602c3ab989bdb1aed441f61fdcd 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2/services/SPARK/package/scripts/params.py 6d51b577f8dfe56920fc03c2db79a3898b809733 
> 
> 
> Diff: https://reviews.apache.org/r/60849/diff/1/
> 
> 
> Testing
> -------
> 
> Tested on BigInsights 4.2 cluster that Spark server components are successfully stopped during the upgrade.
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>


Re: Review Request 60849: AMBARI-21469. Stop Spark fails due to missing stack selector

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60849/#review180459
-----------------------------------------------------------


Ship it!




Ship It!

- Alejandro Fernandez


On July 13, 2017, 7:48 p.m., Attila Doroszlai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60849/
> -----------------------------------------------------------
> 
> (Updated July 13, 2017, 7:48 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21469
>     https://issues.apache.org/jira/browse/AMBARI-21469
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Get current stack version from `hostLevelParams` instead of using stack selector.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HBASE/package/scripts/params.py 9b61674f87552602c3ab989bdb1aed441f61fdcd 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2/services/SPARK/package/scripts/params.py 6d51b577f8dfe56920fc03c2db79a3898b809733 
> 
> 
> Diff: https://reviews.apache.org/r/60849/diff/1/
> 
> 
> Testing
> -------
> 
> Tested on BigInsights 4.2 cluster that Spark server components are successfully stopped during the upgrade.
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>


Re: Review Request 60849: AMBARI-21469. Stop Spark fails due to missing stack selector

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60849/#review180467
-----------------------------------------------------------


Ship it!




Ship It!

- Jonathan Hurley


On July 13, 2017, 3:48 p.m., Attila Doroszlai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60849/
> -----------------------------------------------------------
> 
> (Updated July 13, 2017, 3:48 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21469
>     https://issues.apache.org/jira/browse/AMBARI-21469
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Get current stack version from `hostLevelParams` instead of using stack selector.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HBASE/package/scripts/params.py 9b61674f87552602c3ab989bdb1aed441f61fdcd 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2/services/SPARK/package/scripts/params.py 6d51b577f8dfe56920fc03c2db79a3898b809733 
> 
> 
> Diff: https://reviews.apache.org/r/60849/diff/1/
> 
> 
> Testing
> -------
> 
> Tested on BigInsights 4.2 cluster that Spark server components are successfully stopped during the upgrade.
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>