You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/11/09 11:43:06 UTC

[GitHub] [pulsar] BewareMyPower opened a new pull request #8486: [C++] Catch exception thrown by remote_endpoint

BewareMyPower opened a new pull request #8486:
URL: https://github.com/apache/pulsar/pull/8486


   ### Motivation
   
   Boost asio `socket::remote_point` may throw `boost::system::system_error` on failure. If the C++ client library was compiled with some low version boost, like 1.54, even if `async_connect` success, the server could still be unreachable and an exception would be thrown by `socket_->remote_endpoint()`.
   
   ### Modifications
   
   - Catch the exception for  `socket_->remote_endpoint()`
   - Add tests for when client connects to a unreachable service url
   - Fix header dependency because some boost *.hpp file doesn't include assert.h
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change added tests and can be verified as follows:
   
     - Run `testServerConnectError`. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] jiazhai commented on pull request #8486: [C++] Catch exception thrown by remote_endpoint

Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #8486:
URL: https://github.com/apache/pulsar/pull/8486#issuecomment-724031129


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on pull request #8486: [C++] Catch exception thrown by remote_endpoint

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8486:
URL: https://github.com/apache/pulsar/pull/8486#issuecomment-724506513


   cherry-picked to branch-2.6


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] BewareMyPower commented on pull request #8486: [C++] Catch exception thrown by remote_endpoint

Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #8486:
URL: https://github.com/apache/pulsar/pull/8486#issuecomment-724066084


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #8486: [C++] Catch exception thrown by remote_endpoint

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #8486:
URL: https://github.com/apache/pulsar/pull/8486


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] BewareMyPower commented on pull request #8486: [C++] Catch exception thrown by remote_endpoint

Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #8486:
URL: https://github.com/apache/pulsar/pull/8486#issuecomment-724011911


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org