[GitHub] [pulsar] michaeljmarshall commented on issue #14304: CommandLookupTopic.advertisedListenerName may be blank

[GitBox <gi...@apache.org>]

michaeljmarshall commented on issue #14304:
URL: https://github.com/apache/pulsar/issues/14304#issuecomment-1040853045


   https://github.com/apache/pulsar/blob/2d092374e189093cce7c792dd31bf9290a3e7d82/pulsar-common/src/main/java/org/apache/pulsar/common/protocol/Commands.java#L820-L822
   
   @EronWright - were you able to reproduce this issue with the Java client? Based on the code you reference, it looks like the `advertisedListenerName` would be null unless a "non blank" string is used.
   
   I can see in the Go client, we are using string type instead of a string reference (`*string`) type in the `lookupService` struct, and that results in passing an empty string.
   
   I agree with your proposed solution, but I am concerned that this is a point of ambiguity in the spec that should be better defined. I'd also like to understand how we're seeing this issue with the Java client since it looks like it `hasAdvertisedListenerName` should return false in the `ServerCnx`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org