You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2023/02/15 04:04:35 UTC
[GitHub] [spark] zhengruifeng opened a new pull request, #40029: [SPARK-42431][CONNECT][FOLLOWUP] Use `Distinct` to delay analysis for `Union`
zhengruifeng opened a new pull request, #40029:
URL: https://github.com/apache/spark/pull/40029
### What changes were proposed in this pull request?
use `Distinct` instead of `Deduplicate`
### Why are the changes needed?
to delay analysis, see https://github.com/apache/spark/pull/40008#discussion_r1106529796
### Does this PR introduce _any_ user-facing change?
plan shown in `explain` may change
### How was this patch tested?
updated UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #40029: [SPARK-42431][CONNECT][FOLLOWUP] Use `Distinct` to delay analysis for `Union`
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #40029:
URL: https://github.com/apache/spark/pull/40029#issuecomment-1431223398
Merged to master and branch-3.4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #40029: [SPARK-42431][CONNECT][FOLLOWUP] Use `Distinct` to delay analysis for `Union`
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #40029: [SPARK-42431][CONNECT][FOLLOWUP] Use `Distinct` to delay analysis for `Union`
URL: https://github.com/apache/spark/pull/40029
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #40029: [SPARK-42431][CONNECT][FOLLOWUP] Use `Distinct` to delay analysis for `Union`
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #40029:
URL: https://github.com/apache/spark/pull/40029#issuecomment-1431286013
Thank you @HyukjinKwon @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org