You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Mayya Sharipova (Jira)" <ji...@apache.org> on 2021/07/16 13:15:00 UTC
[jira] [Comment Edited] (LUCENE-9450) Taxonomy index should use
DocValues not StoredFields
[ https://issues.apache.org/jira/browse/LUCENE-9450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382068#comment-17382068 ]
Mayya Sharipova edited comment on LUCENE-9450 at 7/16/21, 1:14 PM:
-------------------------------------------------------------------
Hello [~gworah]! I wanted to ask opinion what to do with the test org.apache.lucene.facet.taxonomy.directory.TestBackwardsCompatibility::testCreateNewTaxonomy. Because of LUCENE-9334 it is no longer possible to modify fields data structures even for older indices. Thus we can't add a new $full_path$ field indexed with BinaryDocValues, because in previous segments of the older index this field was indexed without doc values. So unfortunately, I can't see [any way to enable this test.|https://github.com/apache/lucene/blob/main/lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestBackwardsCompatibility.java#L54-L58]
was (Author: mayya):
Hello [~gworah]! I wanted to ask opinion what to do with the test org.apache.lucene.facet.taxonomy.directory.TestBackwardsCompatibility::testCreateNewTaxonomy. Because of LUCENE-9334 it is no longer possible to modify fields data structures even for older indices. Thus we can't add a new $full_path$ field indexed with BinaryDocValues, because in previous segments of the older index this field was indexed without doc values. So unfortunately, I can't see any way to enable this test.
> Taxonomy index should use DocValues not StoredFields
> ----------------------------------------------------
>
> Key: LUCENE-9450
> URL: https://issues.apache.org/jira/browse/LUCENE-9450
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/facet
> Affects Versions: 8.5.2
> Reporter: Gautam Worah
> Priority: Minor
> Labels: performance
> Fix For: main (9.0)
>
> Attachments: LUCENE-9450-localrun.py-v1, wip_taxonomy_patch
>
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> The taxonomy index that maps binning labels to ordinals was created before Lucene added BinaryDocValues.
> I've attached a WIP patch (does not pass tests currently)
> Issue suggested by [~mikemccand]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org