You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/17 23:01:44 UTC
[GitHub] [airflow] Udit107710 opened a new pull request #9358: Tests for AWS Athena
Udit107710 opened a new pull request #9358:
URL: https://github.com/apache/airflow/pull/9358
This was created to address one of the files mentioned by #8278.
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Target Github ISSUE in description if exists
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] stale[bot] closed pull request #9358: Tests for AWS Athena
Posted by GitBox <gi...@apache.org>.
stale[bot] closed pull request #9358:
URL: https://github.com/apache/airflow/pull/9358
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Udit107710 commented on pull request #9358: Tests for AWS Athena
Posted by GitBox <gi...@apache.org>.
Udit107710 commented on pull request #9358:
URL: https://github.com/apache/airflow/pull/9358#issuecomment-648454448
@potiuk The stable release for 1.3.15 is not available. The new features for Athena are still in dev branch. Should I bump the dependency or use mock?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb edited a comment on pull request #9358: Tests for AWS Athena
Posted by GitBox <gi...@apache.org>.
ashb edited a comment on pull request #9358:
URL: https://github.com/apache/airflow/pull/9358#issuecomment-645904767
This would run the tests against an actual Athena instance, which isn't what we want in our unit tests.
Please look at https://github.com/spulec/moto (already used in other tests, for instance S3) and which supports Athena since 1.3.14 (which are are using). moto as of the latest release may not provide _enough_ mocking, so you may have to use just normal unittest.mock to ensure that no network requests are made in this unit test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] stale[bot] commented on pull request #9358: Tests for AWS Athena
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #9358:
URL: https://github.com/apache/airflow/pull/9358#issuecomment-670836631
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #9358: Tests for AWS Athena
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #9358:
URL: https://github.com/apache/airflow/pull/9358#issuecomment-647342626
Yep. It would be great to get it mocked :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #9358: Tests for AWS Athena
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #9358:
URL: https://github.com/apache/airflow/pull/9358#issuecomment-645904767
This would run the tests against an actual Athena instance, which isn't what we want in our unit tests.
Please look at https://github.com/spulec/moto (already used in other tests, for instance S3) and which supports Athena since 1.3.14 (which are are using)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Udit107710 commented on pull request #9358: Tests for AWS Athena
Posted by GitBox <gi...@apache.org>.
Udit107710 commented on pull request #9358:
URL: https://github.com/apache/airflow/pull/9358#issuecomment-647183587
>
>
> This would run the tests against an actual Athena instance, which isn't what we want in our unit tests.
>
> Please look at https://github.com/spulec/moto (already used in other tests, for instance S3) and which supports Athena since 1.3.14 (which are are using). moto as of the latest release may not provide _enough_ mocking, so you may have to use just normal unittest.mock to ensure that no network requests are made in this unit test.
10 days ago, support for various functions in Athena, being used by Airflow has been added to moto. I would recommend to bump moto from 1.3.14 to 1.3.15(latest release).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org