You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ha...@apache.org on 2026/08/16 05:11:17 UTC
(superset) branch feat/remove-wait-on-with-os-alternative created (now 8a89fd4bded)
This is an automated email from the ASF dual-hosted git repository.
hainenber pushed a change to branch feat/remove-wait-on-with-os-alternative
in repository https://gitbox.apache.org/repos/asf/superset.git
at 8a89fd4bded chore(build): replace `wait-on` with native shell commands + use `concurrently` programatically
This branch includes the following new commits:
new 8a89fd4bded chore(build): replace `wait-on` with native shell commands + use `concurrently` programatically
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
(superset) 01/01: chore(build): replace `wait-on` with native shell commands + use `concurrently` programatically
Posted by ha...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
hainenber pushed a commit to branch feat/remove-wait-on-with-os-alternative
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 8a89fd4bded7602ed53938dcb2dd4524879336b8
Author: hainenber <do...@gmail.com>
AuthorDate: Sun Aug 16 12:10:56 2026 +0700
chore(build): replace `wait-on` with native shell commands + use `concurrently` programatically
Signed-off-by: hainenber <do...@gmail.com>
---
superset-frontend/package-lock.json | 110 -------------------------
superset-frontend/package.json | 3 +-
superset-frontend/scripts/test-storybook-ci.js | 48 +++++++++++
3 files changed, 49 insertions(+), 112 deletions(-)
diff --git a/superset-frontend/package-lock.json b/superset-frontend/package-lock.json
index 244ca140576..89b53c9e4c9 100644
--- a/superset-frontend/package-lock.json
+++ b/superset-frontend/package-lock.json
@@ -275,7 +275,6 @@
"tsx": "^4.23.10",
"typescript": "5.4.5",
"unzipper": "^0.12.5",
- "wait-on": "^9.1.0",
"webpack": "^5.109.2",
"webpack-bundle-analyzer": "^5.3.1",
"webpack-cli": "^7.0.3",
@@ -4173,60 +4172,6 @@
"react": "^17 || ^18"
}
},
- "node_modules/@hapi/address": {
- "version": "5.1.1",
- "resolved": "https://registry.npmjs.org/@hapi/address/-/address-5.1.1.tgz",
- "integrity": "sha512-A+po2d/dVoY7cYajycYI43ZbYMXukuopIsqCjh5QzsBCipDtdofHntljDlpccMjIfTy6UOkg+5KPriwYch2bXA==",
- "dev": true,
- "license": "BSD-3-Clause",
- "dependencies": {
- "@hapi/hoek": "^11.0.2"
- },
- "engines": {
- "node": ">=14.0.0"
- }
- },
- "node_modules/@hapi/formula": {
- "version": "3.0.2",
- "resolved": "https://registry.npmjs.org/@hapi/formula/-/formula-3.0.2.tgz",
- "integrity": "sha512-hY5YPNXzw1He7s0iqkRQi+uMGh383CGdyyIGYtB+W5N3KHPXoqychklvHhKCC9M3Xtv0OCs/IHw+r4dcHtBYWw==",
- "dev": true,
- "license": "BSD-3-Clause"
- },
- "node_modules/@hapi/hoek": {
- "version": "11.0.7",
- "resolved": "https://registry.npmjs.org/@hapi/hoek/-/hoek-11.0.7.tgz",
- "integrity": "sha512-HV5undWkKzcB4RZUusqOpcgxOaq6VOAH7zhhIr2g3G8NF/MlFO75SjOr2NfuSx0Mh40+1FqCkagKLJRykUWoFQ==",
- "dev": true,
- "license": "BSD-3-Clause"
- },
- "node_modules/@hapi/pinpoint": {
- "version": "2.0.1",
- "resolved": "https://registry.npmjs.org/@hapi/pinpoint/-/pinpoint-2.0.1.tgz",
- "integrity": "sha512-EKQmr16tM8s16vTT3cA5L0kZZcTMU5DUOZTuvpnY738m+jyP3JIUj+Mm1xc1rsLkGBQ/gVnfKYPwOmPg1tUR4Q==",
- "dev": true,
- "license": "BSD-3-Clause"
- },
- "node_modules/@hapi/tlds": {
- "version": "1.1.7",
- "resolved": "https://registry.npmjs.org/@hapi/tlds/-/tlds-1.1.7.tgz",
- "integrity": "sha512-MgNjRwy9Ti92yVAixLmDc8dd1bJIKwO9qlWCfFQRwRmUEDPQHYn4G6hwPFvFGUTzAa0FsS+inMjLin7GnyBRhA==",
- "dev": true,
- "license": "BSD-3-Clause",
- "engines": {
- "node": ">=14.0.0"
- }
- },
- "node_modules/@hapi/topo": {
- "version": "6.0.2",
- "resolved": "https://registry.npmjs.org/@hapi/topo/-/topo-6.0.2.tgz",
- "integrity": "sha512-KR3rD5inZbGMrHmgPxsJ9dbi6zEK+C3ZwUwTa+eMwWLz7oijWUTWD2pMSNNYJAU6Qq+65NkxXjqHr/7LM2Xkqg==",
- "dev": true,
- "license": "BSD-3-Clause",
- "dependencies": {
- "@hapi/hoek": "^11.0.2"
- }
- },
"node_modules/@humanfs/core": {
"version": "0.19.2",
"resolved": "https://registry.npmjs.org/@humanfs/core/-/core-0.19.2.tgz",
@@ -10733,13 +10678,6 @@
"@sinonjs/commons": "^3.0.1"
}
},
- "node_modules/@standard-schema/spec": {
- "version": "1.1.0",
- "resolved": "https://registry.npmjs.org/@standard-schema/spec/-/spec-1.1.0.tgz",
- "integrity": "sha512-l2aFy5jALhniG5HgqrD6jXLi/rUWrKvqN/qJx6yoJsgKhblVd+iqqU4RCXavm/jPityDo5TCvKMnpjKnOriy0w==",
- "dev": true,
- "license": "MIT"
- },
"node_modules/@storybook/addon-docs": {
"version": "10.5.7",
"resolved": "https://registry.npmjs.org/@storybook/addon-docs/-/addon-docs-10.5.7.tgz",
@@ -26957,25 +26895,6 @@
"url": "https://github.com/chalk/supports-color?sponsor=1"
}
},
- "node_modules/joi": {
- "version": "18.2.3",
- "resolved": "https://registry.npmjs.org/joi/-/joi-18.2.3.tgz",
- "integrity": "sha512-N5A3KTWQpPWT4ExxxPlUx7WmykGXRzhNidWhV41d6Abu9YfI2NyWCJuxdPnslJCPWtbRpSVOWSnSS6GakLM/Rg==",
- "dev": true,
- "license": "BSD-3-Clause",
- "dependencies": {
- "@hapi/address": "^5.1.1",
- "@hapi/formula": "^3.0.2",
- "@hapi/hoek": "^11.0.7",
- "@hapi/pinpoint": "^2.0.1",
- "@hapi/tlds": "^1.1.1",
- "@hapi/topo": "^6.0.2",
- "@standard-schema/spec": "^1.1.0"
- },
- "engines": {
- "node": ">= 20"
- }
- },
"node_modules/jquery": {
"version": "4.0.0",
"resolved": "https://registry.npmjs.org/jquery/-/jquery-4.0.0.tgz",
@@ -41115,26 +41034,6 @@
"node": ">=18"
}
},
- "node_modules/wait-on": {
- "version": "9.1.0",
- "resolved": "https://registry.npmjs.org/wait-on/-/wait-on-9.1.0.tgz",
- "integrity": "sha512-PymrLXHLBM1Ju/Xspb2ADUhbPSMvbnuNvy/mN2hWtpbJ3da0h3Ky1LqwKPG5QSVR57liyO0iUpfipYl/s5qNvA==",
- "dev": true,
- "license": "MIT",
- "dependencies": {
- "axios": "^1.18.1",
- "joi": "^18.2.3",
- "lodash": "^4.18.1",
- "minimist": "^1.2.8",
- "rxjs": "^7.8.2"
- },
- "bin": {
- "wait-on": "bin/wait-on"
- },
- "engines": {
- "node": ">=20.0.0"
- }
- },
"node_modules/wait-port": {
"version": "0.2.14",
"resolved": "https://registry.npmjs.org/wait-port/-/wait-port-0.2.14.tgz",
@@ -43353,15 +43252,6 @@
"node": ">=12"
}
},
- "packages/superset-ui-core/node_modules/dompurify": {
- "version": "3.4.13",
- "resolved": "https://registry.npmjs.org/dompurify/-/dompurify-3.4.13.tgz",
- "integrity": "sha512-2vmYIoqjze2d+kakP8S/nS5shfsl587kzwEjcGlTdiksUVgFHnFCsLYDVj/JNqJVOQZGSYBTmuycv0PodwmnMQ==",
- "license": "(MPL-2.0 OR Apache-2.0)",
- "optionalDependencies": {
- "@types/trusted-types": "^2.0.7"
- }
- },
"packages/superset-ui-core/node_modules/react-ace": {
"version": "14.0.1",
"resolved": "https://registry.npmjs.org/react-ace/-/react-ace-14.0.1.tgz",
diff --git a/superset-frontend/package.json b/superset-frontend/package.json
index 4f660b54aac..e7f2262b17e 100644
--- a/superset-frontend/package.json
+++ b/superset-frontend/package.json
@@ -82,7 +82,7 @@
"prune": "rm -rf ./{packages,plugins}/*/{node_modules,lib,esm,tsconfig.tsbuildinfo,package-lock.json} ./.temp_cache",
"storybook": "cross-env NODE_ENV=development BABEL_ENV=development storybook dev -p 6006",
"test-storybook": "test-storybook",
- "test-storybook:ci": "concurrently --kill-others --success first --names \"SB,TEST\" --prefix-colors \"magenta,blue\" \"python3 -m http.server 6006 --directory storybook-static\" \"npx wait-on tcp:127.0.0.1:6006 && npm run test-storybook -- --maxWorkers=2\"",
+ "test-storybook:ci": "node ./scripts/test-storybook-ci.js",
"tdd": "cross-env NODE_ENV=test NODE_OPTIONS=\"--max-old-space-size=8192\" jest --watch",
"test": "cross-env NODE_ENV=test NODE_OPTIONS=\"--max-old-space-size=8192\" jest --max-workers=80% --silent",
"test-loud": "cross-env NODE_ENV=test NODE_OPTIONS=\"--max-old-space-size=8192\" jest --max-workers=80%",
@@ -352,7 +352,6 @@
"tsx": "^4.23.10",
"typescript": "5.4.5",
"unzipper": "^0.12.5",
- "wait-on": "^9.1.0",
"webpack": "^5.109.2",
"webpack-bundle-analyzer": "^5.3.1",
"webpack-cli": "^7.0.3",
diff --git a/superset-frontend/scripts/test-storybook-ci.js b/superset-frontend/scripts/test-storybook-ci.js
new file mode 100644
index 00000000000..d6ce00c3803
--- /dev/null
+++ b/superset-frontend/scripts/test-storybook-ci.js
@@ -0,0 +1,48 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+const path = require('node:path');
+const { concurrently } = require('concurrently');
+
+const storybookPort = '6006';
+const { result } = concurrently(
+ [
+ {
+ name: 'SB',
+ command: `python3 -m http.server ${storybookPort} --directory storybook-static`,
+ },
+ {
+ name: 'TEST',
+ command: `while ! nc -z 127.0.01 ${storybookPort}; do sleep 1; done && npm run test-storybook -- --maxWorkers=2`,
+ },
+ ],
+ {
+ killOthersOn: ['failure', 'success'],
+ successCondition: 'first',
+ prefixColors: ['magenta', 'blue'],
+ cwd: path.resolve(__dirname, '..'),
+ },
+);
+
+// Pass placeholder success/error handlers as CI runners should
+// show errors clearly
+result.then(
+ () => {},
+ () => {},
+);