[GitHub] [gora] alfonsonishikawa commented on a change in pull request #178: GORA-485 Apache Kudu datastore for Gora

[GitBox <gi...@apache.org>]

alfonsonishikawa commented on a change in pull request #178: GORA-485 Apache Kudu datastore for Gora
URL: https://github.com/apache/gora/pull/178#discussion_r317420247
 
 

 ##########
 File path: gora-kudu/src/test/java/org/apache/gora/kudu/mapreduce/KuduStoreMapReduceTest.java
 ##########
 @@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.gora.kudu.mapreduce;
+
+import java.io.IOException;
+import org.apache.gora.examples.generated.WebPage;
+import org.apache.gora.kudu.GoraKuduTestDriver;
+import org.apache.gora.kudu.utils.KuduBackendConstants;
+import org.apache.gora.mapreduce.DataStoreMapReduceTestBase;
+import org.apache.gora.store.DataStore;
+import org.apache.gora.store.DataStoreFactory;
+import org.apache.hadoop.mapred.JobConf;
+import org.junit.After;
+import org.junit.Before;
+
+/**
+ * Executes tests for MR jobs over Kudu dataStore.
+ */
+public class KuduStoreMapReduceTest extends DataStoreMapReduceTestBase {
+
+  private GoraKuduTestDriver driver;
+
+  public KuduStoreMapReduceTest() throws IOException {
+    super();
+    driver = new GoraKuduTestDriver();
+  }
+
+  @Override
+  @Before
+  public void setUp() throws Exception {
+    driver.setUpClass();
+    super.setUp();
+  }
+
+  @Override
+  @After
+  public void tearDown() throws Exception {
+    super.tearDown();
+    driver.tearDownClass();
+  }
+
+  @Override
+  protected DataStore<String, WebPage> createWebPageDataStore() throws IOException {
+    try {
 
 Review comment:
   This try/catch would not be needed since GoraException thrown by getDataStore extends IOException :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services