You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@reef.apache.org by ch...@apache.org on 2015/07/28 07:15:59 UTC
[11/12] incubator-reef git commit: [REEF-513] Add FinalParameters to
checkstyle
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-common/src/test/java/org/apache/reef/util/DeadlockInfoTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/test/java/org/apache/reef/util/DeadlockInfoTest.java b/lang/java/reef-common/src/test/java/org/apache/reef/util/DeadlockInfoTest.java
index dc017ed..d3b77e9 100644
--- a/lang/java/reef-common/src/test/java/org/apache/reef/util/DeadlockInfoTest.java
+++ b/lang/java/reef-common/src/test/java/org/apache/reef/util/DeadlockInfoTest.java
@@ -131,13 +131,13 @@ public final class DeadlockInfoTest {
private static void barrierAwait(final CyclicBarrier barrier) {
try {
barrier.await(TIMEOUT_MILLIS, TimeUnit.MILLISECONDS);
- } catch (InterruptedException e) {
+ } catch (final InterruptedException e) {
e.printStackTrace();
fail("Unexpected exception");
- } catch (BrokenBarrierException e) {
+ } catch (final BrokenBarrierException e) {
e.printStackTrace();
fail("Unexpected exception");
- } catch (TimeoutException e) {
+ } catch (final TimeoutException e) {
e.printStackTrace();
fail("Unexpected exception");
}
@@ -152,7 +152,7 @@ public final class DeadlockInfoTest {
private static void threadSleep(final long millis) {
try {
Thread.sleep(millis);
- } catch (InterruptedException e) {
+ } catch (final InterruptedException e) {
e.printStackTrace();
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-examples-clr/src/main/java/org/apache/reef/examples/helloCLR/HelloCLR.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples-clr/src/main/java/org/apache/reef/examples/helloCLR/HelloCLR.java b/lang/java/reef-examples-clr/src/main/java/org/apache/reef/examples/helloCLR/HelloCLR.java
index 953ae53..d97b44a 100644
--- a/lang/java/reef-examples-clr/src/main/java/org/apache/reef/examples/helloCLR/HelloCLR.java
+++ b/lang/java/reef-examples-clr/src/main/java/org/apache/reef/examples/helloCLR/HelloCLR.java
@@ -66,7 +66,7 @@ public final class HelloCLR {
public static LauncherStatus runHelloCLR(final Configuration runtimeConf, final int timeOut, final File clrFolder)
throws BindException, InjectionException {
- ConfigurationModule driverConf =
+ final ConfigurationModule driverConf =
addAll(DriverConfiguration.CONF, DriverConfiguration.GLOBAL_FILES, clrFolder)
.set(DriverConfiguration.GLOBAL_LIBRARIES, EnvironmentUtils.getClassLocation(HelloDriver.class))
.set(DriverConfiguration.DRIVER_IDENTIFIER, "HelloCLR")
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/loss/SquaredErrorLossFunction.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/loss/SquaredErrorLossFunction.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/loss/SquaredErrorLossFunction.java
index 05f601b..443b71e 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/loss/SquaredErrorLossFunction.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/loss/SquaredErrorLossFunction.java
@@ -33,12 +33,12 @@ public class SquaredErrorLossFunction implements LossFunction {
}
@Override
- public double computeLoss(double y, double f) {
+ public double computeLoss(final double y, final double f) {
return Math.pow(y - f, 2.0);
}
@Override
- public double computeGradient(double y, double f) {
+ public double computeGradient(final double y, final double f) {
return (f - y) * 0.5;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/loss/WeightedLogisticLossFunction.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/loss/WeightedLogisticLossFunction.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/loss/WeightedLogisticLossFunction.java
index 1766441..5cb65f4 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/loss/WeightedLogisticLossFunction.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/loss/WeightedLogisticLossFunction.java
@@ -38,7 +38,7 @@ public final class WeightedLogisticLossFunction implements LossFunction {
}
@Override
- public double computeLoss(double y, double f) {
+ public double computeLoss(final double y, final double f) {
final double predictedTimesLabel = y * f;
final double weight = y == -1 ? this.negWeight : this.posWeight;
@@ -51,7 +51,7 @@ public final class WeightedLogisticLossFunction implements LossFunction {
}
@Override
- public double computeGradient(double y, double f) {
+ public double computeGradient(final double y, final double f) {
final double predictedTimesLabel = y * f;
final double weight = y == -1 ? this.negWeight : this.posWeight;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/utils/math/VectorCodec.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/utils/math/VectorCodec.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/utils/math/VectorCodec.java
index 92ec713..b44ed75 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/utils/math/VectorCodec.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/utils/math/VectorCodec.java
@@ -38,31 +38,31 @@ public class VectorCodec implements Codec<Vector> {
}
@Override
- public Vector decode(byte[] data) {
- ByteArrayInputStream bais = new ByteArrayInputStream(data);
- Vector result;
+ public Vector decode(final byte[] data) {
+ final ByteArrayInputStream bais = new ByteArrayInputStream(data);
+ final Vector result;
try (DataInputStream dais = new DataInputStream(bais)) {
- int size = dais.readInt();
+ final int size = dais.readInt();
result = new DenseVector(size);
for (int i = 0; i < size; i++) {
result.set(i, dais.readDouble());
}
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new RuntimeException(e.getCause());
}
return result;
}
@Override
- public byte[] encode(Vector vec) {
- ByteArrayOutputStream baos = new ByteArrayOutputStream(vec.size()
+ public byte[] encode(final Vector vec) {
+ final ByteArrayOutputStream baos = new ByteArrayOutputStream(vec.size()
* (Double.SIZE / Byte.SIZE));
try (DataOutputStream daos = new DataOutputStream(baos)) {
daos.writeInt(vec.size());
for (int i = 0; i < vec.size(); i++) {
daos.writeDouble(vec.get(i));
}
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new RuntimeException(e.getCause());
}
return baos.toByteArray();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/utils/math/Window.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/utils/math/Window.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/utils/math/Window.java
index bd02439..e170ada 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/utils/math/Window.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/utils/math/Window.java
@@ -29,12 +29,12 @@ public class Window {
private final int maxSize;
private final List<Double> list;
- public Window(int size) {
+ public Window(final int size) {
this.maxSize = size;
list = new ArrayList<>(size);
}
- public void add(double d) {
+ public void add(final double d) {
if (list.size() < maxSize) {
list.add(d);
return;
@@ -48,25 +48,26 @@ public class Window {
return 0;
}
double retVal = 0;
- for (double d : list) {
+ for (final double d : list) {
retVal += d;
}
return retVal / list.size();
}
- public double avgIfAdded(double d) {
+ public double avgIfAdded(final double in) {
+ double d = in;
if (list.isEmpty()) {
return d;
}
- int start = (list.size() < maxSize) ? 0 : 1;
- int numElems = (list.size() < maxSize) ? list.size() + 1 : maxSize;
+ final int start = (list.size() < maxSize) ? 0 : 1;
+ final int numElems = (list.size() < maxSize) ? list.size() + 1 : maxSize;
for (int i = start; i < list.size(); i++) {
d += list.get(i);
}
return d / numElems;
}
- public static void main(String[] args) {
+ public static void main(final String[] args) {
final Logger log = Logger.getLogger(Window.class.getName());
final Window w = new Window(3);
for (int i = 1; i < 10; i++) {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloReefYarnTcp.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloReefYarnTcp.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloReefYarnTcp.java
index 1fa9d2e..2003131 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloReefYarnTcp.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloReefYarnTcp.java
@@ -61,9 +61,9 @@ public final class HelloReefYarnTcp {
}
private static Configuration getRuntimeConfiguration(
- int tcpBeginPort,
- int tcpRangeCount,
- int tcpTryCount) {
+ final int tcpBeginPort,
+ final int tcpRangeCount,
+ final int tcpTryCount) {
return Tang.Factory.getTang().newConfigurationBuilder(YarnClientConfiguration.CONF.build())
.bindSetEntry(DriverConfigurationProviders.class, TcpPortConfigurationProvider.class)
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hellohttp/HttpServerShellCmdtHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hellohttp/HttpServerShellCmdtHandler.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hellohttp/HttpServerShellCmdtHandler.java
index 041b447..891aa66 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hellohttp/HttpServerShellCmdtHandler.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hellohttp/HttpServerShellCmdtHandler.java
@@ -139,7 +139,7 @@ class HttpServerShellCmdtHandler implements HttpHandler {
*
* @param message
*/
- public final synchronized void onHttpCallback(byte[] message) {
+ public final synchronized void onHttpCallback(final byte[] message) {
final long endTime = System.currentTimeMillis() + WAIT_TIMEOUT;
while (cmdOutput != null) {
final long waitTime = endTime - System.currentTimeMillis();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-examples/src/main/java/org/apache/reef/examples/library/ShellTask.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/library/ShellTask.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/library/ShellTask.java
index 74fba56..77fa5ca 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/library/ShellTask.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/library/ShellTask.java
@@ -66,7 +66,7 @@ public final class ShellTask implements Task {
*/
@Override
public byte[] call(final byte[] memento) {
- String result = CommandUtils.runCommand(this.command);
+ final String result = CommandUtils.runCommand(this.command);
LOG.log(Level.INFO, result);
return CODEC.encode(result);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/Scheduler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/Scheduler.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/Scheduler.java
index 6d86af6..4677c08 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/Scheduler.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/Scheduler.java
@@ -187,7 +187,7 @@ final class Scheduler {
/**
* Add a task to the queue.
*/
- public synchronized void addTask(TaskEntity task) {
+ public synchronized void addTask(final TaskEntity task) {
taskQueue.add(task);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerDriver.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerDriver.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerDriver.java
index 23b091b..0b956de 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerDriver.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerDriver.java
@@ -77,7 +77,7 @@ public final class SchedulerDriver {
@Inject
public SchedulerDriver(final EvaluatorRequestor requestor,
- @Parameter(SchedulerREEF.Retain.class) boolean retainable,
+ @Parameter(SchedulerREEF.Retain.class) final boolean retainable,
final Scheduler scheduler) {
this.requestor = requestor;
this.scheduler = scheduler;
@@ -127,7 +127,7 @@ public final class SchedulerDriver {
*/
final class ActiveContextHandler implements EventHandler<ActiveContext> {
@Override
- public void onNext(ActiveContext context) {
+ public void onNext(final ActiveContext context) {
synchronized (SchedulerDriver.this) {
LOG.log(Level.INFO, "Context available : {0}", context.getId());
@@ -187,7 +187,7 @@ public final class SchedulerDriver {
/**
* Get the status of a task.
*/
- public SchedulerResponse getTaskStatus(List<String> args) {
+ public SchedulerResponse getTaskStatus(final List<String> args) {
if (args.size() != 1) {
return SchedulerResponse.badRequest("Usage : only one ID at a time");
}
@@ -295,7 +295,7 @@ public final class SchedulerDriver {
// Wait until any command enters in the queue
try {
SchedulerDriver.this.wait();
- } catch (InterruptedException e) {
+ } catch (final InterruptedException e) {
LOG.log(Level.WARNING, "InterruptedException occurred in SchedulerDriver", e);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerHttpHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerHttpHandler.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerHttpHandler.java
index c127b55..1a92861 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerHttpHandler.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerHttpHandler.java
@@ -48,7 +48,7 @@ final class SchedulerHttpHandler implements HttpHandler {
}
@Override
- public void setUriSpecification(String s) {
+ public void setUriSpecification(final String s) {
uriSpecification = s;
}
@@ -65,7 +65,7 @@ final class SchedulerHttpHandler implements HttpHandler {
* /clear to clear the waiting queue
*/
@Override
- public void onHttpRequest(ParsedHttpRequest request, HttpServletResponse response)
+ public void onHttpRequest(final ParsedHttpRequest request, final HttpServletResponse response)
throws IOException, ServletException {
final String target = request.getTargetEntity().toLowerCase();
final Map<String, List<String>> queryMap = request.getQueryMap();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEF.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEF.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEF.java
index c0197f3..33bb388 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEF.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEF.java
@@ -104,7 +104,7 @@ public final class SchedulerREEF {
* @param args
* @throws InjectionException
*/
- public static void main(String[] args) throws InjectionException, IOException, ParseException {
+ public static void main(final String[] args) throws InjectionException, IOException, ParseException {
final Configuration runtimeConfiguration = LocalRuntimeConfiguration.CONF
.set(LocalRuntimeConfiguration.MAX_NUMBER_OF_EVALUATORS, MAX_NUMBER_OF_EVALUATORS)
.build();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEFYarn.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEFYarn.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEFYarn.java
index b14ad56..7911f45 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEFYarn.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEFYarn.java
@@ -37,7 +37,7 @@ public final class SchedulerREEFYarn {
* @throws InjectionException
* @throws java.io.IOException
*/
- public static void main(String[] args)
+ public static void main(final String[] args)
throws InjectionException, IOException, ParseException {
final Configuration runtimeConfiguration =
YarnClientConfiguration.CONF.build();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/TaskEntity.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/TaskEntity.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/TaskEntity.java
index 42456f4..a31cdeb 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/TaskEntity.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/TaskEntity.java
@@ -44,7 +44,7 @@ final class TaskEntity {
}
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
if (this == o) {
return true;
}
@@ -52,7 +52,7 @@ final class TaskEntity {
return false;
}
- TaskEntity that = (TaskEntity) o;
+ final TaskEntity that = (TaskEntity) o;
if (taskId != that.taskId) {
return false;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/ObjectWritableCodec.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/ObjectWritableCodec.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/ObjectWritableCodec.java
index 534ca06..0c5f657 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/ObjectWritableCodec.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/ObjectWritableCodec.java
@@ -60,7 +60,7 @@ public class ObjectWritableCodec<T extends Writable> implements Codec<T> {
* @throws RemoteRuntimeException if serialization fails.
*/
@Override
- public byte[] encode(T writable) {
+ public byte[] encode(final T writable) {
try (final ByteArrayOutputStream bos = new ByteArrayOutputStream();
final DataOutputStream dos = new DataOutputStream(bos)) {
writable.write(dos);
@@ -79,7 +79,7 @@ public class ObjectWritableCodec<T extends Writable> implements Codec<T> {
* @throws RemoteRuntimeException if deserialization fails.
*/
@Override
- public T decode(byte[] buffer) {
+ public T decode(final byte[] buffer) {
try (final ByteArrayInputStream bis = new ByteArrayInputStream(buffer);
final DataInputStream dis = new DataInputStream(bis)) {
final T writable = this.writableClass.newInstance();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/SuspendTestTask.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/SuspendTestTask.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/SuspendTestTask.java
index 408c171..61120c4 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/SuspendTestTask.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/SuspendTestTask.java
@@ -167,7 +167,7 @@ public class SuspendTestTask implements Task, TaskMessageSource {
public class SuspendHandler implements EventHandler<SuspendEvent> {
@Override
- public void onNext(SuspendEvent suspendEvent) {
+ public void onNext(final SuspendEvent suspendEvent) {
final byte[] message = suspendEvent.get().get();
LOG.log(Level.INFO, "Suspend: {0} with: {1} bytes; counter: {2}",
new Object[]{this, message.length, SuspendTestTask.this.counter});
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-examples/src/main/java/org/apache/reef/examples/utils/wake/LoggingEventHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/utils/wake/LoggingEventHandler.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/utils/wake/LoggingEventHandler.java
index 690dfb2..6cb52ca 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/utils/wake/LoggingEventHandler.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/utils/wake/LoggingEventHandler.java
@@ -40,7 +40,7 @@ public class LoggingEventHandler<T> implements EventHandler<T> {
* @param downstreamEventHandler the event handler to hand the event to
* @param format Format string to log the event, e.g. "Event {0} received".
*/
- public LoggingEventHandler(EventHandler<T> downstreamEventHandler, final String format) {
+ public LoggingEventHandler(final EventHandler<T> downstreamEventHandler, final String format) {
this.downstreamEventHandler = downstreamEventHandler;
this.format = format;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/InMemoryInputFormatDataSet.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/InMemoryInputFormatDataSet.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/InMemoryInputFormatDataSet.java
index 9c58d56..aa1af48 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/InMemoryInputFormatDataSet.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/InMemoryInputFormatDataSet.java
@@ -35,7 +35,7 @@ public class InMemoryInputFormatDataSet<K extends WritableComparable<K>, V exten
private List<Pair<K, V>> recordsList = null;
@Inject
- public InMemoryInputFormatDataSet(InputFormatDataSet<K, V> inputFormatDataSet) {
+ public InMemoryInputFormatDataSet(final InputFormatDataSet<K, V> inputFormatDataSet) {
this.inputFormatDataSet = inputFormatDataSet;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/MultiDataCenterEvaluatorToPartitionStrategy.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/MultiDataCenterEvaluatorToPartitionStrategy.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/MultiDataCenterEvaluatorToPartitionStrategy.java
index 31bda53..9a17626 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/MultiDataCenterEvaluatorToPartitionStrategy.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/MultiDataCenterEvaluatorToPartitionStrategy.java
@@ -134,19 +134,20 @@ public final class MultiDataCenterEvaluatorToPartitionStrategy extends AbstractE
concurrentMap.get(location).add(numberedSplit);
}
- private String normalize(String location) {
+ private String normalize(final String location) {
+ String loc = location;
// should start with a separator
- if (!location.startsWith(PATH_SEPARATOR)) {
- location = PATH_SEPARATOR + location;
+ if (!loc.startsWith(PATH_SEPARATOR)) {
+ loc = PATH_SEPARATOR + loc;
}
// if it is just /*, return /
- if (location.equals(PATH_SEPARATOR + ANY)) {
+ if (loc.equals(PATH_SEPARATOR + ANY)) {
return PATH_SEPARATOR;
}
// remove the ending ANY or path separator
- while (location.endsWith(ANY) || location.endsWith(PATH_SEPARATOR)) {
- location = location.substring(0, location.length() - 1);
+ while (loc.endsWith(ANY) || loc.endsWith(PATH_SEPARATOR)) {
+ loc = loc.substring(0, loc.length() - 1);
}
- return location;
+ return loc;
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/WritableSerializer.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/WritableSerializer.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/WritableSerializer.java
index d50fbf3..6021d45 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/WritableSerializer.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/WritableSerializer.java
@@ -36,17 +36,17 @@ import java.io.*;
* to passed in while de-serialization
*/
public final class WritableSerializer {
- public static <E extends Writable> String serialize(E writable) {
+ public static <E extends Writable> String serialize(final E writable) {
final WritableCodec<E> writableCodec = new WritableCodec<>();
return Base64.encodeBase64String(writableCodec.encode(writable));
}
- public static <E extends Writable> E deserialize(String serializedWritable) {
+ public static <E extends Writable> E deserialize(final String serializedWritable) {
final WritableCodec<E> writableCodec = new WritableCodec<>();
return writableCodec.decode(Base64.decodeBase64(serializedWritable));
}
- public static <E extends Writable> E deserialize(String serializedWritable, JobConf jobConf) {
+ public static <E extends Writable> E deserialize(final String serializedWritable, final JobConf jobConf) {
final WritableCodec<E> writableCodec = new WritableCodec<>(jobConf);
return writableCodec.decode(Base64.decodeBase64(serializedWritable));
}
@@ -54,7 +54,7 @@ public final class WritableSerializer {
static class WritableCodec<E extends Writable> implements Codec<E> {
private final JobConf jobConf;
- public WritableCodec(JobConf jobConf) {
+ public WritableCodec(final JobConf jobConf) {
this.jobConf = jobConf;
}
@@ -63,28 +63,28 @@ public final class WritableSerializer {
}
@Override
- public E decode(byte[] bytes) {
+ public E decode(final byte[] bytes) {
final ByteArrayInputStream bais = new ByteArrayInputStream(bytes);
try (DataInputStream dais = new DataInputStream(bais)) {
final String className = dais.readUTF();
- E writable = (E) ReflectionUtils.newInstance(Class.forName(className), jobConf);
+ final E writable = (E) ReflectionUtils.newInstance(Class.forName(className), jobConf);
writable.readFields(dais);
return writable;
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new RuntimeException("Could not de-serialize JobConf", e);
- } catch (ClassNotFoundException e) {
+ } catch (final ClassNotFoundException e) {
throw new RuntimeException("Could not instantiate specific writable class", e);
}
}
@Override
- public byte[] encode(E writable) {
+ public byte[] encode(final E writable) {
final ByteArrayOutputStream baos = new ByteArrayOutputStream();
try (final DataOutputStream daos = new DataOutputStream(baos)) {
daos.writeUTF(writable.getClass().getName());
writable.write(daos);
return baos.toByteArray();
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new RuntimeException("Could not serialize JobConf", e);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/NetworkConnectionService.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/NetworkConnectionService.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/NetworkConnectionService.java
index 472e619..a7b6c10 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/NetworkConnectionService.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/NetworkConnectionService.java
@@ -47,7 +47,8 @@ import org.apache.reef.wake.remote.transport.LinkListener;
* to the corresponding EventHandler registered in the ConnectionFactory.
*/
@DefaultImplementation(NetworkConnectionServiceImpl.class)
-public interface NetworkConnectionService extends AutoCloseable {
+public interface
+ NetworkConnectionService extends AutoCloseable {
/**
* Registers an instance of ConnectionFactory corresponding to the connectionFactoryId.
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/exception/NetworkRuntimeException.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/exception/NetworkRuntimeException.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/exception/NetworkRuntimeException.java
index 8ebc7af..c52d088 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/exception/NetworkRuntimeException.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/exception/NetworkRuntimeException.java
@@ -30,7 +30,7 @@ public class NetworkRuntimeException extends RuntimeException {
* @param s the detailed message
* @param e the cause
*/
- public NetworkRuntimeException(String s, Throwable e) {
+ public NetworkRuntimeException(final String s, final Throwable e) {
super(s, e);
}
@@ -39,7 +39,7 @@ public class NetworkRuntimeException extends RuntimeException {
*
* @param s the detailed message
*/
- public NetworkRuntimeException(String s) {
+ public NetworkRuntimeException(final String s) {
super(s);
}
@@ -48,7 +48,7 @@ public class NetworkRuntimeException extends RuntimeException {
*
* @param e the cause
*/
- public NetworkRuntimeException(Throwable e) {
+ public NetworkRuntimeException(final Throwable e) {
super(e);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/driver/GroupCommDriverImpl.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/driver/GroupCommDriverImpl.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/driver/GroupCommDriverImpl.java
index 3e08b07..f87b96ee 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/driver/GroupCommDriverImpl.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/driver/GroupCommDriverImpl.java
@@ -186,7 +186,7 @@ public class GroupCommDriverImpl implements GroupCommServiceDriver {
NameResolver nameResolver = null;
try {
nameResolver = injector.getInstance(NameResolver.class);
- } catch (InjectionException e) {
+ } catch (final InjectionException e) {
throw new RuntimeException(e);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/operators/BroadcastReceiver.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/operators/BroadcastReceiver.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/operators/BroadcastReceiver.java
index a8f2237..74e9a83 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/operators/BroadcastReceiver.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/operators/BroadcastReceiver.java
@@ -133,7 +133,7 @@ public class BroadcastReceiver<T> implements Broadcast.Receiver<T>, EventHandler
final T retVal;
// Wait for parent to send
LOG.fine(this + " Waiting to receive broadcast");
- byte[] data;
+ final byte[] data;
try {
data = topology.recvFromParent();
// TODO: Should receive the identity element instead of null
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/task/NodeStructImpl.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/task/NodeStructImpl.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/task/NodeStructImpl.java
index 87ea9c5..7be3165 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/task/NodeStructImpl.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/task/NodeStructImpl.java
@@ -66,7 +66,7 @@ public abstract class NodeStructImpl implements NodeStruct {
@Override
public byte[] getData() {
LOG.entering("NodeStructImpl", "getData");
- GroupCommunicationMessage gcm;
+ final GroupCommunicationMessage gcm;
try {
gcm = dataQue.take();
} catch (final InterruptedException e) {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/task/OperatorTopologyStructImpl.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/task/OperatorTopologyStructImpl.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/task/OperatorTopologyStructImpl.java
index fb8abac..2ef12b2 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/task/OperatorTopologyStructImpl.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/task/OperatorTopologyStructImpl.java
@@ -295,7 +295,7 @@ public class OperatorTopologyStructImpl implements OperatorTopologyStruct {
while (!childrenToRcvFrom.isEmpty()) {
LOG.finest(getQualifiedName() + "Waiting for some child to send data");
- NodeStruct child;
+ final NodeStruct child;
try {
child = nodesWithData.take();
} catch (final InterruptedException e) {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NSConnection.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NSConnection.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NSConnection.java
index 4bfd0b7..efe5f0c 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NSConnection.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NSConnection.java
@@ -106,7 +106,7 @@ class NSConnection<T> implements Connection<T> {
}
@Override
- public void write(List<T> messages) {
+ public void write(final List<T> messages) {
this.link.write(new NSMessage<T>(this.srcId, this.destId, messages));
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NSMessageCodec.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NSMessageCodec.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NSMessageCodec.java
index 5a9c43e..fe3aa99 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NSMessageCodec.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NSMessageCodec.java
@@ -115,7 +115,7 @@ public class NSMessageCodec<T> implements Codec<NSMessage<T>> {
throw new RuntimeException("IOException", e);
}
} else {
- NSMessagePBuf pbuf;
+ final NSMessagePBuf pbuf;
try {
pbuf = NSMessagePBuf.parseFrom(buf);
} catch (final InvalidProtocolBufferException e) {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkConnection.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkConnection.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkConnection.java
index d2175e7..1dd775d 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkConnection.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkConnection.java
@@ -80,7 +80,7 @@ final class NetworkConnection<T> implements Connection<T> {
@Override
public String toString() {
- StringBuilder sb = new StringBuilder();
+ final StringBuilder sb = new StringBuilder();
sb.append("Connection from")
.append(connFactory.getSrcId())
.append(":")
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkConnectionServiceImpl.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkConnectionServiceImpl.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkConnectionServiceImpl.java
index f5e1f83..f24177a 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkConnectionServiceImpl.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkConnectionServiceImpl.java
@@ -143,7 +143,7 @@ public final class NetworkConnectionServiceImpl implements NetworkConnectionServ
final Codec<T> codec,
final EventHandler<Message<T>> eventHandler,
final LinkListener<Message<T>> linkListener) throws NetworkException {
- String id = connFactoryId.toString();
+ final String id = connFactoryId.toString();
if (connFactoryMap.get(id) != null) {
throw new NetworkException("ConnectionFactory " + connFactoryId + " was already registered.");
}
@@ -197,7 +197,7 @@ public final class NetworkConnectionServiceImpl implements NetworkConnectionServ
throw new NetworkException("Lookup " + destId + " is null");
}
return transport.open(address, nsCodec, nsLinkListener);
- } catch(Exception e) {
+ } catch(final Exception e) {
e.printStackTrace();
throw new NetworkException(e);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkConnectionServiceMessage.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkConnectionServiceMessage.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkConnectionServiceMessage.java
index 9ce10c1..910c1e0 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkConnectionServiceMessage.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkConnectionServiceMessage.java
@@ -101,12 +101,12 @@ final class NetworkConnectionServiceMessage<T> implements Message<T> {
* @return a string representation of this object
*/
public String toString() {
- StringBuilder builder = new StringBuilder();
+ final StringBuilder builder = new StringBuilder();
builder.append("NSMessage");
builder.append(" remoteID=");
builder.append(destId);
builder.append(" message=[| ");
- for (T message : messages) {
+ for (final T message : messages) {
builder.append(message + " |");
}
builder.append("]");
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkService.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkService.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkService.java
index 9b91aa8..c2ff93c 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkService.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkService.java
@@ -225,7 +225,7 @@ public final class NetworkService<T> implements Stage, ConnectionFactory<T> {
this.nameServiceRegisteringStage.onNext(tuple);
}
- public void unregisterId(Identifier id) {
+ public void unregisterId(final Identifier id) {
this.myId = null;
LOG.log(Level.FINEST, "Unbinding {0} to NetworkService@({1})",
new Object[]{id, this.transport.getLocalAddress()});
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkServiceClosingHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkServiceClosingHandler.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkServiceClosingHandler.java
index e73ec3b..01bacd5 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkServiceClosingHandler.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkServiceClosingHandler.java
@@ -32,10 +32,10 @@ public class NetworkServiceClosingHandler implements EventHandler<ContextStop> {
}
@Override
- public void onNext(ContextStop arg0) {
+ public void onNext(final ContextStop arg0) {
try {
networkService.close();
- } catch (Exception e) {
+ } catch (final Exception e) {
throw new RuntimeException("Exception while closing NetworkService", e);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameAssignmentTuple.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameAssignmentTuple.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameAssignmentTuple.java
index d08e72a..83b3724 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameAssignmentTuple.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameAssignmentTuple.java
@@ -37,7 +37,7 @@ public class NameAssignmentTuple implements NameAssignment {
* @param id an identifier
* @param addr an Internet socket address
*/
- public NameAssignmentTuple(Identifier id, InetSocketAddress addr) {
+ public NameAssignmentTuple(final Identifier id, final InetSocketAddress addr) {
this.id = id;
this.addr = addr;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameCache.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameCache.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameCache.java
index 52e7015..d6fbb3c 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameCache.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameCache.java
@@ -39,7 +39,7 @@ public class NameCache implements Cache<Identifier, InetSocketAddress> {
*
* @param timeout a cache entry timeout after write
*/
- public NameCache(long timeout) {
+ public NameCache(final long timeout) {
cache = new CacheImpl<>(new SystemTime(), timeout);
}
@@ -52,8 +52,8 @@ public class NameCache implements Cache<Identifier, InetSocketAddress> {
* @throws ExecutionException
*/
@Override
- public InetSocketAddress get(Identifier key,
- Callable<InetSocketAddress> valueFetcher) throws ExecutionException {
+ public InetSocketAddress get(final Identifier key,
+ final Callable<InetSocketAddress> valueFetcher) throws ExecutionException {
return cache.get(key, valueFetcher);
}
@@ -63,7 +63,7 @@ public class NameCache implements Cache<Identifier, InetSocketAddress> {
* @param key an identifier
*/
@Override
- public void invalidate(Identifier key) {
+ public void invalidate(final Identifier key) {
cache.invalidate(key);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameClient.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameClient.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameClient.java
index ecfba79..6cc8581 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameClient.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameClient.java
@@ -173,7 +173,7 @@ public final class NameClient implements NameResolver {
final LocalAddressProvider localAddressProvider,
final TransportFactory tpFactory) {
- NameCache cache = new NameCache(timeout);
+ final NameCache cache = new NameCache(timeout);
final BlockingQueue<NamingLookupResponse> replyLookupQueue = new LinkedBlockingQueue<NamingLookupResponse>();
final BlockingQueue<NamingRegisterResponse> replyRegisterQueue = new LinkedBlockingQueue<NamingRegisterResponse>();
final Codec<NamingMessage> codec = NamingCodecFactory.createFullCodec(factory);
@@ -286,14 +286,14 @@ class NamingResponseHandler implements EventHandler<NamingMessage> {
private final BlockingQueue<NamingLookupResponse> replyLookupQueue;
private final BlockingQueue<NamingRegisterResponse> replyRegisterQueue;
- NamingResponseHandler(BlockingQueue<NamingLookupResponse> replyLookupQueue,
- BlockingQueue<NamingRegisterResponse> replyRegisterQueue) {
+ NamingResponseHandler(final BlockingQueue<NamingLookupResponse> replyLookupQueue,
+ final BlockingQueue<NamingRegisterResponse> replyRegisterQueue) {
this.replyLookupQueue = replyLookupQueue;
this.replyRegisterQueue = replyRegisterQueue;
}
@Override
- public void onNext(NamingMessage value) {
+ public void onNext(final NamingMessage value) {
if (value instanceof NamingLookupResponse) {
replyLookupQueue.offer((NamingLookupResponse) value);
} else if (value instanceof NamingRegisterResponse) {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameRegistryClient.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameRegistryClient.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameRegistryClient.java
index 6270722..766a06c 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameRegistryClient.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameRegistryClient.java
@@ -96,14 +96,14 @@ public class NameRegistryClient implements Stage, NamingRegistry {
this.codec = NamingCodecFactory.createRegistryCodec(factory);
this.replyQueue = new LinkedBlockingQueue<>();
- Injector injector = Tang.Factory.getTang().newInjector();
+ final Injector injector = Tang.Factory.getTang().newInjector();
injector.bindVolatileParameter(RemoteConfiguration.HostAddress.class, localAddressProvider.getLocalAddress());
injector.bindVolatileParameter(RemoteConfiguration.RemoteClientStage.class,
new SyncStage<>(new NamingRegistryClientHandler(new NamingRegistryResponseHandler(replyQueue), codec)));
try {
this.transport = injector.getInstance(NettyMessagingTransport.class);
- } catch (InjectionException e) {
+ } catch (final InjectionException e) {
throw new RuntimeException(e);
}
}
@@ -170,8 +170,8 @@ public class NameRegistryClient implements Stage, NamingRegistry {
* @param id an identifier
*/
@Override
- public void unregister(Identifier id) throws IOException {
- Link<NamingMessage> link = transport.open(serverSocketAddr, codec,
+ public void unregister(final Identifier id) throws IOException {
+ final Link<NamingMessage> link = transport.open(serverSocketAddr, codec,
new LoggingLinkListener<NamingMessage>());
link.write(new NamingUnregisterRequest(id));
}
@@ -195,13 +195,13 @@ class NamingRegistryClientHandler implements EventHandler<TransportEvent> {
private final EventHandler<NamingRegisterResponse> handler;
private final Codec<NamingMessage> codec;
- NamingRegistryClientHandler(EventHandler<NamingRegisterResponse> handler, Codec<NamingMessage> codec) {
+ NamingRegistryClientHandler(final EventHandler<NamingRegisterResponse> handler, final Codec<NamingMessage> codec) {
this.handler = handler;
this.codec = codec;
}
@Override
- public void onNext(TransportEvent value) {
+ public void onNext(final TransportEvent value) {
LOG.log(Level.FINE, value.toString());
handler.onNext((NamingRegisterResponse) codec.decode(value.getData()));
}
@@ -214,12 +214,12 @@ class NamingRegistryResponseHandler implements EventHandler<NamingRegisterRespon
private final BlockingQueue<NamingRegisterResponse> replyQueue;
- NamingRegistryResponseHandler(BlockingQueue<NamingRegisterResponse> replyQueue) {
+ NamingRegistryResponseHandler(final BlockingQueue<NamingRegisterResponse> replyQueue) {
this.replyQueue = replyQueue;
}
@Override
- public void onNext(NamingRegisterResponse value) {
+ public void onNext(final NamingRegisterResponse value) {
replyQueue.offer(value);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameServerImpl.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameServerImpl.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameServerImpl.java
index 8fc7cae..f283de2 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameServerImpl.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameServerImpl.java
@@ -74,7 +74,7 @@ public final class NameServerImpl implements NameServer {
@Parameter(NameServerParameters.NameServerIdentifierFactory.class) final IdentifierFactory factory,
final LocalAddressProvider localAddressProvider) {
- Injector injector = Tang.Factory.getTang().newInjector();
+ final Injector injector = Tang.Factory.getTang().newInjector();
this.localAddressProvider = localAddressProvider;
this.reefEventStateManager = null;
@@ -88,7 +88,7 @@ public final class NameServerImpl implements NameServer {
try {
this.transport = injector.getInstance(NettyMessagingTransport.class);
- } catch (InjectionException e) {
+ } catch (final InjectionException e) {
throw new RuntimeException(e);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NamingCodecFactory.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NamingCodecFactory.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NamingCodecFactory.java
index 2fa0cc2..631b692 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NamingCodecFactory.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NamingCodecFactory.java
@@ -37,12 +37,12 @@ final class NamingCodecFactory {
* @param factory an identifier factory
* @return a codec
*/
- static Codec<NamingMessage> createLookupCodec(IdentifierFactory factory) {
- Map<Class<? extends NamingMessage>, Codec<? extends NamingMessage>> clazzToCodecMap
+ static Codec<NamingMessage> createLookupCodec(final IdentifierFactory factory) {
+ final Map<Class<? extends NamingMessage>, Codec<? extends NamingMessage>> clazzToCodecMap
= new HashMap<Class<? extends NamingMessage>, Codec<? extends NamingMessage>>();
clazzToCodecMap.put(NamingLookupRequest.class, new NamingLookupRequestCodec(factory));
clazzToCodecMap.put(NamingLookupResponse.class, new NamingLookupResponseCodec(factory));
- Codec<NamingMessage> codec = new MultiCodec<NamingMessage>(clazzToCodecMap);
+ final Codec<NamingMessage> codec = new MultiCodec<NamingMessage>(clazzToCodecMap);
return codec;
}
@@ -52,14 +52,14 @@ final class NamingCodecFactory {
* @param factory an identifier factory
* @return a codec
*/
- static Codec<NamingMessage> createRegistryCodec(IdentifierFactory factory) {
- Map<Class<? extends NamingMessage>, Codec<? extends NamingMessage>> clazzToCodecMap
+ static Codec<NamingMessage> createRegistryCodec(final IdentifierFactory factory) {
+ final Map<Class<? extends NamingMessage>, Codec<? extends NamingMessage>> clazzToCodecMap
= new HashMap<Class<? extends NamingMessage>, Codec<? extends NamingMessage>>();
clazzToCodecMap.put(NamingRegisterRequest.class, new NamingRegisterRequestCodec(factory));
clazzToCodecMap.put(NamingRegisterResponse.class,
new NamingRegisterResponseCodec(new NamingRegisterRequestCodec(factory)));
clazzToCodecMap.put(NamingUnregisterRequest.class, new NamingUnregisterRequestCodec(factory));
- Codec<NamingMessage> codec = new MultiCodec<NamingMessage>(clazzToCodecMap);
+ final Codec<NamingMessage> codec = new MultiCodec<NamingMessage>(clazzToCodecMap);
return codec;
}
@@ -69,8 +69,8 @@ final class NamingCodecFactory {
* @param factory an identifier factory
* @return a codec
*/
- static Codec<NamingMessage> createFullCodec(IdentifierFactory factory) {
- Map<Class<? extends NamingMessage>, Codec<? extends NamingMessage>> clazzToCodecMap
+ static Codec<NamingMessage> createFullCodec(final IdentifierFactory factory) {
+ final Map<Class<? extends NamingMessage>, Codec<? extends NamingMessage>> clazzToCodecMap
= new HashMap<Class<? extends NamingMessage>, Codec<? extends NamingMessage>>();
clazzToCodecMap.put(NamingLookupRequest.class, new NamingLookupRequestCodec(factory));
clazzToCodecMap.put(NamingLookupResponse.class, new NamingLookupResponseCodec(factory));
@@ -78,7 +78,7 @@ final class NamingCodecFactory {
clazzToCodecMap.put(NamingRegisterResponse.class,
new NamingRegisterResponseCodec(new NamingRegisterRequestCodec(factory)));
clazzToCodecMap.put(NamingUnregisterRequest.class, new NamingUnregisterRequestCodec(factory));
- Codec<NamingMessage> codec = new MultiCodec<NamingMessage>(clazzToCodecMap);
+ final Codec<NamingMessage> codec = new MultiCodec<NamingMessage>(clazzToCodecMap);
return codec;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/exception/NamingException.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/exception/NamingException.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/exception/NamingException.java
index a64dbc0..f58f1d0 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/exception/NamingException.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/exception/NamingException.java
@@ -32,7 +32,7 @@ public class NamingException extends NetworkException {
* @param s the detailed message
* @param e the cause
*/
- public NamingException(String s, Throwable e) {
+ public NamingException(final String s, final Throwable e) {
super(s, e);
}
@@ -41,7 +41,7 @@ public class NamingException extends NetworkException {
*
* @param s the detailed message
*/
- public NamingException(String s) {
+ public NamingException(final String s) {
super(s);
}
@@ -50,7 +50,7 @@ public class NamingException extends NetworkException {
*
* @param e the cause
*/
- public NamingException(Throwable e) {
+ public NamingException(final Throwable e) {
super(e);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/exception/NamingRuntimeException.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/exception/NamingRuntimeException.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/exception/NamingRuntimeException.java
index 840df5f..383d05a 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/exception/NamingRuntimeException.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/exception/NamingRuntimeException.java
@@ -32,7 +32,7 @@ public class NamingRuntimeException extends NetworkRuntimeException {
* @param s the detailed message
* @param e the cause
*/
- public NamingRuntimeException(String s, Throwable e) {
+ public NamingRuntimeException(final String s, final Throwable e) {
super(s, e);
}
@@ -41,7 +41,7 @@ public class NamingRuntimeException extends NetworkRuntimeException {
*
* @param s the detailed message
*/
- public NamingRuntimeException(String s) {
+ public NamingRuntimeException(final String s) {
super(s);
}
@@ -50,7 +50,7 @@ public class NamingRuntimeException extends NetworkRuntimeException {
*
* @param e the cause
*/
- public NamingRuntimeException(Throwable e) {
+ public NamingRuntimeException(final Throwable e) {
super(e);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/AvroUtils.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/AvroUtils.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/AvroUtils.java
index ce9bcc5..4664057 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/AvroUtils.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/AvroUtils.java
@@ -41,7 +41,7 @@ final class AvroUtils {
* @param <T>
* @return
*/
- static <T> byte[] toBytes(T avroObject, Class<T> theClass) {
+ static <T> byte[] toBytes(final T avroObject, final Class<T> theClass) {
final DatumWriter<T> datumWriter = new SpecificDatumWriter<>(theClass);
final byte[] theBytes;
try (final ByteArrayOutputStream out = new ByteArrayOutputStream()) {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingLookupRequest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingLookupRequest.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingLookupRequest.java
index d826a1b..ee80eb1 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingLookupRequest.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingLookupRequest.java
@@ -31,7 +31,7 @@ public class NamingLookupRequest extends NamingMessage {
*
* @param ids the iterable of identifiers
*/
- public NamingLookupRequest(Iterable<Identifier> ids) {
+ public NamingLookupRequest(final Iterable<Identifier> ids) {
this.ids = ids;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingLookupResponse.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingLookupResponse.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingLookupResponse.java
index 6855299..0d27a3d 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingLookupResponse.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingLookupResponse.java
@@ -33,7 +33,7 @@ public class NamingLookupResponse extends NamingMessage {
*
* @param nas the list of name assignments
*/
- public NamingLookupResponse(List<NameAssignment> nas) {
+ public NamingLookupResponse(final List<NameAssignment> nas) {
this.nas = nas;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingLookupResponseCodec.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingLookupResponseCodec.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingLookupResponseCodec.java
index a9787af..aa40d3a 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingLookupResponseCodec.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingLookupResponseCodec.java
@@ -54,7 +54,7 @@ public final class NamingLookupResponseCodec implements Codec<NamingLookupRespon
* @return a byte array
*/
@Override
- public byte[] encode(NamingLookupResponse obj) {
+ public byte[] encode(final NamingLookupResponse obj) {
final List<AvroNamingAssignment> assignments = new ArrayList<>(obj.getNameAssignments().size());
for (final NameAssignment nameAssignment : obj.getNameAssignments()) {
assignments.add(AvroNamingAssignment.newBuilder()
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingMessage.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingMessage.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingMessage.java
index 2eb4425..e4afb4e 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingMessage.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingMessage.java
@@ -40,7 +40,7 @@ public abstract class NamingMessage {
*
* @param link the link
*/
- public void setLink(Link<byte[]> link) {
+ public void setLink(final Link<byte[]> link) {
this.link = link;
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterRequest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterRequest.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterRequest.java
index 443b349..a032536 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterRequest.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterRequest.java
@@ -31,7 +31,7 @@ public class NamingRegisterRequest extends NamingMessage {
*
* @param na the name assignment
*/
- public NamingRegisterRequest(NameAssignment na) {
+ public NamingRegisterRequest(final NameAssignment na) {
this.na = na;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterRequestCodec.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterRequestCodec.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterRequestCodec.java
index 18a979f..011c16d 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterRequestCodec.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterRequestCodec.java
@@ -37,7 +37,7 @@ public class NamingRegisterRequestCodec implements Codec<NamingRegisterRequest>
*
* @param factory the identifier factory
*/
- public NamingRegisterRequestCodec(IdentifierFactory factory) {
+ public NamingRegisterRequestCodec(final IdentifierFactory factory) {
this.factory = factory;
}
@@ -48,7 +48,7 @@ public class NamingRegisterRequestCodec implements Codec<NamingRegisterRequest>
* @return a byte array
*/
@Override
- public byte[] encode(NamingRegisterRequest obj) {
+ public byte[] encode(final NamingRegisterRequest obj) {
final AvroNamingRegisterRequest result = AvroNamingRegisterRequest.newBuilder()
.setId(obj.getNameAssignment().getIdentifier().toString())
.setHost(obj.getNameAssignment().getAddress().getHostName())
@@ -65,7 +65,7 @@ public class NamingRegisterRequestCodec implements Codec<NamingRegisterRequest>
* @throws org.apache.reef.io.network.naming.exception.NamingRuntimeException
*/
@Override
- public NamingRegisterRequest decode(byte[] buf) {
+ public NamingRegisterRequest decode(final byte[] buf) {
final AvroNamingRegisterRequest avroNamingRegisterRequest =
AvroUtils.fromBytes(buf, AvroNamingRegisterRequest.class);
return new NamingRegisterRequest(
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterResponse.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterResponse.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterResponse.java
index 4737d4d..e1c07ce 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterResponse.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterResponse.java
@@ -29,7 +29,7 @@ public class NamingRegisterResponse extends NamingMessage {
*
* @param request the naming register request
*/
- public NamingRegisterResponse(NamingRegisterRequest request) {
+ public NamingRegisterResponse(final NamingRegisterRequest request) {
this.request = request;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterResponseCodec.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterResponseCodec.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterResponseCodec.java
index f71c75b..228a748 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterResponseCodec.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterResponseCodec.java
@@ -31,7 +31,7 @@ public class NamingRegisterResponseCodec implements Codec<NamingRegisterResponse
*
* @param codec the naming register request codec
*/
- public NamingRegisterResponseCodec(NamingRegisterRequestCodec codec) {
+ public NamingRegisterResponseCodec(final NamingRegisterRequestCodec codec) {
this.codec = codec;
}
@@ -42,7 +42,7 @@ public class NamingRegisterResponseCodec implements Codec<NamingRegisterResponse
* @return bytes a byte array
*/
@Override
- public byte[] encode(NamingRegisterResponse obj) {
+ public byte[] encode(final NamingRegisterResponse obj) {
return codec.encode(obj.getRequest());
}
@@ -53,7 +53,7 @@ public class NamingRegisterResponseCodec implements Codec<NamingRegisterResponse
* @return a naming register response
*/
@Override
- public NamingRegisterResponse decode(byte[] buf) {
+ public NamingRegisterResponse decode(final byte[] buf) {
return new NamingRegisterResponse(codec.decode(buf));
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingUnregisterRequest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingUnregisterRequest.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingUnregisterRequest.java
index 6e3ff44..8a238d9 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingUnregisterRequest.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingUnregisterRequest.java
@@ -31,7 +31,7 @@ public class NamingUnregisterRequest extends NamingMessage {
*
* @param id the identifier
*/
- public NamingUnregisterRequest(Identifier id) {
+ public NamingUnregisterRequest(final Identifier id) {
this.id = id;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingUnregisterRequestCodec.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingUnregisterRequestCodec.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingUnregisterRequestCodec.java
index cf0858a..f220cd2 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingUnregisterRequestCodec.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingUnregisterRequestCodec.java
@@ -48,7 +48,7 @@ public final class NamingUnregisterRequestCodec implements Codec<NamingUnregiste
* @return a byte array
*/
@Override
- public byte[] encode(NamingUnregisterRequest obj) {
+ public byte[] encode(final NamingUnregisterRequest obj) {
final AvroNamingUnRegisterRequest result = AvroNamingUnRegisterRequest.newBuilder()
.setId(obj.getIdentifier().toString())
.build();
@@ -63,7 +63,7 @@ public final class NamingUnregisterRequestCodec implements Codec<NamingUnregiste
* @throws org.apache.reef.io.network.naming.exception.NamingRuntimeException
*/
@Override
- public NamingUnregisterRequest decode(byte[] buf) {
+ public NamingUnregisterRequest decode(final byte[] buf) {
final AvroNamingUnRegisterRequest result = AvroUtils.fromBytes(buf, AvroNamingUnRegisterRequest.class);
return new NamingUnregisterRequest(factory.getNewInstance(result.getId().toString()));
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/util/StringCodec.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/util/StringCodec.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/util/StringCodec.java
index 70d6a41..5bf4685 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/util/StringCodec.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/util/StringCodec.java
@@ -31,12 +31,12 @@ public class StringCodec implements Codec<String> {
}
@Override
- public byte[] encode(String obj) {
+ public byte[] encode(final String obj) {
return obj.getBytes();
}
@Override
- public String decode(byte[] buf) {
+ public String decode(final byte[] buf) {
return new String(buf);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/util/StringIdentifier.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/util/StringIdentifier.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/util/StringIdentifier.java
index f8da208..c2de9d0 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/util/StringIdentifier.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/util/StringIdentifier.java
@@ -33,7 +33,7 @@ public class StringIdentifier implements ComparableIdentifier {
*
* @param str a string
*/
- StringIdentifier(String str) {
+ StringIdentifier(final String str) {
this.str = str;
}
@@ -52,7 +52,7 @@ public class StringIdentifier implements ComparableIdentifier {
* @param o another object
* @return true if the object is the same as the object argument; false, otherwise
*/
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
return str.equals(((StringIdentifier) o).toString());
}
@@ -66,7 +66,7 @@ public class StringIdentifier implements ComparableIdentifier {
}
@Override
- public int compareTo(Identifier o) {
+ public int compareTo(final Identifier o) {
if (o == null) {
if (str == null) {
return 0;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/util/StringIdentifierFactory.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/util/StringIdentifierFactory.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/util/StringIdentifierFactory.java
index cc51d21..708a309 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/util/StringIdentifierFactory.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/util/StringIdentifierFactory.java
@@ -39,7 +39,7 @@ public class StringIdentifierFactory implements IdentifierFactory {
* @return a string identifier
*/
@Override
- public Identifier getNewInstance(String s) {
+ public Identifier getNewInstance(final String s) {
return new StringIdentifier(s);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/FramingInputStream.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/FramingInputStream.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/FramingInputStream.java
index 2a96662..664e5a5 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/FramingInputStream.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/FramingInputStream.java
@@ -27,16 +27,16 @@ import java.util.Iterator;
public class FramingInputStream extends DataInputStream implements Iterable<byte[]> {
- public FramingInputStream(InputStream in) {
+ public FramingInputStream(final InputStream in) {
super(in);
}
public byte[] readFrame() throws IOException {
- int i = readInt();
+ final int i = readInt();
if (i == -1) {
return null;
}
- byte[] b = new byte[i];
+ final byte[] b = new byte[i];
readFully(b);
return b;
}
@@ -54,10 +54,10 @@ public class FramingInputStream extends DataInputStream implements Iterable<byte
@Override
public byte[] next() {
- byte[] ret = cur;
+ final byte[] ret = cur;
try {
cur = readFrame();
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new ServiceRuntimeException(e);
}
return ret;
@@ -68,7 +68,7 @@ public class FramingInputStream extends DataInputStream implements Iterable<byte
throw new UnsupportedOperationException();
}
};
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new ServiceRuntimeException(e);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/FramingOutputStream.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/FramingOutputStream.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/FramingOutputStream.java
index 26013fa..28f6916 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/FramingOutputStream.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/FramingOutputStream.java
@@ -35,7 +35,7 @@ public class FramingOutputStream extends OutputStream implements Accumulable<byt
private long offset;
private boolean closed;
- public FramingOutputStream(OutputStream o) {
+ public FramingOutputStream(final OutputStream o) {
if (!(o instanceof DataOutputStream)) {
this.o = new DataOutputStream(o);
} else {
@@ -50,7 +50,7 @@ public class FramingOutputStream extends OutputStream implements Accumulable<byt
offset += 4;
baos.writeTo(o);
baos.reset();
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new StorageException(e);
}
}
@@ -60,19 +60,19 @@ public class FramingOutputStream extends OutputStream implements Accumulable<byt
}
@Override
- public void write(int b) throws IOException {
+ public void write(final int b) throws IOException {
baos.write(b);
offset++;
}
@Override
- public void write(byte[] b) throws IOException {
+ public void write(final byte[] b) throws IOException {
baos.write(b);
this.offset += b.length;
}
@Override
- public void write(byte[] b, int offsetToWrite, int length) throws IOException {
+ public void write(final byte[] b, final int offsetToWrite, final int length) throws IOException {
baos.write(b, offsetToWrite, length);
this.offset += length;
}
@@ -89,7 +89,7 @@ public class FramingOutputStream extends OutputStream implements Accumulable<byt
if (this.offset > 0) {
nextFrame();
}
- } catch (StorageException e) {
+ } catch (final StorageException e) {
throw (IOException) e.getCause();
}
o.writeInt(-1);
@@ -105,13 +105,13 @@ public class FramingOutputStream extends OutputStream implements Accumulable<byt
return new Accumulator<byte[]>() {
@Override
- public void add(byte[] datum) throws ServiceException {
+ public void add(final byte[] datum) throws ServiceException {
try {
o.writeInt(datum.length);
offset += 4;
o.write(datum);
offset += datum.length;
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new ServiceException(e);
}
@@ -124,7 +124,7 @@ public class FramingOutputStream extends OutputStream implements Accumulable<byt
offset += 4;
o.close();
fos.closed = true;
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new ServiceException(e);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/FramingTupleDeserializer.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/FramingTupleDeserializer.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/FramingTupleDeserializer.java
index f138024..eeb28ec 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/FramingTupleDeserializer.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/FramingTupleDeserializer.java
@@ -35,14 +35,14 @@ public class FramingTupleDeserializer<K, V> implements
private final Deserializer<K, InputStream> keyDeserializer;
private final Deserializer<V, InputStream> valDeserializer;
- public FramingTupleDeserializer(Deserializer<K, InputStream> keyDeserializer,
- Deserializer<V, InputStream> valDeserializer) {
+ public FramingTupleDeserializer(final Deserializer<K, InputStream> keyDeserializer,
+ final Deserializer<V, InputStream> valDeserializer) {
this.keyDeserializer = keyDeserializer;
this.valDeserializer = valDeserializer;
}
@Override
- public Iterable<Tuple<K, V>> create(InputStream ins) {
+ public Iterable<Tuple<K, V>> create(final InputStream ins) {
final DataInputStream in = new DataInputStream(ins);
final Iterable<K> keyItbl = keyDeserializer.create(in);
final Iterable<V> valItbl = valDeserializer.create(in);
@@ -57,7 +57,7 @@ public class FramingTupleDeserializer<K, V> implements
private int readFrameLength() throws ServiceException {
try {
return in.readInt();
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new ServiceRuntimeException(e);
}
}
@@ -75,12 +75,12 @@ public class FramingTupleDeserializer<K, V> implements
if (nextFrameLength == -1) {
throw new NoSuchElementException();
}
- K k = keyIt.next();
+ final K k = keyIt.next();
readFrameLength();
- V v = valIt.next();
+ final V v = valIt.next();
nextFrameLength = readFrameLength();
return new Tuple<>(k, v);
- } catch (ServiceException e) {
+ } catch (final ServiceException e) {
throw new ServiceRuntimeException(e);
}
}
@@ -90,7 +90,7 @@ public class FramingTupleDeserializer<K, V> implements
throw new UnsupportedOperationException();
}
};
- } catch (ServiceException e) {
+ } catch (final ServiceException e) {
throw new ServiceRuntimeException(e);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/FramingTupleSerializer.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/FramingTupleSerializer.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/FramingTupleSerializer.java
index a494463..a6cd0ad 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/FramingTupleSerializer.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/FramingTupleSerializer.java
@@ -58,7 +58,7 @@ public class FramingTupleSerializer<K, V> implements
boolean first = true;
@Override
- public void add(Tuple<K, V> datum) throws ServiceException {
+ public void add(final Tuple<K, V> datum) throws ServiceException {
if (!first) {
faos.nextFrame();
}
@@ -74,7 +74,7 @@ public class FramingTupleSerializer<K, V> implements
keyAccumulator.close();
valAccumulator.close();
faos.close();
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new StorageException(e);
}
}