[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #811: feat: support etcd username&&password

[GitBox <gi...@apache.org>]

juzhiyuan commented on a change in pull request #811:
URL: https://github.com/apache/apisix-dashboard/pull/811#discussion_r524846125



##########
File path: api/conf/conf.yaml
##########
@@ -22,6 +22,8 @@ conf:
   etcd:
     endpoints: # supports defining multiple etcd host addresses for an etcd cluster
       - 127.0.0.1:2379
+    username: ""

Review comment:
       if we use an empty string here, does it mean we could connect ETCD anonymously?

##########
File path: api/internal/core/storage/etcd.go
##########
@@ -32,11 +32,16 @@ var (
 type EtcdV3Storage struct {
 }
 
-func InitETCDClient(endpoints []string) error {
-	cli, err := clientv3.New(clientv3.Config{
+func InitETCDClient(endpoints []string, username, password string) error {

Review comment:
       if we set typing for username?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org