You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/08/19 07:34:36 UTC
[GitHub] [orc] guiyanakuang opened a new pull request #874: Provide better error information when parsing json files with exceptions
guiyanakuang opened a new pull request #874:
URL: https://github.com/apache/orc/pull/874
<!--
Thanks for sending a pull request! Here are some tips for you:
1. File a JIRA issue first and use it as a prefix of your PR title, e.g., `ORC-001: Fix ABC`.
2. Use your PR title to summarize what this PR proposes instead of describing the problem.
3. Make PR title and description complete because these will be the permanent commit log.
4. If possible, provide a concise and reproducible example to reproduce the issue for a faster review.
5. If the PR is unfinished, use GitHub PR Draft feature.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If there is a discussion in the mailing list, please add the link.
-->
Catching exceptions and printing messages.
1. Special prompt for empty file
2. Prompt for which file is being processed
3. Prompt for which record is being processed
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Provide more valid information.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Pass the CIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] guiyanakuang commented on a change in pull request #874: ORC-871: Provide better error information when parsing json files with exceptions
Posted by GitBox <gi...@apache.org>.
guiyanakuang commented on a change in pull request #874:
URL: https://github.com/apache/orc/pull/874#discussion_r692288342
##########
File path: java/tools/src/java/org/apache/orc/tools/json/JsonSchemaFinder.java
##########
@@ -247,15 +249,41 @@ public void addFile(String filename) throws IOException {
} else {
reader = new InputStreamReader(inputStream, StandardCharsets.UTF_8);
}
- addFile(reader);
+ addFile(reader, filename);
}
- public void addFile(java.io.Reader reader) throws IOException {
+ public void addFile(java.io.Reader reader, String filename) {
JsonStreamParser parser = new JsonStreamParser(reader);
- while (parser.hasNext()) {
- records += 1;
- mergedType = mergeType(mergedType, pickType(parser.next()));
+ try {
+ while (parser.hasNext()) {
+ mergedType = mergeType(mergedType, pickType(parser.next()));
+ records += 1;
+ }
+ } catch (JsonParseException e) {
+ printParseExceptionMsg(e, filename);
+ }
+ }
+
+ private void printParseExceptionMsg(JsonParseException e, String filename) {
+ System.err.printf(
+ "A JsonParseException was thrown while processing the %dth record of file %s.%n",
+ records + 1, filename);
+
+ String pattern = "at line (\\d+) column (\\d+)";
+ Pattern r = Pattern.compile(pattern);
+ Matcher m = r.matcher(e.getMessage());
+ int line;
+ int column;
+ if (m.find( )) {
+ line = Integer.parseInt(m.group(1));
+ column = Integer.parseInt(m.group(2));
+ if (line == 1 && column == 1) {
+ System.err.printf("File %s is empty.", filename);
Review comment:
c4599399a0a1f812b0068b87bdf409ae4f021d95 I fixed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun merged pull request #874: ORC-871: Provide better error information when parsing json files with exceptions
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #874:
URL: https://github.com/apache/orc/pull/874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #874: ORC-871: Provide better error information when parsing json files with exceptions
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #874:
URL: https://github.com/apache/orc/pull/874#issuecomment-902054957
I backported this to branch-1.7 for Apache ORC 1.7.0, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on a change in pull request #874: ORC-871: Provide better error information when parsing json files with exceptions
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #874:
URL: https://github.com/apache/orc/pull/874#discussion_r692265967
##########
File path: java/tools/src/java/org/apache/orc/tools/json/JsonSchemaFinder.java
##########
@@ -247,15 +249,41 @@ public void addFile(String filename) throws IOException {
} else {
reader = new InputStreamReader(inputStream, StandardCharsets.UTF_8);
}
- addFile(reader);
+ addFile(reader, filename);
}
- public void addFile(java.io.Reader reader) throws IOException {
+ public void addFile(java.io.Reader reader, String filename) {
JsonStreamParser parser = new JsonStreamParser(reader);
- while (parser.hasNext()) {
- records += 1;
- mergedType = mergeType(mergedType, pickType(parser.next()));
+ try {
+ while (parser.hasNext()) {
+ mergedType = mergeType(mergedType, pickType(parser.next()));
+ records += 1;
+ }
+ } catch (JsonParseException e) {
+ printParseExceptionMsg(e, filename);
+ }
+ }
+
+ private void printParseExceptionMsg(JsonParseException e, String filename) {
+ System.err.printf(
+ "A JsonParseException was thrown while processing the %dth record of file %s.%n",
+ records + 1, filename);
+
+ String pattern = "at line (\\d+) column (\\d+)";
+ Pattern r = Pattern.compile(pattern);
+ Matcher m = r.matcher(e.getMessage());
+ int line;
+ int column;
+ if (m.find( )) {
+ line = Integer.parseInt(m.group(1));
+ column = Integer.parseInt(m.group(2));
+ if (line == 1 && column == 1) {
+ System.err.printf("File %s is empty.", filename);
Review comment:
Please add a new line at the end.
```
- System.err.printf("File %s is empty.", filename);
+ System.err.printf("File %s is empty.\n", filename);
```
Otherwise, it looks like the following.
```
$ java -jar tools/target/orc-tools-1.8.0-SNAPSHOT-uber.jar json-schema ~/empty.json
Reading file /Users/dongjoon/empty.json
A JsonParseException was thrown while processing the 1th record of file /Users/dongjoon/empty.json.
File /Users/dongjoon/empty.json is empty.%
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org