You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2023/01/04 08:59:50 UTC

[GitHub] [airflow] dstandish commented on pull request #28716: Don't call get_connection from provide_bucket_name

dstandish commented on PR #28716:
URL: https://github.com/apache/airflow/pull/28716#issuecomment-1370640948

   > > @Taragolis any reason not to add schema to the wrapper?
   > 
   > No problem to add this parameter to wrapper. Initially every Hook which use aws_conn did not use it directly or this undocumented feature.
   > 
   > I think better (long term solution) is create some aws-service specific parameter - dictionary where key is aws service and use it for this config, e.g. S3 Bucket or EMR Cluster config or endpoint_url for specific host.
   > 
   > But for now it is fine to just add it to schema name.
   
   Cool. Thanks. if you don't have any concerns perhaps you can give this one a thumbs up


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org