[GitHub] matthiasblaesing commented on issue #535: [NETBEANS-519] Bump Eclipse JGit dependency to latest version

[GitBox <gi...@apache.org>]

matthiasblaesing commented on issue #535: [NETBEANS-519] Bump Eclipse JGit dependency to latest version
URL: https://github.com/apache/incubator-netbeans/pull/535#issuecomment-387170551
 
 
   Sorry - this still breaks the unittests. I switched to your branch and build from source (run `ant` from the base directory of the repository) and the I changed into the `libs.git` directory and ran `ant test`. All tests fail:
   
   ```
      [junit] Null Test: 	Caused an ERROR
       [junit] Invalid signature file digest for Manifest main attributes
       [junit] java.lang.SecurityException: Invalid signature file digest for Manifest main attributes
       [junit] 	at sun.security.util.SignatureFileVerifier.processImpl(SignatureFileVerifier.java:330)
       [junit] 	at sun.security.util.SignatureFileVerifier.process(SignatureFileVerifier.java:263)
       [junit] 	at java.util.jar.JarVerifier.processEntry(JarVerifier.java:275)
       [junit] 	at java.util.jar.JarVerifier.update(JarVerifier.java:230)
       [junit] 	at java.util.jar.JarFile.initializeVerifier(JarFile.java:383)
       [junit] 	at java.util.jar.JarFile.getInputStream(JarFile.java:450)
       [junit] 	at sun.misc.URLClassPath$JarLoader$2.getInputStream(URLClassPath.java:977)
       [junit] 	at sun.misc.Resource.cachedInputStream(Resource.java:77)
       [junit] 	at sun.misc.Resource.getByteBuffer(Resource.java:160)
       [junit] 	at java.net.URLClassLoader.defineClass(URLClassLoader.java:454)
       [junit] 	at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
       [junit] 	at java.net.URLClassLoader$1.run(URLClassLoader.java:368)
       [junit] 	at java.net.URLClassLoader$1.run(URLClassLoader.java:362)
       [junit] 	at java.security.AccessController.doPrivileged(Native Method)
       [junit] 	at java.net.URLClassLoader.findClass(URLClassLoader.java:361)
       [junit] 	at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
       [junit] 	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:338)
       [junit] 	at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
       [junit] 	at java.lang.Class.forName0(Native Method)
       [junit] 	at java.lang.Class.forName(Class.java:264)
       [junit] 
       [junit] 
       [junit] Test org.netbeans.libs.git.jgit.commands.CherryPickTest FAILED
       [junit] Testsuite: org.netbeans.libs.git.jgit.commands.CleanTest
       [junit] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0 sec
   ```
   
   You need to strip the `*.SF` and `*.RSA` files from the META-INF directory. Please have a look at the `com.jcraft.jsch` module. There OSGI meta data is added to the plain jar. Maybe this would be an alternative way.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists