You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Dave Brosius (JIRA)" <ji...@apache.org> on 2008/06/09 19:53:00 UTC
[jira] Created: (CAMEL-597) [patch] faulty ctor initialization
[patch] faulty ctor initialization
----------------------------------
Key: CAMEL-597
URL: https://issues.apache.org/activemq/browse/CAMEL-597
Project: Apache Camel
Issue Type: Bug
Components: camel-jms
Affects Versions: 1.3.0
Reporter: Dave Brosius
Priority: Minor
Fix For: 1.4.0
Attachments: faulty_ctor_initialization.patch
JmsQueueEndpoint has faulty initialization logic, checking a parameter and if null, setting that parameter. The code should be setting the member variable instead.
Code was
public JmsQueueEndpoint(String uri, JmsComponent component, String destination,
JmsConfiguration configuration, QueueBrowseStrategy queueBrowseStrategy) {
super(uri, component, destination, false, configuration);
this.queueBrowseStrategy = queueBrowseStrategy;
if (queueBrowseStrategy == null) {
queueBrowseStrategy = createQueueBrowseStrategy();
}
}
patch fixes this (two places)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-597) [patch] faulty ctor initialization
Posted by "Dave Brosius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Brosius updated CAMEL-597:
-------------------------------
Attachment: faulty_ctor_initialization.patch
> [patch] faulty ctor initialization
> ----------------------------------
>
> Key: CAMEL-597
> URL: https://issues.apache.org/activemq/browse/CAMEL-597
> Project: Apache Camel
> Issue Type: Bug
> Components: camel-jms
> Affects Versions: 1.3.0
> Reporter: Dave Brosius
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 1.4.0
>
> Attachments: faulty_ctor_initialization.patch, faulty_ctor_initialization.patch
>
>
> JmsQueueEndpoint has faulty initialization logic, checking a parameter and if null, setting that parameter. The code should be setting the member variable instead.
> Code was
> public JmsQueueEndpoint(String uri, JmsComponent component, String destination,
> JmsConfiguration configuration, QueueBrowseStrategy queueBrowseStrategy) {
> super(uri, component, destination, false, configuration);
> this.queueBrowseStrategy = queueBrowseStrategy;
> if (queueBrowseStrategy == null) {
> queueBrowseStrategy = createQueueBrowseStrategy();
> }
> }
>
> patch fixes this (two places)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CAMEL-597) [patch] faulty ctor initialization
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen reassigned CAMEL-597:
---------------------------------
Assignee: Claus Ibsen
> [patch] faulty ctor initialization
> ----------------------------------
>
> Key: CAMEL-597
> URL: https://issues.apache.org/activemq/browse/CAMEL-597
> Project: Apache Camel
> Issue Type: Bug
> Components: camel-jms
> Affects Versions: 1.3.0
> Reporter: Dave Brosius
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 1.4.0
>
> Attachments: faulty_ctor_initialization.patch
>
>
> JmsQueueEndpoint has faulty initialization logic, checking a parameter and if null, setting that parameter. The code should be setting the member variable instead.
> Code was
> public JmsQueueEndpoint(String uri, JmsComponent component, String destination,
> JmsConfiguration configuration, QueueBrowseStrategy queueBrowseStrategy) {
> super(uri, component, destination, false, configuration);
> this.queueBrowseStrategy = queueBrowseStrategy;
> if (queueBrowseStrategy == null) {
> queueBrowseStrategy = createQueueBrowseStrategy();
> }
> }
>
> patch fixes this (two places)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CAMEL-597) [patch] faulty ctor initialization
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen resolved CAMEL-597.
-------------------------------
Resolution: Fixed
Applied patch with thanks to Dave.
> [patch] faulty ctor initialization
> ----------------------------------
>
> Key: CAMEL-597
> URL: https://issues.apache.org/activemq/browse/CAMEL-597
> Project: Apache Camel
> Issue Type: Bug
> Components: camel-jms
> Affects Versions: 1.3.0
> Reporter: Dave Brosius
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 1.4.0
>
> Attachments: faulty_ctor_initialization.patch
>
>
> JmsQueueEndpoint has faulty initialization logic, checking a parameter and if null, setting that parameter. The code should be setting the member variable instead.
> Code was
> public JmsQueueEndpoint(String uri, JmsComponent component, String destination,
> JmsConfiguration configuration, QueueBrowseStrategy queueBrowseStrategy) {
> super(uri, component, destination, false, configuration);
> this.queueBrowseStrategy = queueBrowseStrategy;
> if (queueBrowseStrategy == null) {
> queueBrowseStrategy = createQueueBrowseStrategy();
> }
> }
>
> patch fixes this (two places)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-597) [patch] faulty ctor initialization
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43348#action_43348 ]
Claus Ibsen commented on CAMEL-597:
-----------------------------------
Dave you have to remember to add the file after your create the ticket as you could then tick off "grant ASF rights" = so the is an Apache icon on the file attachment.
Could you reattch the file so the ASF license is in order?
> [patch] faulty ctor initialization
> ----------------------------------
>
> Key: CAMEL-597
> URL: https://issues.apache.org/activemq/browse/CAMEL-597
> Project: Apache Camel
> Issue Type: Bug
> Components: camel-jms
> Affects Versions: 1.3.0
> Reporter: Dave Brosius
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 1.4.0
>
> Attachments: faulty_ctor_initialization.patch
>
>
> JmsQueueEndpoint has faulty initialization logic, checking a parameter and if null, setting that parameter. The code should be setting the member variable instead.
> Code was
> public JmsQueueEndpoint(String uri, JmsComponent component, String destination,
> JmsConfiguration configuration, QueueBrowseStrategy queueBrowseStrategy) {
> super(uri, component, destination, false, configuration);
> this.queueBrowseStrategy = queueBrowseStrategy;
> if (queueBrowseStrategy == null) {
> queueBrowseStrategy = createQueueBrowseStrategy();
> }
> }
>
> patch fixes this (two places)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.