You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/08/02 06:58:27 UTC

[GitHub] [spark] gengliangwang commented on a change in pull request #33607: [SPARK-36175][SQL][FOLLOWUP] Improve the comments for AvroDeserializer/AvroSerializer

gengliangwang commented on a change in pull request #33607:
URL: https://github.com/apache/spark/pull/33607#discussion_r680700678



##########
File path: external/avro/src/main/scala/org/apache/spark/sql/avro/AvroDeserializer.scala
##########
@@ -148,9 +148,9 @@ private[sql] class AvroDeserializer(
       }
 
       case (LONG, TimestampNTZType) => avroType.getLogicalType match {
-        // For backward compatibility, if the Avro type is Long and it is not logical type
-        // (the `null` case), the value is processed as timestamp without time zone type
-        // with millisecond precision.
+        // For keep consistent with TimestampLTZ, if the Avro type is Long and it is not
+        // logical type (the `null` case), the value is processed as timestamp without time

Review comment:
       Let's just say `TimestampNTZ` instead of `timestamp without time zone`, since you used `TimestampLTZ` at the beginning,




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org