[GitHub] [incubator-gobblin] ZihanLi58 commented on a change in pull request #2917: [Gobblin-1077] Fix bug in HiveDataset.resolveConfig

[GitBox <gi...@apache.org>]

ZihanLi58 commented on a change in pull request #2917: [Gobblin-1077] Fix bug in HiveDataset.resolveConfig
URL: https://github.com/apache/incubator-gobblin/pull/2917#discussion_r390627886
 
 

 ##########
 File path: gobblin-data-management/src/test/java/org/apache/gobblin/data/management/copy/hive/HiveDatasetTest.java
 ##########
 @@ -162,5 +164,6 @@ public void testResolveConfig() throws IOException {
         "resPrefix_logicalDb_resPostfix", "Logical DB not resolved correctly");
     Assert.assertEquals(resolvedConfig.getString(HiveDatasetVersionCleaner.REPLACEMENT_HIVE_TABLE_NAME_KEY),
         "resPrefix_logicalTable_resPostfix", "Logical Table not resolved correctly");
+    Assert.assertEquals(resolvedConfig.getString(DUMMY_CONFIG_KEY_WITH_ROOT_VALUE),"testRoot");
 
 Review comment:
   Yes. if the config key ends with the .ROOT_VALUE, it will through RuntimeException in ConfigUtils.propertiesToConfig()

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services