You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/11/18 06:45:25 UTC

[GitHub] [lucene] dweiss commented on a change in pull request #452: LUCENE-10239: upgrade jflex (1.7.0 -> 1.8.2)

dweiss commented on a change in pull request #452:
URL: https://github.com/apache/lucene/pull/452#discussion_r751944910



##########
File path: dev-tools/missing-doclet/src/main/java/org/apache/lucene/missingdoclet/MissingDoclet.java
##########
@@ -331,7 +331,6 @@ private boolean hasInheritedJavadocs(Element element) {
     if (hasOverrides) {
       // If an element has explicit @Overrides annotation, assume it does
       // have inherited javadocs somewhere.
-      reporter.print(Diagnostic.Kind.NOTE, element, "javadoc empty but @Override declared, skipping.");

Review comment:
       Maybe it could be a parameter of the doclet to emit these conditionally? Does it make any sense?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org