You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Kenneth Giusti <kg...@apache.org> on 2016/08/05 19:39:15 UTC
Review Request 50863: Avoid costly context lookup in Event
constructor.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50863/
-----------------------------------------------------------
Review request for qpid, Gordon Sim and Justin Ross.
Bugs: PROTON-1274
https://issues.apache.org/jira/browse/PROTON-1274
Repository: qpid-proton-git
Description
-------
Whenever the event's context is referenced a new wrapped object is constructed. If this object is not used it is immediately deleted. This is the case in the Event constructor and can be avoided.
Diffs
-----
proton-c/bindings/python/proton/__init__.py d7db20b
Diff: https://reviews.apache.org/r/50863/diff/
Testing
-------
python application defined event unit test passes.
Thanks,
Kenneth Giusti
Re: Review Request 50863: Avoid costly context lookup in Event
constructor.
Posted by Gordon Sim <gs...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50863/#review144975
-----------------------------------------------------------
Ship it!
Ship It!
- Gordon Sim
On Aug. 5, 2016, 7:39 p.m., Kenneth Giusti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50863/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2016, 7:39 p.m.)
>
>
> Review request for qpid, Gordon Sim and Justin Ross.
>
>
> Bugs: PROTON-1274
> https://issues.apache.org/jira/browse/PROTON-1274
>
>
> Repository: qpid-proton-git
>
>
> Description
> -------
>
> Whenever the event's context is referenced a new wrapped object is constructed. If this object is not used it is immediately deleted. This is the case in the Event constructor and can be avoided.
>
>
> Diffs
> -----
>
> proton-c/bindings/python/proton/__init__.py d7db20b
>
> Diff: https://reviews.apache.org/r/50863/diff/
>
>
> Testing
> -------
>
> python application defined event unit test passes.
>
>
> Thanks,
>
> Kenneth Giusti
>
>
Re: Review Request 50863: Avoid costly context lookup in Event
constructor.
Posted by Justin Ross <jr...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50863/#review144986
-----------------------------------------------------------
Ship it!
Ship It!
- Justin Ross
On Aug. 5, 2016, 7:39 p.m., Kenneth Giusti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50863/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2016, 7:39 p.m.)
>
>
> Review request for qpid, Gordon Sim and Justin Ross.
>
>
> Bugs: PROTON-1274
> https://issues.apache.org/jira/browse/PROTON-1274
>
>
> Repository: qpid-proton-git
>
>
> Description
> -------
>
> Whenever the event's context is referenced a new wrapped object is constructed. If this object is not used it is immediately deleted. This is the case in the Event constructor and can be avoided.
>
>
> Diffs
> -----
>
> proton-c/bindings/python/proton/__init__.py d7db20b
>
> Diff: https://reviews.apache.org/r/50863/diff/
>
>
> Testing
> -------
>
> python application defined event unit test passes.
>
>
> Thanks,
>
> Kenneth Giusti
>
>