You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by HowardQin <gi...@git.apache.org> on 2015/09/02 11:13:41 UTC
[GitHub] incubator-trafodion pull request: Fix TRAFODION-1450
GitHub user HowardQin opened a pull request:
https://github.com/apache/incubator-trafodion/pull/71
Fix TRAFODION-1450
It seems TEST042 failure is not related to multiple column family support.
compGeneral/EXPECT042 is changed since Aug 18, which gives wrong lines to compare.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HowardQin/incubator-trafodion master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/71.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #71
----
commit 9e19582d4ed559d9d2e7b9bbdd8cd4501d574eaf
Author: Howard Qin <ha...@hp.com>
Date: 2015-09-02T08:49:38Z
Fix TRAFODION-1450
It seems TEST042 failure is not related to multiple column family support.
compGeneral/EXPECT042 is changed since Aug 18,
which gives wrong standard to compare.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: Fix TRAFODION-1450
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/71#discussion_r38564358
--- Diff: core/sql/regress/compGeneral/EXPECTED042 ---
@@ -1795,8 +1795,8 @@ HQC key=SELECT T . VARCHAR0_UNIQ AS T_VARCHAR0_UNIQ , T . CHAR2_2 AS T_CHAR2_2 ,
Start Time 2015/08/18 15:48:56.468470
End Time 2015/08/18 15:48:56.471409
-Elapsed Time 00:00:00.002939
-Compile Time 00:00:00.002939
--- End diff --
Thanks, Selva. I get it now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: Fix TRAFODION-1450
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/71
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: Fix TRAFODION-1450
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/71#discussion_r38545861
--- Diff: core/sql/regress/compGeneral/EXPECTED042 ---
@@ -1795,8 +1795,8 @@ HQC key=SELECT T . VARCHAR0_UNIQ AS T_VARCHAR0_UNIQ , T . CHAR2_2 AS T_CHAR2_2 ,
Start Time 2015/08/18 15:48:56.468470
End Time 2015/08/18 15:48:56.471409
-Elapsed Time 00:00:00.002939
-Compile Time 00:00:00.002939
--- End diff --
A question to the community: Do we expect these times to match up precisely on each run or is this something that should be filtered in a test run?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: Fix TRAFODION-1450
Posted by selvaganesang <gi...@git.apache.org>.
Github user selvaganesang commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/71#discussion_r38550749
--- Diff: core/sql/regress/compGeneral/EXPECTED042 ---
@@ -1795,8 +1795,8 @@ HQC key=SELECT T . VARCHAR0_UNIQ AS T_VARCHAR0_UNIQ , T . CHAR2_2 AS T_CHAR2_2 ,
Start Time 2015/08/18 15:48:56.468470
End Time 2015/08/18 15:48:56.471409
-Elapsed Time 00:00:00.002939
-Compile Time 00:00:00.002939
--- End diff --
The compile time is expected to be less than 1 ms. Last time, when I had
updated the EXPECTED042 file, the compile time in a workstation was more
than 1 ms. So, the expected file was wrong, but the current log file seems
to have less than 1 ms.
Selva
*From:* DaveBirdsall [mailto:notifications@github.com]
*Sent:* Wednesday, September 2, 2015 8:27 AM
*To:* apache/incubator-trafodion <in...@noreply.github.com>
*Subject:* Re: [incubator-trafodion] Fix TRAFODION-1450 (#71)
In core/sql/regress/compGeneral/EXPECTED042
<https://github.com/apache/incubator-trafodion/pull/71#discussion_r38545861>
:
> @@ -1795,8 +1795,8 @@ HQC key=SELECT T . VARCHAR0_UNIQ AS T_VARCHAR0_UNIQ , T . CHAR2_2 AS T_CHAR2_2 ,
>
> Start Time 2015/08/18 15:48:56.468470
> End Time 2015/08/18 15:48:56.471409
> -Elapsed Time 00:00:00.002939
> -Compile Time 00:00:00.002939
A question to the community: Do we expect these times to match up precisely
on each run or is this something that should be filtered in a test run?
—
Reply to this email directly or view it on GitHub
<https://github.com/apache/incubator-trafodion/pull/71/files#r38545861>.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---