You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flex.apache.org by "OmPrakash Muppirala (JIRA)" <ji...@apache.org> on 2014/10/15 22:03:34 UTC

[jira] [Updated] (FLEX-34609) ContainerController has superfluous null checks for _container

     [ https://issues.apache.org/jira/browse/FLEX-34609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

OmPrakash Muppirala updated FLEX-34609:
---------------------------------------
    Assignee: Mihai Chira  (was: OmPrakash Muppirala)

> ContainerController has superfluous null checks for _container
> --------------------------------------------------------------
>
>                 Key: FLEX-34609
>                 URL: https://issues.apache.org/jira/browse/FLEX-34609
>             Project: Apache Flex
>          Issue Type: Improvement
>          Components: .Unspecified - Framework
>    Affects Versions: Apache Flex 4.13.0
>            Reporter: Mihai Chira
>            Assignee: Mihai Chira
>            Priority: Minor
>              Labels: tlf
>             Fix For: Apache Flex 4.14.0
>
>
> ContainerController sometimes checks whether _container is null, yet most of the times it doesn't.
> However, _container is only changed by the initialize() method, which assumes it's not null (through "_container.doubleClickEnabled = true"). Initialize() is only called by the constructor, which in turn is only called by the constructor of TextLineFactoryBase with a non-null Sprite.
> Therefore we could safely remove the few occurrences in which _container is checked for the null value.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)