[GitHub] [beam] KevinGG commented on a diff in pull request #25210: Ignore flags for beam_sql magic

["KevinGG (via GitHub)" <gi...@apache.org>]

KevinGG commented on code in PR #25210:
URL: https://github.com/apache/beam/pull/25210#discussion_r1092382226


##########
sdks/python/apache_beam/runners/interactive/sql/utils.py:
##########
@@ -161,7 +161,8 @@ class OptionsForm:
   generate PipelineOptions to run pipelines.
   """
   def __init__(self):
-    self.options = PipelineOptions()
+    # ignore all flags
+    self.options = PipelineOptions(flags={})

Review Comment:
   To clarify: here `flags` is a parameter of the constructor, not the flags a Beam pipeline would use.
   If not set as `{}`, the `PipelineOptions` is not initiated with a clean state and will use system's command line arguments (the current process uses, which can be anything unrelated to Beam). This is never useful in an interactive setup.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org