You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/11/05 15:48:41 UTC
[GitHub] [activemq-artemis] Asukwo-comfort opened a new pull request #3839: Artemis 3548: Deprecate offensive terms and add new terms
Asukwo-comfort opened a new pull request #3839:
URL: https://github.com/apache/activemq-artemis/pull/3839
Issue link: https://issues.apache.org/jira/projects/ARTEMIS/issues/ARTEMIS-3548
I replaced "master/slave" in internal method with "primary/backup"
@clebertsuconic Is this what you meant?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3839: Artemis 3548: Deprecate offensive terms and add new terms
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3839:
URL: https://github.com/apache/activemq-artemis/pull/3839#issuecomment-962012765
@Asukwo-comfort you need to rebase against main again...
A Pull Request should always be on top of main.. your pull request is showing conflicts against main..
Anyway... I see that you replace these terms in one file.. which is fine
this is a bit more complex than just search and replace. The FileConfigurationParse will have to still be able to read older terms.. and we will need older configuration in the test suite to make sure older XMLs can still be parsed.
So, it is a bit of a search / replace.. but it will be a long task... not very complex.. but it will require some management to make it happen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3839: Artemis 3548: Deprecate offensive terms and add new terms
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3839:
URL: https://github.com/apache/activemq-artemis/pull/3839#issuecomment-962012765
@Asukwo-comfort you need to rebase against main again...
A Pull Request should always be on top of main.. your pull request is showing conflicts against main..
Anyway... I see that you replace these terms in one file.. which is fine
this is a bit more complex than just search and replace. The FileConfigurationParse will have to still be able to read older terms.. and we will need older configuration in the test suite to make sure older XMLs can still be parsed.
So, it is a bit of a search / replace.. but it will be a long task... not very complex.. but it will require some management to make it happen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3839: Artemis 3548: Deprecate offensive terms and add new terms
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3839:
URL: https://github.com/apache/activemq-artemis/pull/3839#issuecomment-962012765
@Asukwo-comfort you need to rebase against main again...
A Pull Request should always be on top of main.. your pull request is showing conflicts against main..
Anyway... I see that you replace these terms in one file.. which is fine
this is a bit more complex than just search and replace. The FileConfigurationParse will have to still be able to read older terms.. and we will need older configuration in the test suite to make sure older XMLs can still be parsed.
So, it is a bit of a search / replace.. but it will be a long task... not very complex.. but it will require some management to make it happen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org