[jira] [Updated] (STORM-2756) STORM-2548 on 1.x-branch broke setting key/value deserializers with the now deprecated setKey/setValue methods

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/STORM-2756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ASF GitHub Bot updated STORM-2756:
----------------------------------
    Labels: pull-request-available  (was: )

> STORM-2548 on 1.x-branch broke setting key/value deserializers with the now deprecated setKey/setValue methods
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: STORM-2756
>                 URL: https://issues.apache.org/jira/browse/STORM-2756
>             Project: Apache Storm
>          Issue Type: Bug
>          Components: storm-kafka-client
>    Affects Versions: 1.2.0
>            Reporter: Stig Rohde Døssing
>            Assignee: Stig Rohde Døssing
>              Labels: pull-request-available
>
> When STORM-2548 was backported, the setKey/setValue methods on KafkaSpoutConfig.Builder were deprecated, and users were directed to use setProp along with the relevant ConsumerConfig constants for setting deserializers instead.
> As part of this change, the KafkaConsumerFactoryDefault switched from using the KafkaConsumer(props, keyDes, valDes) constructor to using the KafkaConsumer(props) constructor. Unfortunately I forgot to update the KafkaSpoutConfig.Builder constructor properly, so if the user configures the deserializer via either the Builder constructor parameters or setKey/setValue, the setting is not put in the kafkaProps map and the deserializer is not used.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)