You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Juergen Donnerstag (JIRA)" <ji...@apache.org> on 2011/04/13 22:20:05 UTC
[jira] [Created] (WICKET-3614) MarkupException appends the markup
stream to the message
MarkupException appends the markup stream to the message
---------------------------------------------------------
Key: WICKET-3614
URL: https://issues.apache.org/jira/browse/WICKET-3614
Project: Wicket
Issue Type: Improvement
Reporter: Juergen Donnerstag
>From email:
Currently MarkupException appends the markup stream to the message.
This makes the error page less useful IMO since the page first shows
the error message, followed by the markup without line precise error
and then repeats the markup again, but now showing the exact location
where the error occurred.
The first markup part should just not be there. I'd suggest the following:
- In the constructors just pass the message to super, not the markup stream
- override toString() and append the markupstream there to the output,
making it possible to log the full error
- in the error page, don't use toString(), but getMessage() and the
getMarkupstream() methods to display the error
Anyone object?
Martijn
I think Martijn is right. I've reworked it a bit. Please have a look. Note that all examples are disable except http://localhost:8080/helloworld which throws an exception. I've also tested it with a MarkupException. I'm not the greated web designer in the world. Feel free to make any changes. Please find a patch attached.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-3614) MarkupException appends the markup
stream to the message
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juergen Donnerstag resolved WICKET-3614.
----------------------------------------
Resolution: Fixed
Fix Version/s: 1.5-RC5
> MarkupException appends the markup stream to the message
> ---------------------------------------------------------
>
> Key: WICKET-3614
> URL: https://issues.apache.org/jira/browse/WICKET-3614
> Project: Wicket
> Issue Type: Improvement
> Reporter: Juergen Donnerstag
> Assignee: Juergen Donnerstag
> Fix For: 1.5-RC5
>
> Attachments: wicket-3614.patch
>
>
> From email:
> Currently MarkupException appends the markup stream to the message.
> This makes the error page less useful IMO since the page first shows
> the error message, followed by the markup without line precise error
> and then repeats the markup again, but now showing the exact location
> where the error occurred.
> The first markup part should just not be there. I'd suggest the following:
> - In the constructors just pass the message to super, not the markup stream
> - override toString() and append the markupstream there to the output,
> making it possible to log the full error
> - in the error page, don't use toString(), but getMessage() and the
> getMarkupstream() methods to display the error
> Anyone object?
> Martijn
> I think Martijn is right. I've reworked it a bit. Please have a look. Note that all examples are disable except http://localhost:8080/helloworld which throws an exception. I've also tested it with a MarkupException. I'm not the greated web designer in the world. Feel free to make any changes. Please find a patch attached.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (WICKET-3614) MarkupException appends the markup
stream to the message
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juergen Donnerstag reassigned WICKET-3614:
------------------------------------------
Assignee: Juergen Donnerstag
> MarkupException appends the markup stream to the message
> ---------------------------------------------------------
>
> Key: WICKET-3614
> URL: https://issues.apache.org/jira/browse/WICKET-3614
> Project: Wicket
> Issue Type: Improvement
> Reporter: Juergen Donnerstag
> Assignee: Juergen Donnerstag
> Attachments: wicket-3614.patch
>
>
> From email:
> Currently MarkupException appends the markup stream to the message.
> This makes the error page less useful IMO since the page first shows
> the error message, followed by the markup without line precise error
> and then repeats the markup again, but now showing the exact location
> where the error occurred.
> The first markup part should just not be there. I'd suggest the following:
> - In the constructors just pass the message to super, not the markup stream
> - override toString() and append the markupstream there to the output,
> making it possible to log the full error
> - in the error page, don't use toString(), but getMessage() and the
> getMarkupstream() methods to display the error
> Anyone object?
> Martijn
> I think Martijn is right. I've reworked it a bit. Please have a look. Note that all examples are disable except http://localhost:8080/helloworld which throws an exception. I've also tested it with a MarkupException. I'm not the greated web designer in the world. Feel free to make any changes. Please find a patch attached.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-3614) MarkupException appends the markup
stream to the message
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juergen Donnerstag updated WICKET-3614:
---------------------------------------
Attachment: wicket-3614.patch
> MarkupException appends the markup stream to the message
> ---------------------------------------------------------
>
> Key: WICKET-3614
> URL: https://issues.apache.org/jira/browse/WICKET-3614
> Project: Wicket
> Issue Type: Improvement
> Reporter: Juergen Donnerstag
> Attachments: wicket-3614.patch
>
>
> From email:
> Currently MarkupException appends the markup stream to the message.
> This makes the error page less useful IMO since the page first shows
> the error message, followed by the markup without line precise error
> and then repeats the markup again, but now showing the exact location
> where the error occurred.
> The first markup part should just not be there. I'd suggest the following:
> - In the constructors just pass the message to super, not the markup stream
> - override toString() and append the markupstream there to the output,
> making it possible to log the full error
> - in the error page, don't use toString(), but getMessage() and the
> getMarkupstream() methods to display the error
> Anyone object?
> Martijn
> I think Martijn is right. I've reworked it a bit. Please have a look. Note that all examples are disable except http://localhost:8080/helloworld which throws an exception. I've also tested it with a MarkupException. I'm not the greated web designer in the world. Feel free to make any changes. Please find a patch attached.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira