You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/09/30 09:42:02 UTC
[GitHub] [camel-quarkus] jamesnetherton opened a new pull request #1855: Document allowContextMapAll native mode limitations
jamesnetherton opened a new pull request #1855:
URL: https://github.com/apache/camel-quarkus/pull/1855
Fixes #1807
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #1855: Document allowContextMapAll native mode limitations
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #1855:
URL: https://github.com/apache/camel-quarkus/pull/1855#discussion_r497387677
##########
File path: tooling/maven-plugin/src/main/java/org/apache/camel/quarkus/maven/UpdateExtensionDocPageMojo.java
##########
@@ -316,6 +320,29 @@ static boolean detectNativeSsl(Path deploymentBasePath) {
}
}
+ static boolean detectAllowContextMapAll(CqCatalog catalog, String artifactId) {
+ final String allowContextMapAll = "allowContextMapAll";
+ Optional<ArtifactModel<?>> optional = catalog.filterModels(artifactId).findFirst();
Review comment:
This may not work as expected if the first model is a LanguageModel or a Dataformat model. I think it would be safer to
```suggestion
return catalog.filterModels(artifactId)
.filter(m -> m instanceof ComponentModel)
.map(m -> (ComponentModel) m)
.anyMatch(/* your options condition here */)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton merged pull request #1855: Document allowContextMapAll native mode limitations
Posted by GitBox <gi...@apache.org>.
jamesnetherton merged pull request #1855:
URL: https://github.com/apache/camel-quarkus/pull/1855
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #1855: Document allowContextMapAll native mode limitations
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #1855:
URL: https://github.com/apache/camel-quarkus/pull/1855#issuecomment-701290965
I like general idea to auto-document `allowContextMapAll` based on the data from the Catalog
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #1855: Document allowContextMapAll native mode limitations
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #1855:
URL: https://github.com/apache/camel-quarkus/pull/1855#discussion_r497409367
##########
File path: tooling/maven-plugin/src/main/java/org/apache/camel/quarkus/maven/UpdateExtensionDocPageMojo.java
##########
@@ -316,6 +320,29 @@ static boolean detectNativeSsl(Path deploymentBasePath) {
}
}
+ static boolean detectAllowContextMapAll(CqCatalog catalog, String artifactId) {
+ final String allowContextMapAll = "allowContextMapAll";
+ Optional<ArtifactModel<?>> optional = catalog.filterModels(artifactId).findFirst();
Review comment:
Thanks. Latest commit implements this suggestion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org