You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Owen O'Malley (Created) (JIRA)" <ji...@apache.org> on 2012/03/22 17:32:22 UTC
[jira] [Created] (HIVE-2894) RCFile Reader doesn't provide access
to Metadata
RCFile Reader doesn't provide access to Metadata
------------------------------------------------
Key: HIVE-2894
URL: https://issues.apache.org/jira/browse/HIVE-2894
Project: Hive
Issue Type: New Feature
Reporter: Owen O'Malley
Assignee: Owen O'Malley
Currently the RCFile writer can add metadata to an RCFile, but the reader doesn't provide an accessor. I'd like to add one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2894) RCFile Reader doesn't provide access
to Metadata
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2894:
------------------------------
Attachment: HIVE-2894.D2421.1.patch
omalley requested code review of "HIVE-2894 [jira] RCFile Reader doesn't provide access to Metadata".
Reviewers: JIRA
hive-2894
Add an accessor for RCFile's metadata.
Currently the RCFile writer can add metadata to an RCFile, but the reader doesn't provide an accessor. I'd like to add one.
TEST PLAN
I added a call to test that the metadata that was passed in was available from
the reader.
REVISION DETAIL
https://reviews.facebook.net/D2421
AFFECTED FILES
ql/src/java/org/apache/hadoop/hive/ql/io/RCFile.java
ql/src/test/org/apache/hadoop/hive/ql/io/TestRCFile.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/5421/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> RCFile Reader doesn't provide access to Metadata
> ------------------------------------------------
>
> Key: HIVE-2894
> URL: https://issues.apache.org/jira/browse/HIVE-2894
> Project: Hive
> Issue Type: New Feature
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: HIVE-2894.D2421.1.patch
>
>
> Currently the RCFile writer can add metadata to an RCFile, but the reader doesn't provide an accessor. I'd like to add one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2894) RCFile Reader doesn't provide access
to Metadata
Posted by "Owen O'Malley (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HIVE-2894:
--------------------------------
Status: Patch Available (was: Open)
I ran the test cases and they pass.
> RCFile Reader doesn't provide access to Metadata
> ------------------------------------------------
>
> Key: HIVE-2894
> URL: https://issues.apache.org/jira/browse/HIVE-2894
> Project: Hive
> Issue Type: New Feature
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: HIVE-2894.D2421.1.patch
>
>
> Currently the RCFile writer can add metadata to an RCFile, but the reader doesn't provide an accessor. I'd like to add one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2894) RCFile Reader doesn't provide access
to Metadata
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237378#comment-13237378 ]
Phabricator commented on HIVE-2894:
-----------------------------------
omalley has committed the revision "HIVE-2894 [jira] RCFile Reader doesn't provide access to Metadata".
Change committed by hashutosh.
REVISION DETAIL
https://reviews.facebook.net/D2421
COMMIT
https://reviews.facebook.net/rHIVE1304693
> RCFile Reader doesn't provide access to Metadata
> ------------------------------------------------
>
> Key: HIVE-2894
> URL: https://issues.apache.org/jira/browse/HIVE-2894
> Project: Hive
> Issue Type: New Feature
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.9.0
>
> Attachments: HIVE-2894.D2421.1.patch
>
>
> Currently the RCFile writer can add metadata to an RCFile, but the reader doesn't provide an accessor. I'd like to add one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2894) RCFile Reader doesn't provide access
to Metadata
Posted by "Ashutosh Chauhan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-2894:
-----------------------------------
Resolution: Fixed
Fix Version/s: 0.9.0
Status: Resolved (was: Patch Available)
Committed to trunk. Thanks, Owen!
> RCFile Reader doesn't provide access to Metadata
> ------------------------------------------------
>
> Key: HIVE-2894
> URL: https://issues.apache.org/jira/browse/HIVE-2894
> Project: Hive
> Issue Type: New Feature
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.9.0
>
> Attachments: HIVE-2894.D2421.1.patch
>
>
> Currently the RCFile writer can add metadata to an RCFile, but the reader doesn't provide an accessor. I'd like to add one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2894) RCFile Reader doesn't provide access
to Metadata
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237373#comment-13237373 ]
Phabricator commented on HIVE-2894:
-----------------------------------
ashutoshc has accepted the revision "HIVE-2894 [jira] RCFile Reader doesn't provide access to Metadata".
+1 will commit this one soon
REVISION DETAIL
https://reviews.facebook.net/D2421
BRANCH
h-2894
> RCFile Reader doesn't provide access to Metadata
> ------------------------------------------------
>
> Key: HIVE-2894
> URL: https://issues.apache.org/jira/browse/HIVE-2894
> Project: Hive
> Issue Type: New Feature
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: HIVE-2894.D2421.1.patch
>
>
> Currently the RCFile writer can add metadata to an RCFile, but the reader doesn't provide an accessor. I'd like to add one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2894) RCFile Reader doesn't provide access
to Metadata
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237464#comment-13237464 ]
Hudson commented on HIVE-2894:
------------------------------
Integrated in Hive-trunk-h0.21 #1330 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1330/])
HIVE-2894 [jira] RCFile Reader doesn't provide access to Metadata
(Owen O'Malley via Ashutosh Chauhan)
Summary:
hive-2894
Add an accessor for RCFile's metadata.
Currently the RCFile writer can add metadata to an RCFile, but the reader
doesn't provide an accessor. I'd like to add one.
Test Plan:
I added a call to test that the metadata that was passed in was available from
the reader.
Reviewers: JIRA, ashutoshc
Reviewed By: ashutoshc
Differential Revision: https://reviews.facebook.net/D2421 (Revision 1304693)
Result = SUCCESS
hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304693
Files :
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/RCFile.java
* /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/io/TestRCFile.java
> RCFile Reader doesn't provide access to Metadata
> ------------------------------------------------
>
> Key: HIVE-2894
> URL: https://issues.apache.org/jira/browse/HIVE-2894
> Project: Hive
> Issue Type: New Feature
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.9.0
>
> Attachments: HIVE-2894.D2421.1.patch
>
>
> Currently the RCFile writer can add metadata to an RCFile, but the reader doesn't provide an accessor. I'd like to add one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira