You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Cong Wang <cw...@twopensource.com> on 2015/12/11 06:20:41 UTC

Review Request 41245: Use ethtool -k lo to check ethtool command

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41245/
-----------------------------------------------------------

Review request for mesos, David Robinson, Ian Downes, and Jie Yu.


Repository: mesos


Description
-------

David reported that on CentOS5 part of ethtool --version output sends to stderr instead of stdout, which leads this output in our log.


Diffs
-----

  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 7c1724a4ca5c45bb214e5129743e0644c9ca9661 

Diff: https://reviews.apache.org/r/41245/diff/


Testing
-------

Manually start mesos slave


Thanks,

Cong Wang


Re: Review Request 41245: Use ethtool -k lo to check ethtool command

Posted by David Robinson <dr...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41245/#review109965
-----------------------------------------------------------

Ship it!


Ship It!

- David Robinson


On Dec. 11, 2015, 5:20 a.m., Cong Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41245/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2015, 5:20 a.m.)
> 
> 
> Review request for mesos, David Robinson, Ian Downes, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> David reported that on CentOS5 part of ethtool --version output sends to stderr instead of stdout, which leads this output in our log.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 7c1724a4ca5c45bb214e5129743e0644c9ca9661 
> 
> Diff: https://reviews.apache.org/r/41245/diff/
> 
> 
> Testing
> -------
> 
> Manually start mesos slave
> 
> 
> Thanks,
> 
> Cong Wang
> 
>


Re: Review Request 41245: Use ethtool -k lo to check ethtool command

Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41245/#review109990
-----------------------------------------------------------

Ship it!


Ship It!

- Ian Downes


On Dec. 10, 2015, 9:20 p.m., Cong Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41245/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2015, 9:20 p.m.)
> 
> 
> Review request for mesos, David Robinson, Ian Downes, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> David reported that on CentOS5 part of ethtool --version output sends to stderr instead of stdout, which leads this output in our log.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 7c1724a4ca5c45bb214e5129743e0644c9ca9661 
> 
> Diff: https://reviews.apache.org/r/41245/diff/
> 
> 
> Testing
> -------
> 
> Manually start mesos slave
> 
> 
> Thanks,
> 
> Cong Wang
> 
>