You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2019/10/25 21:06:05 UTC

[GitHub] [helix] pkuwm commented on a change in pull request #520: Refactor soft constraints to simply the algorithm and fix potential issues.

pkuwm commented on a change in pull request #520: Refactor soft constraints to simply the algorithm and fix potential issues.
URL: https://github.com/apache/helix/pull/520#discussion_r339231834
 
 

 ##########
 File path: helix-core/pom.xml
 ##########
 @@ -139,6 +139,11 @@ under the License.
       <artifactId>commons-math</artifactId>
       <version>2.1</version>
     </dependency>
+    <dependency>
+      <groupId>org.apache.commons</groupId>
 
 Review comment:
   It seems we don't have to introduce a new lib just for sigmoid. We can use Math.exp() for your case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org