You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2015/12/17 03:38:47 UTC
Re: Review Request 41406: Unified Container: Added path helper method
to get image layer manifest on local store.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41406/
-----------------------------------------------------------
(Updated Dec. 16, 2015, 6:38 p.m.)
Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
Bugs: MESOS-2980
https://issues.apache.org/jira/browse/MESOS-2980
Repository: mesos
Description
-------
Unified Container: Added path helper method to get image layer manifest on local store.
Diffs (updated)
-----
src/slave/containerizer/mesos/provisioner/docker/paths.hpp 7e5122d956c82e6cbd62fc217158205ea05f4290
src/slave/containerizer/mesos/provisioner/docker/paths.cpp 9c1f6a19c59b12f58b0550d022f9128e7015a4e9
Diff: https://reviews.apache.org/r/41406/diff/
Testing
-------
make check
Thanks,
Gilbert Song
Re: Review Request 41406: Unified Container: Added path helper method
to get image layer manifest on local store.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41406/
-----------------------------------------------------------
(Updated Dec. 18, 2015, 1:31 p.m.)
Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
Bugs: MESOS-2980
https://issues.apache.org/jira/browse/MESOS-2980
Repository: mesos
Description
-------
Unified Container: Added path helper method to get image layer manifest on local store.
Diffs (updated)
-----
src/slave/containerizer/mesos/provisioner/docker/paths.hpp 7e5122d956c82e6cbd62fc217158205ea05f4290
src/slave/containerizer/mesos/provisioner/docker/paths.cpp 9c1f6a19c59b12f58b0550d022f9128e7015a4e9
Diff: https://reviews.apache.org/r/41406/diff/
Testing
-------
make check
Thanks,
Gilbert Song
Re: Review Request 41406: Unified Container: Added path helper method
to get image layer manifest on local store.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41406/#review110900
-----------------------------------------------------------
Ship it!
Ship It!
- Timothy Chen
On Dec. 17, 2015, 2:38 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41406/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2015, 2:38 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-2980
> https://issues.apache.org/jira/browse/MESOS-2980
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Unified Container: Added path helper method to get image layer manifest on local store.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/paths.hpp 7e5122d956c82e6cbd62fc217158205ea05f4290
> src/slave/containerizer/mesos/provisioner/docker/paths.cpp 9c1f6a19c59b12f58b0550d022f9128e7015a4e9
>
> Diff: https://reviews.apache.org/r/41406/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 41406: Unified Container: Added path helper method
to get image layer manifest on local store.
Posted by Gilbert Song <so...@gmail.com>.
> On Dec. 16, 2015, 9:38 p.m., Timothy Chen wrote:
> > src/slave/containerizer/mesos/provisioner/docker/paths.hpp, line 40
> > <https://reviews.apache.org/r/41406/diff/2/?file=1168109#file1168109line40>
> >
> > VERSION This is only relevant for local puller right?
Currently yes. I am following the way docker save info in each layer. We may need this information in the future. So we may want to keep it(only the size of `float` number).
- Gilbert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41406/#review110901
-----------------------------------------------------------
On Dec. 16, 2015, 6:38 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41406/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2015, 6:38 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-2980
> https://issues.apache.org/jira/browse/MESOS-2980
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Unified Container: Added path helper method to get image layer manifest on local store.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/paths.hpp 7e5122d956c82e6cbd62fc217158205ea05f4290
> src/slave/containerizer/mesos/provisioner/docker/paths.cpp 9c1f6a19c59b12f58b0550d022f9128e7015a4e9
>
> Diff: https://reviews.apache.org/r/41406/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 41406: Unified Container: Added path helper method
to get image layer manifest on local store.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41406/#review110901
-----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/docker/paths.hpp (line 40)
<https://reviews.apache.org/r/41406/#comment170899>
VERSION This is only relevant for local puller right?
- Timothy Chen
On Dec. 17, 2015, 2:38 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41406/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2015, 2:38 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-2980
> https://issues.apache.org/jira/browse/MESOS-2980
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Unified Container: Added path helper method to get image layer manifest on local store.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/paths.hpp 7e5122d956c82e6cbd62fc217158205ea05f4290
> src/slave/containerizer/mesos/provisioner/docker/paths.cpp 9c1f6a19c59b12f58b0550d022f9128e7015a4e9
>
> Diff: https://reviews.apache.org/r/41406/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>