You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/07/08 21:26:43 UTC

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4399: Moving handling of NULL values from RecordReaders to NullValueTransfo…

jackjlli commented on a change in pull request #4399: Moving handling of NULL values from RecordReaders to NullValueTransfo…
URL: https://github.com/apache/incubator-pinot/pull/4399#discussion_r301306848
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/data/readers/RecordReaderUtils.java
 ##########
 @@ -112,8 +112,9 @@ public static Object convert(FieldSpec fieldSpec, @Nullable Object value) {
   public static Object convertSingleValue(FieldSpec fieldSpec, @Nullable Object value) {
     if (value == null) {
       // Do not allow default value for time column
 
 Review comment:
   Move this comment or add a description to `NullValueTransformer`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org