[jira] [Commented] (ARTEMIS-590) Allow NettyConnector to use the default SSL Context

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981701#comment-15981701 ] 

ASF GitHub Bot commented on ARTEMIS-590:
----------------------------------------

GitHub user jbertram opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1225

    ARTEMIS-590 connector option to use default SSL context

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-590

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1225.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1225
    
----
commit 1ba1a9e7c6f58c3536dfa4cd059430eeebd4e4fc
Author: Justin Bertram <jb...@apache.org>
Date:   2017-04-18T16:40:08Z

    ARTEMIS-590 connector option to use default SSL context

----


> Allow NettyConnector to use the default SSL Context
> ---------------------------------------------------
>
>                 Key: ARTEMIS-590
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-590
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: Dominique Toupin
>            Assignee: Justin Bertram
>            Priority: Minor
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> It would be nice if NettyConnector was able to use the "default" SSL Context (SSLContext.getDefault()) as the client might already have defined it...
> I believe all it takes is a new system property (e.g. org.apache.activemq.ssl.useDefaultSSLContext) and the addition of an if in NettyConnector.java where the SSL Context would otherwise be created using the other org.apache.activemq.ssl.* properties
> e.g.
> {code:java}
> @@ -396,11 +395,7 @@ public class NettyConnector extends AbstractConnector {
>        final SSLContext context;
>        if (sslEnabled) {
>           try {
> +           if (System.getProperty(ACTIVEMQ_USE_DEFAULT_SSL_CONTEXT_PROP_NAME) != null)
> +              context = SSLContext.getDefault();
> +           else {
>                // HORNETQ-680 - override the server-side config if client-side system properties are set
>                String realKeyStorePath = keyStorePath;
>                String realKeyStoreProvider = keyStoreProvider;
>                String realKeyStorePassword = keyStorePassword;
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)